{"thread":{"id":"42503","subject":"[PATCH 2/2] completion: add git status","startedAt":"2016-05-31T23:42:18Z","lastAt":"2016-06-01T09:05:44Z","messageCount":3,"participants":["Thomas Braun","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"287959","messageId":"b881e8b7-8364-f78b-d7ac-817850783c6e@virtuell-zuhause.de","threadId":"42503","inReplyTo":null,"subject":"[PATCH 2/2] completion: add git status","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2016-05-31T23:42:18Z","receivedAt":"2016-05-31T23:42:18Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n---\n contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++\n 1 file changed, 29 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 57a0acc..96b7d86 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1782,6 +1782,35 @@ _git_stage ()\n \t_git_add\n }\n +_git_status ()\n+{\n+\tcase \"$cur\" in\n+\t--ignore-submodules=*)\n+\t\t__gitcomp \"none untracked dirty all\" \"\" \"${cur##--ignore-submodules=}\"\n+\t\treturn\n+\t\t;;\n+\t--untracked-files=*)\n+\t\t__gitcomp \"$(__git_untracked_file_modes)\" \"\" \"${cur##--untracked-files=}\"\n+\t\treturn\n+\t\t;;\n+\t--column=*)\n+\t\t__gitcomp \"\n+\t\t\talways never auto column row plain dense nodense\n+\t\t\t\" \"\" \"${cur##--column=}\"\n+\t\treturn\n+\t\t;;\n+\t--*)\n+\t\t__gitcomp \"\n+\t\t\t--short --branch --porcelain --long --verbose\n+\t\t\t--untracked-files= --ignore-submodules= --ignored\n+\t\t\t--column= --no-column\n+\t\t\t\"\n+\t\treturn\n+\t\t;;\n+\tesac\n+\t__git_complete_file\n+}\n+\n __git_config_get_set_variables ()\n {\n \tlocal prevword word config_file= c=$cword\n-- \n2.8.3.windows.1\n"},{"id":"287971","messageId":"20160601040722.GB18978@sigill.intra.peff.net","threadId":"42503","inReplyTo":"b881e8b7-8364-f78b-d7ac-817850783c6e@virtuell-zuhause.de","subject":"Re: [PATCH 2/2] completion: add git status","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-06-01T04:07:23Z","receivedAt":"2016-06-01T04:07:23Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jun 01, 2016 at 01:42:18AM +0200, Thomas Braun wrote:\n\n> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n> ---\n>  contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++\n>  1 file changed, 29 insertions(+)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 57a0acc..96b7d86 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1782,6 +1782,35 @@ _git_stage ()\n>  \t_git_add\n>  }\n>  +_git_status ()\n\nThis patch has the same funniness as the other. Weird.\n\n> +{\n> +\tcase \"$cur\" in\n> +\t--ignore-submodules=*)\n> +\t\t__gitcomp \"none untracked dirty all\" \"\" \"${cur##--ignore-submodules=}\"\n> +\t\treturn\n> +\t\t;;\n> +\t--untracked-files=*)\n> +\t\t__gitcomp \"$(__git_untracked_file_modes)\" \"\" \"${cur##--untracked-files=}\"\n\nSame comment on $() here.\n\n> +\t\treturn\n> +\t\t;;\n> +\t--column=*)\n> +\t\t__gitcomp \"\n> +\t\t\talways never auto column row plain dense nodense\n> +\t\t\t\" \"\" \"${cur##--column=}\"\n> +\t\treturn\n> +\t\t;;\n> +\t--*)\n> +\t\t__gitcomp \"\n> +\t\t\t--short --branch --porcelain --long --verbose\n> +\t\t\t--untracked-files= --ignore-submodules= --ignored\n> +\t\t\t--column= --no-column\n> +\t\t\t\"\n> +\t\treturn\n> +\t\t;;\n> +\tesac\n> +\t__git_complete_file\n> +}\n\nThe rest of it (both the overall goal, and the patch itself) look OK to\nme.\n\n-Peff\n"},{"id":"287992","messageId":"5ce10133-e982-4c02-7f97-77d03231e677@virtuell-zuhause.de","threadId":"42503","inReplyTo":"20160601040722.GB18978@sigill.intra.peff.net","subject":"Re: [PATCH 2/2] completion: add git status","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2016-06-01T09:05:44Z","receivedAt":"2016-06-01T09:05:44Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"> Jeff King <peff@peff.net> hat am 1. Juni 2016 um 06:07 geschrieben:\n> \n> \n> On Wed, Jun 01, 2016 at 01:42:18AM +0200, Thomas Braun wrote:\n> \n> > Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n> > ---\n> >  contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++\n> >  1 file changed, 29 insertions(+)\n> > \n> > diff --git a/contrib/completion/git-completion.bash\n> > b/contrib/completion/git-completion.bash\n> > index 57a0acc..96b7d86 100644\n> > --- a/contrib/completion/git-completion.bash\n> > +++ b/contrib/completion/git-completion.bash\n> > @@ -1782,6 +1782,35 @@ _git_stage ()\n> >  \t_git_add\n> >  }\n> >  +_git_status ()\n> \n> This patch has the same funniness as the other. Weird.\n\nShould be fixed now.\n\n> > +{\n> > +\tcase \"$cur\" in\n> > +\t--ignore-submodules=*)\n> > +\t\t__gitcomp \"none untracked dirty all\" \"\" \"${cur##--ignore-submodules=}\"\n> > +\t\treturn\n> > +\t\t;;\n> > +\t--untracked-files=*)\n> > +\t\t__gitcomp \"$(__git_untracked_file_modes)\" \"\" \"${cur##--untracked-files=}\"\n> \n> Same comment on $() here.\n\nFixed.\n\n> > +\t\treturn\n> > +\t\t;;\n> > +\t--column=*)\n> > +\t\t__gitcomp \"\n> > +\t\t\talways never auto column row plain dense nodense\n> > +\t\t\t\" \"\" \"${cur##--column=}\"\n> > +\t\treturn\n> > +\t\t;;\n> > +\t--*)\n> > +\t\t__gitcomp \"\n> > +\t\t\t--short --branch --porcelain --long --verbose\n> > +\t\t\t--untracked-files= --ignore-submodules= --ignored\n> > +\t\t\t--column= --no-column\n> > +\t\t\t\"\n> > +\t\treturn\n> > +\t\t;;\n> > +\tesac\n> > +\t__git_complete_file\n> > +}\n> \n> The rest of it (both the overall goal, and the patch itself) look OK to\n> me.\n\nThanks,\nThomas\n"}]}