{"thread":{"id":"42383","subject":"[PATCH v1 1/2] travis-ci: enable Git SVN tests t91xx on Linux","startedAt":"2016-05-19T09:10:07Z","lastAt":"2016-05-23T21:47:35Z","messageCount":10,"participants":["larsxschneider@gmail.com","Eric Wong","Junio C Hamano","Lars Schneider"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"286970","messageId":"1463649009-56941-1-git-send-email-larsxschneider@gmail.com","threadId":"42383","inReplyTo":null,"subject":"[PATCH v1 0/2] travis-ci: enable Git SVN tests","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-05-19T09:10:07Z","receivedAt":"2016-05-19T09:10:07Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nHi,\n\nthis mini series enables SVN tests on Linux. Installing the Perl SVN libraries\nwas not that straight forward on OSX and therefore I skipped it (plus the OS X\ntests take quite some time already).\n\nThe most notable change is the rename of two SVN test cases. I did that to\nidentify tests that need to run sequentially using prove [1]. Is this an\nacceptable pattern? If yes, then I will document it in t/README.\n\nThanks,\nLars\n\n[1] https://github.com/Perl-Toolchain-Gang/Test-Harness/pull/5\n\nLars Schneider (2):\n travis-ci: enable Git SVN tests t91xx on Linux\n travis-ci: enable sequential test execution for t9113 and 9126\n\n .travis.yml | 4 +++-\n ...-svn-dcommit-new-file.sh => t9113-git-svn-dcommit-new-file.seq.sh} | 0\n ...ctory.sh => t9126-git-svn-follow-deleted-readded-directory.seq.sh} | 0\n 3 files changed, 3 insertions(+), 1 deletion(-)\n rename t/{t9113-git-svn-dcommit-new-file.sh => t9113-git-svn-dcommit-new-file.seq.sh} (100%)\n rename t/{t9126-git-svn-follow-deleted-readded-directory.sh => t9126-git-svn-follow-deleted-readded-directory.seq.sh} (100%)\n\n--\n2.5.1\n"},{"id":"286969","messageId":"1463649009-56941-2-git-send-email-larsxschneider@gmail.com","threadId":"42383","inReplyTo":"1463649009-56941-1-git-send-email-larsxschneider@gmail.com","subject":"[PATCH v1 1/2] travis-ci: enable Git SVN tests t91xx on Linux","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-05-19T09:10:08Z","receivedAt":"2016-05-19T09:10:08Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nInstall the \"git-svn\" package to make the Perl SVN libraries available\nto the Git SVN tests on Travis-CI Linux build machines.\n\nSigned-off-by: Lars Schneider \n---\n .travis.yml | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/.travis.yml b/.travis.yml\nindex adab5b8..c20ec54 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -18,6 +18,7 @@ addons:\n apt:\n packages:\n - language-pack-is\n+ - git-svn\n \n env:\n global:\n-- \n2.5.1\n"},{"id":"286971","messageId":"1463649009-56941-3-git-send-email-larsxschneider@gmail.com","threadId":"42383","inReplyTo":"1463649009-56941-1-git-send-email-larsxschneider@gmail.com","subject":"[PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-05-19T09:10:09Z","receivedAt":"2016-05-19T09:10:09Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nEnable t9113 and 9126 by defining the SVNSERVER_PORT. Since both tests\nopen the same port during execution, they cannot run in parallel. Add\na \".seq.sh\" suffix to the test files and teach \"prove\" to run them\nsequentially.\n\nSigned-off-by: Lars Schneider \n---\n .travis.yml | 3 ++-\n ...t-svn-dcommit-new-file.sh => t9113-git-svn-dcommit-new-file.seq.sh} | 0\n ...ectory.sh => t9126-git-svn-follow-deleted-readded-directory.seq.sh} | 0\n 3 files changed, 2 insertions(+), 1 deletion(-)\n rename t/{t9113-git-svn-dcommit-new-file.sh => t9113-git-svn-dcommit-new-file.seq.sh} (100%)\n rename t/{t9126-git-svn-follow-deleted-readded-directory.sh => t9126-git-svn-follow-deleted-readded-directory.seq.sh} (100%)\n\ndiff --git a/.travis.yml b/.travis.yml\nindex c20ec54..605ced1 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -29,9 +29,10 @@ env:\n - LINUX_P4_VERSION=\"16.1\"\n - LINUX_GIT_LFS_VERSION=\"1.2.0\"\n - DEFAULT_TEST_TARGET=prove\n- - GIT_PROVE_OPTS=\"--timer --jobs 3 --state=failed,slow,save\"\n+ - GIT_PROVE_OPTS=\"--timer --jobs 3 --state=failed,slow,save --rules='seq=*.seq.*' --rules='par=**'\"\n - GIT_TEST_OPTS=\"--verbose --tee\"\n - GIT_TEST_CLONE_2GB=YesPlease\n+ - SVNSERVE_PORT=3690\n # t9810 occasionally fails on Travis CI OS X\n # t9816 occasionally fails with \"TAP out of sequence errors\" on Travis CI OS X\n - GIT_SKIP_TESTS=\"t9810 t9816\"\ndiff --git a/t/t9113-git-svn-dcommit-new-file.sh b/t/t9113-git-svn-dcommit-new-file.seq.sh\nsimilarity index 100%\nrename from t/t9113-git-svn-dcommit-new-file.sh\nrename to t/t9113-git-svn-dcommit-new-file.seq.sh\ndiff --git a/t/t9126-git-svn-follow-deleted-readded-directory.sh b/t/t9126-git-svn-follow-deleted-readded-directory.seq.sh\nsimilarity index 100%\nrename from t/t9126-git-svn-follow-deleted-readded-directory.sh\nrename to t/t9126-git-svn-follow-deleted-readded-directory.seq.sh\n-- \n2.5.1\n"},{"id":"286974","messageId":"20160519100658.GA20225@dcvr.yhbt.net","threadId":"42383","inReplyTo":"1463649009-56941-3-git-send-email-larsxschneider@gmail.com","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-05-19T10:06:58Z","receivedAt":"2016-05-19T10:06:58Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"larsxschneider@gmail.com wrote:\n> Enable t9113 and 9126 by defining the SVNSERVER_PORT. Since both tests\n> open the same port during execution, they cannot run in parallel. Add\n> a \".seq.sh\" suffix to the test files and teach \"prove\" to run them\n> sequentially.\n\nInteresting, I guess I forgot the problem because had some\nrules in config.mak to serialize them for many years, now :x\n\nAnyways, how about making the tests run on separate ports and\nnot worry about serializing them at all? Maybe there was a\nreason we didn't do this years ago, but I forget...\n\nBut probably the best (but I guess more difficult) option is to\nget svnserve+apache to do socket activation off a random port\nbound by a parent process at startup.\n"},{"id":"286997","messageId":"xmqqwpmqj7m1.fsf@gitster.mtv.corp.google.com","threadId":"42383","inReplyTo":"20160519100658.GA20225@dcvr.yhbt.net","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-19T17:11:18Z","receivedAt":"2016-05-19T17:11:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Anyways, how about making the tests run on separate ports and\n> not worry about serializing them at all?\n\nYeah, that does sound like a more sensible approach.\n"},{"id":"287189","messageId":"7A9DE9C1-4AC7-4FF3-B8B1-26DE84BA625B@gmail.com","threadId":"42383","inReplyTo":"xmqqwpmqj7m1.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-05-22T10:10:28Z","receivedAt":"2016-05-22T10:10:28Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 19 May 2016, at 19:11, Junio C Hamano wrote:\n> \n> Eric Wong writes:\n> \n>> Anyways, how about making the tests run on separate ports and\n>> not worry about serializing them at all?\n> \n> Yeah, that does sound like a more sensible approach.\n\nMakes sense. However, it's not something I will tackle soon.\nWould you be willing to pick up $gmane/295048 (the first patch) as is \nand drop $gmane/295050 (the patch discussed here)? Then the majority\nof Git SVN tests would run on Travis CI.\n\nThanks,\nLars\n"},{"id":"287212","messageId":"20160522202617.GA1866@dcvr.yhbt.net","threadId":"42383","inReplyTo":"7A9DE9C1-4AC7-4FF3-B8B1-26DE84BA625B@gmail.com","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-05-22T20:26:17Z","receivedAt":"2016-05-22T20:26:17Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Lars Schneider wrote:\n> > On 19 May 2016, at 19:11, Junio C Hamano wrote:\n> > Eric Wong writes:\n> > \n> >> Anyways, how about making the tests run on separate ports and\n> >> not worry about serializing them at all?\n> > \n> > Yeah, that does sound like a more sensible approach.\n> \n> Makes sense. However, it's not something I will tackle soon.\n> Would you be willing to pick up $gmane/295048 (the first patch) as is \n> and drop $gmane/295050 (the patch discussed here)? Then the majority\n> of Git SVN tests would run on Travis CI.\n\nSure, patch 1/2 is signed-off and pushed to my repo. Thanks.\n\nI'll try to take a look at parallelizing the other tests instead\nof marking them sequential some other time.\n\nJunio:\n\nThe following changes since commit 3916adf9978b020f9a9b165f4c1c109046899560:\n\n Sync with 2.8.3 (2016-05-18 15:33:57 -0700)\n\nare available in the git repository at:\n\n git://bogomips.org/git-svn.git svn-travis\n\nfor you to fetch changes up to e7e9f5e7a1d39bf210c59428cd2a98f0a6abba0b:\n\n travis-ci: enable Git SVN tests t91xx on Linux (2016-05-22 20:20:28 +0000)\n\n----------------------------------------------------------------\nLars Schneider (1):\n travis-ci: enable Git SVN tests t91xx on Linux\n\n .travis.yml | 1 +\n 1 file changed, 1 insertion(+)\n"},{"id":"287315","messageId":"xmqq60u48o6v.fsf@gitster.mtv.corp.google.com","threadId":"42383","inReplyTo":"7A9DE9C1-4AC7-4FF3-B8B1-26DE84BA625B@gmail.com","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-23T21:22:16Z","receivedAt":"2016-05-23T21:22:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lars Schneider writes:\n\n>> On 19 May 2016, at 19:11, Junio C Hamano wrote:\n>> \n>> Eric Wong writes:\n>> \n>>> Anyways, how about making the tests run on separate ports and\n>>> not worry about serializing them at all?\n>> \n>> Yeah, that does sound like a more sensible approach.\n>\n> Makes sense. However, it's not something I will tackle soon.\n> Would you be willing to pick up $gmane/295048 (the first patch) as is \n> and drop $gmane/295050 (the patch discussed here)? Then the majority\n> of Git SVN tests would run on Travis CI.\n\nI am not sure if adding git-svn alone would be a good change.\nWouldn't it invite false failures from running these conflicting\ntests at the same time?\n"},{"id":"287319","messageId":"20160523213254.GA11731@dcvr.yhbt.net","threadId":"42383","inReplyTo":"xmqq60u48o6v.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-05-23T21:32:54Z","receivedAt":"2016-05-23T21:32:54Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Lars Schneider writes:\n> >> On 19 May 2016, at 19:11, Junio C Hamano wrote:\n> >> Eric Wong writes:\n> >> \n> >>> Anyways, how about making the tests run on separate ports and\n> >>> not worry about serializing them at all?\n> >> \n> >> Yeah, that does sound like a more sensible approach.\n> >\n> > Makes sense. However, it's not something I will tackle soon.\n> > Would you be willing to pick up $gmane/295048 (the first patch) as is \n> > and drop $gmane/295050 (the patch discussed here)? Then the majority\n> > of Git SVN tests would run on Travis CI.\n> \n> I am not sure if adding git-svn alone would be a good change.\n> Wouldn't it invite false failures from running these conflicting\n> tests at the same time?\n\nThe problematic tests won't run unless *_PORT variables are set;\nwhich AFAIK they aren't, yet.\n"},{"id":"287321","messageId":"xmqqoa7w78g8.fsf@gitster.mtv.corp.google.com","threadId":"42383","inReplyTo":"20160523213254.GA11731@dcvr.yhbt.net","subject":"Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-23T21:47:35Z","receivedAt":"2016-05-23T21:47:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Junio C Hamano wrote:\n>> Lars Schneider writes:\n>> >> On 19 May 2016, at 19:11, Junio C Hamano wrote:\n>> >> Eric Wong writes:\n>> >> \n>> >>> Anyways, how about making the tests run on separate ports and\n>> >>> not worry about serializing them at all?\n>> >> \n>> >> Yeah, that does sound like a more sensible approach.\n>> >\n>> > Makes sense. However, it's not something I will tackle soon.\n>> > Would you be willing to pick up $gmane/295048 (the first patch) as is \n>> > and drop $gmane/295050 (the patch discussed here)? Then the majority\n>> > of Git SVN tests would run on Travis CI.\n>> \n>> I am not sure if adding git-svn alone would be a good change.\n>> Wouldn't it invite false failures from running these conflicting\n>> tests at the same time?\n>\n> The problematic tests won't run unless *_PORT variables are set;\n> which AFAIK they aren't, yet.\n\nAhh, OK that is perfect.\n\nThanks!\n"}]}