{"thread":{"id":"4232","subject":"[PATCH] compress output of `cd' when installing templates","startedAt":"2006-05-21T15:41:02Z","lastAt":"2006-05-21T18:23:44Z","messageCount":3,"participants":["Gang Chen","Timo Hirvonen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"20395","messageId":"83mzdbjshd.fsf@skypiea.yi.org","threadId":"4232","inReplyTo":null,"subject":"[PATCH] compress output of `cd' when installing templates","fromName":"Gang Chen","fromEmail":"goncha.ml@gmail.com","sentAt":"2006-05-21T15:41:02Z","receivedAt":"2006-05-21T15:41:02Z","isPatch":true,"sender":{"key":"goncha.ml@gmail.com","avatar":null},"body":"When CDPATH is set in Bash, `cd' writes new working directory to\nstdout, which corrupts output of `tar cf - .'.\n\nSigned-off-by: Gang Chen <goncha.ml@gmail.com>\n\n---\n\n Makefile |    2 +-\n 1 files changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/templates/Makefile b/templates/Makefile\nindex 8f7f4fe..cb67489 100644\n--- a/templates/Makefile\n+++ b/templates/Makefile\n@@ -44,5 +44,5 @@ clean:\n \n install: all\n \t$(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))\n-\t(cd blt && $(TAR) cf - .) | \\\n+\t(cd blt > /dev/null && $(TAR) cf - .) | \\\n \t(cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf -)\n\n-- \nIf it makes you happy, it can't be that bad.\n"},{"id":"20396","messageId":"20060521185421.a91bf118.tihirvon@gmail.com","threadId":"4232","inReplyTo":"83mzdbjshd.fsf@skypiea.yi.org","subject":"Re: [PATCH] compress output of `cd' when installing templates","fromName":"Timo Hirvonen","fromEmail":"tihirvon@gmail.com","sentAt":"2006-05-21T15:54:21Z","receivedAt":"2006-05-21T15:54:21Z","isPatch":true,"sender":{"key":"tihirvon@gmail.com","avatar":null},"body":"Gang Chen <goncha.ml@gmail.com> wrote:\n\n> When CDPATH is set in Bash, `cd' writes new working directory to\n> stdout, which corrupts output of `tar cf - .'.\n\nFix bash instead, or just don't export CDPATH.  It is used by bash only\nso exporting it is unnecessary.\n\n-- \nhttp://onion.dynserv.net/~timo/\n"},{"id":"20400","messageId":"7vy7wvi6dr.fsf@assigned-by-dhcp.cox.net","threadId":"4232","inReplyTo":"20060521185421.a91bf118.tihirvon@gmail.com","subject":"Re: [PATCH] compress output of `cd' when installing templates","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-21T18:23:44Z","receivedAt":"2006-05-21T18:23:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Timo Hirvonen <tihirvon@gmail.com> writes:\n\n> Gang Chen <goncha.ml@gmail.com> wrote:\n>\n>> When CDPATH is set in Bash, `cd' writes new working directory to\n>> stdout, which corrupts output of `tar cf - .'.\n>\n> Fix bash instead, or just don't export CDPATH.  It is used by bash only\n> so exporting it is unnecessary.\n\nThanks.\n\nIt is not just unnecessary, but \"export CDPATH\" anywhere in your\nrc scripts is actively *WRONG*.\n"}]}