{"thread":{"id":"42303","subject":"[PATCH] git-gui: Remove ancient Cygwin compatibility code","startedAt":"2016-05-13T11:11:22Z","lastAt":"2016-05-13T11:11:22Z","messageCount":1,"participants":["Adam Dinwoodie"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"286445","messageId":"20160513111122.GD2345@dinwoodie.org","threadId":"42303","inReplyTo":null,"subject":"[PATCH] git-gui: Remove ancient Cygwin compatibility code","fromName":"Adam Dinwoodie","fromEmail":"adam@dinwoodie.org","sentAt":"2016-05-13T11:11:22Z","receivedAt":"2016-05-13T11:11:22Z","isPatch":true,"sender":{"key":"adam@dinwoodie.org","avatar":"https://avatars.githubusercontent.com/u/1397507?v=4"},"body":">From 50c9cbb6ce31529316ba004194f63a24ae59b4b0 Mon Sep 17 00:00:00 2001\nFrom: Adam Dinwoodie <adam@dinwoodie.org>\nDate: Fri, 13 May 2016 11:52:32 +0100\nSubject: [PATCH] git-gui: Remove unused Cygwin compatibility code\n\nCygwin-distributed builds of git-gui have patched out the\nCygwin-specific compatibility code in the Makefile before compiling\nsince at least the start of 2012 (specifically since at least Git\nv1.7.9).  The compatibility code is clearly not necessary, so remove it\nfrom the official git-gui code as well.\n\nSigned-off-by: Adam Dinwoodie <adam@dinwoodie.org>\n---\n\nI originally submitted this patch back in December, but it didn't\ngenerate any more discussion than Junio saying \"this looks like a good\nthing to have.\"  I'm resubmitting to try to generate further discussion\n/ agreement to include the patch.\n\nAn equivalent patch has been included in the downstream Cygwin releases\nsince v1.7.9, and therefore is clearly stable and not causing any\nnotable problems.\n\nI've based this patch off the git-gui tree rather than the main Git tree\nper the SubmittingPatches doc.  Pipe it through `sed\n's!Makekfile!git-gui/\\0!g'` for a version that applies cleanly to the\nmain Git source tree.\n\n Makefile | 22 ++++------------------\n 1 file changed, 4 insertions(+), 18 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex fe30be3..a0adf3d 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -136,25 +136,11 @@\n GITGUI_RELATIVE :=\n GITGUI_MACOSXAPP :=\n \n-ifeq ($(uname_O),Cygwin)\n-\tGITGUI_SCRIPT := `cygpath --windows --absolute \"$(GITGUI_SCRIPT)\"`\n-\n-\t# Is this a Cygwin Tcl/Tk binary?  If so it knows how to do\n-\t# POSIX path translation just like cygpath does and we must\n-\t# keep libdir in POSIX format so Cygwin packages of git-gui\n-\t# work no matter where the user installs them.\n-\t#\n-\tifeq ($(shell echo 'puts [file normalize /]' | '$(TCL_PATH_SQ)'),$(shell cygpath --mixed --absolute /))\n-\t\tgg_libdir_sed_in := $(gg_libdir)\n-\telse\n-\t\tgg_libdir_sed_in := $(shell cygpath --windows --absolute \"$(gg_libdir)\")\n-\tendif\n-else\n-\tifeq ($(exedir),$(gg_libdir))\n-\t\tGITGUI_RELATIVE := 1\n-\tendif\n-\tgg_libdir_sed_in := $(gg_libdir)\n-endif\n+ifeq ($(exedir),$(gg_libdir))\n+\tGITGUI_RELATIVE := 1\n+endif\n+gg_libdir_sed_in := $(gg_libdir)\n+\n ifeq ($(uname_S),Darwin)\n \tifeq ($(shell test -d $(TKFRAMEWORK) && echo y),y)\n \t\tGITGUI_MACOSXAPP := YesPlease\n-- \n2.8.2.692.g8d9a515\n"}]}