{"thread":{"id":"42226","subject":"[PATCH] git-gui: Do not reset author details on amend","startedAt":"2016-05-05T14:23:02Z","lastAt":"2016-09-27T17:46:05Z","messageCount":10,"participants":["Orgad Shaneh","Junio C Hamano","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"285570","messageId":"1462458182-4488-1-git-send-email-orgads@gmail.com","threadId":"42226","inReplyTo":null,"subject":"[PATCH] git-gui: Do not reset author details on amend","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-05-05T14:23:02Z","receivedAt":"2016-05-05T14:23:02Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"git commit --amend preserves the author details unless --reset-author is\ngiven.\n\ngit-gui discards the author details on amend.\n\nFix by reading the author details along with the commit message, and\nsetting the appropriate environment variables required for preserving\nthem.\n\nReported long ago in the mailing list[1].\n\n[1] http://article.gmane.org/gmane.comp.version-control.git/243921\n\nSigned-off-by: Orgad Shaneh \n---\n git-gui/lib/commit.tcl | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)\n\ndiff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\nindex 864b687..60edf99 100644\n--- a/git-gui/lib/commit.tcl\n+++ b/git-gui/lib/commit.tcl\n@@ -1,8 +1,13 @@\n # git-gui misc. commit reading/writing support\n # Copyright (C) 2006, 2007 Shawn Pearce\n \n+set author_name \"\"\n+set author_email \"\"\n+set author_date \"\"\n+\n proc load_last_commit {} {\n \tglobal HEAD PARENT MERGE_HEAD commit_type ui_comm\n+\tglobal author_name author_email author_date\n \tglobal repo_config\n \n \tif {[llength $PARENT] == 0} {\n@@ -34,6 +39,10 @@ You are currently in the middle of a merge that has not been fully completed. Y\n \t\t\t\t\tlappend parents [string range $line 7 end]\n \t\t\t\t} elseif {[string match {encoding *} $line]} {\n \t\t\t\t\tset enc [string tolower [string range $line 9 end]]\n+\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n+\t\t\t\t\tset author_name $name\n+\t\t\t\t\tset author_email $email\n+\t\t\t\t\tset author_date $time\n \t\t\t\t}\n \t\t\t}\n \t\t\tset msg [read $fd]\n@@ -107,8 +116,12 @@ proc do_signoff {} {\n \n proc create_new_commit {} {\n \tglobal commit_type ui_comm\n+\tglobal author_name author_email author_date\n \n \tset commit_type normal\n+\tset author_name \"\"\n+\tset author_email \"\"\n+\tset author_date \"\"\n \t$ui_comm delete 0.0 end\n \t$ui_comm edit reset\n \t$ui_comm edit modified false\n@@ -327,6 +340,7 @@ proc commit_committree {fd_wt curHEAD msg_p} {\n \tglobal ui_comm selected_commit_type\n \tglobal file_states selected_paths rescan_active\n \tglobal repo_config\n+\tglobal env author_name author_email author_date\n \n \tgets $fd_wt tree_id\n \tif {[catch {close $fd_wt} err]} {\n@@ -366,6 +380,11 @@ A rescan will be automatically started now.\n \t\t}\n \t}\n \n+\tif {$author_name ne \"\"} {\n+\t\tset env(GIT_AUTHOR_NAME) $author_name\n+\t\tset env(GIT_AUTHOR_EMAIL) $author_email\n+\t\tset env(GIT_AUTHOR_DATE) $author_date\n+\t}\n \t# -- Create the commit.\n \t#\n \tset cmd [list commit-tree $tree_id]\n-- \n2.8.1\n"},{"id":"285577","messageId":"xmqqwpn8bes0.fsf@gitster.mtv.corp.google.com","threadId":"42226","inReplyTo":"1462458182-4488-1-git-send-email-orgads@gmail.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-05T17:22:55Z","receivedAt":"2016-05-05T17:22:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pat, we haven't heard from you for a long time. Are you still\naround and interested in helping us by maintaining git-gui?\n\nOtherwise we may have to start recruiting a volunteer or two to take\nthis over.\n\nThanks.\n\nOrgad Shaneh writes:\n\n> git commit --amend preserves the author details unless --reset-author is\n> given.\n>\n> git-gui discards the author details on amend.\n>\n> Fix by reading the author details along with the commit message, and\n> setting the appropriate environment variables required for preserving\n> them.\n>\n> Reported long ago in the mailing list[1].\n>\n> [1] http://article.gmane.org/gmane.comp.version-control.git/243921\n>\n> Signed-off-by: Orgad Shaneh \n> ---\n> git-gui/lib/commit.tcl | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n>\n> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\n> index 864b687..60edf99 100644\n> --- a/git-gui/lib/commit.tcl\n> +++ b/git-gui/lib/commit.tcl\n> @@ -1,8 +1,13 @@\n> # git-gui misc. commit reading/writing support\n> # Copyright (C) 2006, 2007 Shawn Pearce\n> \n> +set author_name \"\"\n> +set author_email \"\"\n> +set author_date \"\"\n> +\n> proc load_last_commit {} {\n> \tglobal HEAD PARENT MERGE_HEAD commit_type ui_comm\n> +\tglobal author_name author_email author_date\n> \tglobal repo_config\n> \n> \tif {[llength $PARENT] == 0} {\n> @@ -34,6 +39,10 @@ You are currently in the middle of a merge that has not been fully completed. Y\n> \t\t\t\t\tlappend parents [string range $line 7 end]\n> \t\t\t\t} elseif {[string match {encoding *} $line]} {\n> \t\t\t\t\tset enc [string tolower [string range $line 9 end]]\n> +\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n> +\t\t\t\t\tset author_name $name\n> +\t\t\t\t\tset author_email $email\n> +\t\t\t\t\tset author_date $time\n> \t\t\t\t}\n> \t\t\t}\n> \t\t\tset msg [read $fd]\n> @@ -107,8 +116,12 @@ proc do_signoff {} {\n> \n> proc create_new_commit {} {\n> \tglobal commit_type ui_comm\n> +\tglobal author_name author_email author_date\n> \n> \tset commit_type normal\n> +\tset author_name \"\"\n> +\tset author_email \"\"\n> +\tset author_date \"\"\n> \t$ui_comm delete 0.0 end\n> \t$ui_comm edit reset\n> \t$ui_comm edit modified false\n> @@ -327,6 +340,7 @@ proc commit_committree {fd_wt curHEAD msg_p} {\n> \tglobal ui_comm selected_commit_type\n> \tglobal file_states selected_paths rescan_active\n> \tglobal repo_config\n> +\tglobal env author_name author_email author_date\n> \n> \tgets $fd_wt tree_id\n> \tif {[catch {close $fd_wt} err]} {\n> @@ -366,6 +380,11 @@ A rescan will be automatically started now.\n> \t\t}\n> \t}\n> \n> +\tif {$author_name ne \"\"} {\n> +\t\tset env(GIT_AUTHOR_NAME) $author_name\n> +\t\tset env(GIT_AUTHOR_EMAIL) $author_email\n> +\t\tset env(GIT_AUTHOR_DATE) $author_date\n> +\t}\n> \t# -- Create the commit.\n> \t#\n> \tset cmd [list commit-tree $tree_id]\n"},{"id":"286857","messageId":"CAGHpTBLdy9R7xvfcFWoMkvGNJjY-wM5=HfWxs8XF_yh-+2Rc3w@mail.gmail.com","threadId":"42226","inReplyTo":"xmqqwpn8bes0.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-05-18T06:12:04Z","receivedAt":"2016-05-18T06:12:04Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"ping?\n\nOn Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote:\n> Pat, we haven't heard from you for a long time. Are you still\n> around and interested in helping us by maintaining git-gui?\n>\n> Otherwise we may have to start recruiting a volunteer or two to take\n> this over.\n>\n> Thanks.\n>\n> Orgad Shaneh writes:\n>\n>> git commit --amend preserves the author details unless --reset-author is\n>> given.\n>>\n>> git-gui discards the author details on amend.\n>>\n>> Fix by reading the author details along with the commit message, and\n>> setting the appropriate environment variables required for preserving\n>> them.\n>>\n>> Reported long ago in the mailing list[1].\n>>\n>> [1] http://article.gmane.org/gmane.comp.version-control.git/243921\n>>\n>> Signed-off-by: Orgad Shaneh \n>> ---\n>> git-gui/lib/commit.tcl | 19 +++++++++++++++++++\n>> 1 file changed, 19 insertions(+)\n>>\n>> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\n>> index 864b687..60edf99 100644\n>> --- a/git-gui/lib/commit.tcl\n>> +++ b/git-gui/lib/commit.tcl\n>> @@ -1,8 +1,13 @@\n>> # git-gui misc. commit reading/writing support\n>> # Copyright (C) 2006, 2007 Shawn Pearce\n>>\n>> +set author_name \"\"\n>> +set author_email \"\"\n>> +set author_date \"\"\n>> +\n>> proc load_last_commit {} {\n>> global HEAD PARENT MERGE_HEAD commit_type ui_comm\n>> + global author_name author_email author_date\n>> global repo_config\n>>\n>> if {[llength $PARENT] == 0} {\n>> @@ -34,6 +39,10 @@ You are currently in the middle of a merge that has not been fully completed. Y\n>> lappend parents [string range $line 7 end]\n>> } elseif {[string match {encoding *} $line]} {\n>> set enc [string tolower [string range $line 9 end]]\n>> + } elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n>> + set author_name $name\n>> + set author_email $email\n>> + set author_date $time\n>> }\n>> }\n>> set msg [read $fd]\n>> @@ -107,8 +116,12 @@ proc do_signoff {} {\n>>\n>> proc create_new_commit {} {\n>> global commit_type ui_comm\n>> + global author_name author_email author_date\n>>\n>> set commit_type normal\n>> + set author_name \"\"\n>> + set author_email \"\"\n>> + set author_date \"\"\n>> $ui_comm delete 0.0 end\n>> $ui_comm edit reset\n>> $ui_comm edit modified false\n>> @@ -327,6 +340,7 @@ proc commit_committree {fd_wt curHEAD msg_p} {\n>> global ui_comm selected_commit_type\n>> global file_states selected_paths rescan_active\n>> global repo_config\n>> + global env author_name author_email author_date\n>>\n>> gets $fd_wt tree_id\n>> if {[catch {close $fd_wt} err]} {\n>> @@ -366,6 +380,11 @@ A rescan will be automatically started now.\n>> }\n>> }\n>>\n>> + if {$author_name ne \"\"} {\n>> + set env(GIT_AUTHOR_NAME) $author_name\n>> + set env(GIT_AUTHOR_EMAIL) $author_email\n>> + set env(GIT_AUTHOR_DATE) $author_date\n>> + }\n>> # -- Create the commit.\n>> #\n>> set cmd [list commit-tree $tree_id]\n"},{"id":"291118","messageId":"CAGHpTBLgwyw_iYK927Yed+XG9ti+tKboz07-FVYWox9WoQkjOg@mail.gmail.com","threadId":"42226","inReplyTo":"CAGHpTBLdy9R7xvfcFWoMkvGNJjY-wM5=HfWxs8XF_yh-+2Rc3w@mail.gmail.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-07-10T04:36:08Z","receivedAt":"2016-07-10T04:36:17Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"It's been over 2 months. Can anyone please review and merge it?\n\nThanks.\n- Orgad\n\nOn Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:\n> ping?\n>\n> On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote:\n>> Pat, we haven't heard from you for a long time. Are you still\n>> around and interested in helping us by maintaining git-gui?\n>>\n>> Otherwise we may have to start recruiting a volunteer or two to take\n>> this over.\n>>\n>> Thanks.\n>>\n>> Orgad Shaneh writes:\n>>\n>>> git commit --amend preserves the author details unless --reset-author is\n>>> given.\n>>>\n>>> git-gui discards the author details on amend.\n>>>\n>>> Fix by reading the author details along with the commit message, and\n>>> setting the appropriate environment variables required for preserving\n>>> them.\n>>>\n>>> Reported long ago in the mailing list[1].\n>>>\n>>> [1] http://article.gmane.org/gmane.comp.version-control.git/243921\n>>>\n>>> Signed-off-by: Orgad Shaneh \n>>> ---\n>>> git-gui/lib/commit.tcl | 19 +++++++++++++++++++\n>>> 1 file changed, 19 insertions(+)\n>>>\n>>> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\n>>> index 864b687..60edf99 100644\n>>> --- a/git-gui/lib/commit.tcl\n>>> +++ b/git-gui/lib/commit.tcl\n>>> @@ -1,8 +1,13 @@\n>>> # git-gui misc. commit reading/writing support\n>>> # Copyright (C) 2006, 2007 Shawn Pearce\n>>>\n>>> +set author_name \"\"\n>>> +set author_email \"\"\n>>> +set author_date \"\"\n>>> +\n>>> proc load_last_commit {} {\n>>> global HEAD PARENT MERGE_HEAD commit_type ui_comm\n>>> + global author_name author_email author_date\n>>> global repo_config\n>>>\n>>> if {[llength $PARENT] == 0} {\n>>> @@ -34,6 +39,10 @@ You are currently in the middle of a merge that has not been fully completed. Y\n>>> lappend parents [string range $line 7 end]\n>>> } elseif {[string match {encoding *} $line]} {\n>>> set enc [string tolower [string range $line 9 end]]\n>>> + } elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n>>> + set author_name $name\n>>> + set author_email $email\n>>> + set author_date $time\n>>> }\n>>> }\n>>> set msg [read $fd]\n>>> @@ -107,8 +116,12 @@ proc do_signoff {} {\n>>>\n>>> proc create_new_commit {} {\n>>> global commit_type ui_comm\n>>> + global author_name author_email author_date\n>>>\n>>> set commit_type normal\n>>> + set author_name \"\"\n>>> + set author_email \"\"\n>>> + set author_date \"\"\n>>> $ui_comm delete 0.0 end\n>>> $ui_comm edit reset\n>>> $ui_comm edit modified false\n>>> @@ -327,6 +340,7 @@ proc commit_committree {fd_wt curHEAD msg_p} {\n>>> global ui_comm selected_commit_type\n>>> global file_states selected_paths rescan_active\n>>> global repo_config\n>>> + global env author_name author_email author_date\n>>>\n>>> gets $fd_wt tree_id\n>>> if {[catch {close $fd_wt} err]} {\n>>> @@ -366,6 +380,11 @@ A rescan will be automatically started now.\n>>> }\n>>> }\n>>>\n>>> + if {$author_name ne \"\"} {\n>>> + set env(GIT_AUTHOR_NAME) $author_name\n>>> + set env(GIT_AUTHOR_EMAIL) $author_email\n>>> + set env(GIT_AUTHOR_DATE) $author_date\n>>> + }\n>>> # -- Create the commit.\n>>> #\n>>> set cmd [list commit-tree $tree_id]\n"},{"id":"302628","messageId":"CAGHpTB+Fnu4x1bV9TSNo8pYdOzJzRsXA9r3CwxVz64mjW_qsGw@mail.gmail.com","threadId":"42226","inReplyTo":"CAGHpTBLgwyw_iYK927Yed+XG9ti+tKboz07-FVYWox9WoQkjOg@mail.gmail.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-09-26T20:06:53Z","receivedAt":"2016-09-26T20:07:03Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"4.5 months and counting... :(\n\n- Orgad\n\nOn Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote:\n> It's been over 2 months. Can anyone please review and merge it?\n>\n> Thanks.\n> - Orgad\n>\n> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:\n>> ping?\n>>\n>> On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote:\n>>> Pat, we haven't heard from you for a long time. Are you still\n>>> around and interested in helping us by maintaining git-gui?\n>>>\n>>> Otherwise we may have to start recruiting a volunteer or two to take\n>>> this over.\n>>>\n>>> Thanks.\n>>>\n>>> Orgad Shaneh writes:\n>>>\n>>>> git commit --amend preserves the author details unless --reset-author is\n>>>> given.\n>>>>\n>>>> git-gui discards the author details on amend.\n>>>>\n>>>> Fix by reading the author details along with the commit message, and\n>>>> setting the appropriate environment variables required for preserving\n>>>> them.\n>>>>\n>>>> Reported long ago in the mailing list[1].\n>>>>\n>>>> [1] http://article.gmane.org/gmane.comp.version-control.git/243921\n>>>>\n>>>> Signed-off-by: Orgad Shaneh \n>>>> ---\n>>>> git-gui/lib/commit.tcl | 19 +++++++++++++++++++\n>>>> 1 file changed, 19 insertions(+)\n>>>>\n>>>> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\n>>>> index 864b687..60edf99 100644\n>>>> --- a/git-gui/lib/commit.tcl\n>>>> +++ b/git-gui/lib/commit.tcl\n>>>> @@ -1,8 +1,13 @@\n>>>> # git-gui misc. commit reading/writing support\n>>>> # Copyright (C) 2006, 2007 Shawn Pearce\n>>>>\n>>>> +set author_name \"\"\n>>>> +set author_email \"\"\n>>>> +set author_date \"\"\n>>>> +\n>>>> proc load_last_commit {} {\n>>>> global HEAD PARENT MERGE_HEAD commit_type ui_comm\n>>>> + global author_name author_email author_date\n>>>> global repo_config\n>>>>\n>>>> if {[llength $PARENT] == 0} {\n>>>> @@ -34,6 +39,10 @@ You are currently in the middle of a merge that has not been fully completed. Y\n>>>> lappend parents [string range $line 7 end]\n>>>> } elseif {[string match {encoding *} $line]} {\n>>>> set enc [string tolower [string range $line 9 end]]\n>>>> + } elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n>>>> + set author_name $name\n>>>> + set author_email $email\n>>>> + set author_date $time\n>>>> }\n>>>> }\n>>>> set msg [read $fd]\n>>>> @@ -107,8 +116,12 @@ proc do_signoff {} {\n>>>>\n>>>> proc create_new_commit {} {\n>>>> global commit_type ui_comm\n>>>> + global author_name author_email author_date\n>>>>\n>>>> set commit_type normal\n>>>> + set author_name \"\"\n>>>> + set author_email \"\"\n>>>> + set author_date \"\"\n>>>> $ui_comm delete 0.0 end\n>>>> $ui_comm edit reset\n>>>> $ui_comm edit modified false\n>>>> @@ -327,6 +340,7 @@ proc commit_committree {fd_wt curHEAD msg_p} {\n>>>> global ui_comm selected_commit_type\n>>>> global file_states selected_paths rescan_active\n>>>> global repo_config\n>>>> + global env author_name author_email author_date\n>>>>\n>>>> gets $fd_wt tree_id\n>>>> if {[catch {close $fd_wt} err]} {\n>>>> @@ -366,6 +380,11 @@ A rescan will be automatically started now.\n>>>> }\n>>>> }\n>>>>\n>>>> + if {$author_name ne \"\"} {\n>>>> + set env(GIT_AUTHOR_NAME) $author_name\n>>>> + set env(GIT_AUTHOR_EMAIL) $author_email\n>>>> + set env(GIT_AUTHOR_DATE) $author_date\n>>>> + }\n>>>> # -- Create the commit.\n>>>> #\n>>>> set cmd [list commit-tree $tree_id]\n"},{"id":"302641","messageId":"xmqqmviupcpx.fsf@gitster.mtv.corp.google.com","threadId":"42226","inReplyTo":"CAGHpTB+Fnu4x1bV9TSNo8pYdOzJzRsXA9r3CwxVz64mjW_qsGw@mail.gmail.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-26T21:34:18Z","receivedAt":"2016-09-26T21:34:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Orgad Shaneh writes:\n\n> On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote:\n>\n>> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:\n>>> ping?\n>>>\n>> It's been over 2 months. Can anyone please review and merge it?\n>>\n> 4.5 months and counting... :(\n>>\n>>> On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote:\n>>>> Pat, we haven't heard from you for a long time. Are you still\n>>>> around and interested in helping us by maintaining git-gui?\n>>>>\n>>>> Otherwise we may have to start recruiting a volunteer or two to take\n>>>> this over.\n\nSorry about that. No volunteers materialized yet X-<, and I really\nreally do not want to apply anything other than trivial patches to\nit myself, as I am not a git-gui user.\n\n"},{"id":"302684","messageId":"CAGHpTBLPvQDD4hhMKiOFdhxug-joi-38mNozuzm3=EJCnS9UEA@mail.gmail.com","threadId":"42226","inReplyTo":"xmqqmviupcpx.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-09-27T07:22:19Z","receivedAt":"2016-09-27T07:22:25Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote:\n> Orgad Shaneh writes:\n>\n>> On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote:\n>>\n>>> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:\n>>>> ping?\n>>>>\n>>> It's been over 2 months. Can anyone please review and merge it?\n>>>\n>> 4.5 months and counting... :(\n>>>\n>>>> On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote:\n>>>>> Pat, we haven't heard from you for a long time. Are you still\n>>>>> around and interested in helping us by maintaining git-gui?\n>>>>>\n>>>>> Otherwise we may have to start recruiting a volunteer or two to take\n>>>>> this over.\n>\n> Sorry about that. No volunteers materialized yet X-<, and I really\n> really do not want to apply anything other than trivial patches to\n> it myself, as I am not a git-gui user.\n>\n\nThis patch has been in use in Git for Windows for a decent period of time.\n\nI actually see that there is a problem with it:\nhttps://github.com/git-for-windows/git/issues/761\n\nI'll try to revise it and resubmit.\n\n- Orgad\n"},{"id":"302716","messageId":"xmqqd1jpqp7p.fsf@gitster.mtv.corp.google.com","threadId":"42226","inReplyTo":"CAGHpTBLPvQDD4hhMKiOFdhxug-joi-38mNozuzm3=EJCnS9UEA@mail.gmail.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-27T16:31:22Z","receivedAt":"2016-09-27T16:31:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Orgad Shaneh writes:\n\n> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote:\n>> Orgad Shaneh writes:\n>>\n> I actually see that there is a problem with it:\n> https://github.com/git-for-windows/git/issues/761\n>\n> I'll try to revise it and resubmit.\n\nAre you by chance volunteering to be git-gui maintainer?\n"},{"id":"302722","messageId":"CAGHpTB+XOxMh=o_dKGx-j2P15zsmcMn0MB7BuKFksOn4O_FXYw@mail.gmail.com","threadId":"42226","inReplyTo":"xmqqd1jpqp7p.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-09-27T17:23:18Z","receivedAt":"2016-09-27T17:23:25Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano wrote:\n> Orgad Shaneh writes:\n>\n>> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote:\n>>> Orgad Shaneh writes:\n>>>\n>> I actually see that there is a problem with it:\n>> https://github.com/git-for-windows/git/issues/761\n>>\n>> I'll try to revise it and resubmit.\n>\n> Are you by chance volunteering to be git-gui maintainer?\n\nNo way, sorry. I don't speak TCL at all. Every change is a true pain... ;)\n\n- Orgad\n"},{"id":"302727","messageId":"CAGZ79kYYUNf7AvpQu=NzrujM6pCdBK_JunZhC-CxPkfRcNDL6g@mail.gmail.com","threadId":"42226","inReplyTo":"CAGHpTB+XOxMh=o_dKGx-j2P15zsmcMn0MB7BuKFksOn4O_FXYw@mail.gmail.com","subject":"Re: [PATCH] git-gui: Do not reset author details on amend","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-09-27T17:45:59Z","receivedAt":"2016-09-27T17:46:05Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Sep 27, 2016 at 10:23 AM, Orgad Shaneh wrote:\n> On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano wrote:\n>> Orgad Shaneh writes:\n>>\n>>> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote:\n>>>> Orgad Shaneh writes:\n>>>>\n>>> I actually see that there is a problem with it:\n>>> https://github.com/git-for-windows/git/issues/761\n>>>\n>>> I'll try to revise it and resubmit.\n>>\n>> Are you by chance volunteering to be git-gui maintainer?\n>\n> No way, sorry. I don't speak TCL at all. Every change is a true pain... ;)\n\nI considered stepping up as an interim maintainer briefly, but this is\nthe exact reason\non why I punted.\n\nLooking at e.g. `git diff --stat gitgui-0.19.0..gitgui-0.20.0` (which\nis 16 month apart),\nthe workload seems to be very light, so I would not have concerns\nw.r.t. time spent.\n\nStepping back a bit and asking \"What does a maintainer do?\" I think knowing the\nlanguage very well is not the top point, but rather looking at the design,\nmaintainability of proposed solutions as well as long term well being\nof the project\nis what makes a good maintainer.\n\nThat said I could step up as a maintainer, but for each patch I\"d ask\nthe contributor to\nfind a reviewer who knows tcl well, as that is a part that I cannot\ncover. And from a\ncontributors perspective this seems to be discouraging.\n\nStefan\n\n>\n> - Orgad\n"}]}