{"thread":{"id":"42211","subject":"t7900-*.sh tesr #5 failure","startedAt":"2016-05-03T21:34:58Z","lastAt":"2016-05-05T21:34:18Z","messageCount":2,"participants":["Ramsay Jones","David Turner"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"285383","messageId":"57291982.2000904@ramsayjones.plus.com","threadId":"42211","inReplyTo":null,"subject":"t7900-*.sh tesr #5 failure","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-05-03T21:34:58Z","receivedAt":"2016-05-03T21:34:58Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi David,\n\nTest t7900.5 fails for me, thus:\n\n  $ ./t7900-index-helper.sh -i -v -x -d\n  \n  ...\n  \n  + test -S .git/index-helper.sock\n  + git status\n  On branch master\n  Untracked files:\n    (use \"git add <file>...\" to include in what will be committed)\n  \n  \terr\n  \n  nothing added to commit but untracked files present (use \"git add\" to track)\n  + test -S .git/index-helper.sock\n  + grep -q . err\n  error: last command exited with $?=1\n  not ok 5 - index-helper autorun works\n  #\t\n  #\t\trm -f .git/index-helper.sock &&\n  #\t\tgit status &&\n  #\t\ttest_path_is_missing .git/index-helper.sock &&\n  #\t\ttest_config indexhelper.autorun true &&\n  #\t\tgit status &&\n  #\t\ttest -S .git/index-helper.sock &&\n  #\t\tgit status 2>err &&\n  #\t\ttest -S .git/index-helper.sock &&\n  #\t\t! grep -q . err &&\n  #\t\tgit index-helper --kill &&\n  #\t\ttest_config indexhelper.autorun false &&\n  #\t\tgit status &&\n  #\t\ttest_path_is_missing .git/index-helper.sock\n  #\t\n  $ cd trash\\ directory.t7900-index-helper/\n  $ ls\n  err  x.t\n  $ cat err\n  warning: We requested watchman support from index-helper, but it doesn't support it. Please use a version of git index-helper with watchman support.\n  $ \n\n[Yes, that is one long line in err!]\n\n[At least, this is one of the failures, I have also seen git status failing\nwith a SIGPIPE.]\n\nNote that I do not have the watchman libraries etc., so USE_WATCHMAN is\nnot defined. Note also, that I had an instance of git-index-helper still\nrunning after the test failure (which I kill-ed).\n\nI haven't spent any time debuging this, but some questions spring to\nmind:\n\n    - can index-helper be used without watchman support?\n\n    - why is index-helper requesting watchman support, when it was\n      built without USE_WATCHMAN being defined?\n\n    - why is read-cache.o exporting the verify_index and\n      write_watchman_ext symbols?\n\n    - is index-helper any use/help without watchman support?\n\n    - is '! grep -q . err' meant to determine if the err file is\n      empty (ie git status did not issue an error message)?\n      [if yes, maybe 'test_must_be_empty err &&' would read better!]\n\nUnfortunately, I have to run now, ...\n\nATB,\nRamsay Jones\n"},{"id":"285605","messageId":"1462484058.24478.10.camel@twopensource.com","threadId":"42211","inReplyTo":"57291982.2000904@ramsayjones.plus.com","subject":"Re: t7900-*.sh tesr #5 failure","fromName":"David Turner","fromEmail":"dturner@twopensource.com","sentAt":"2016-05-05T21:34:18Z","receivedAt":"2016-05-05T21:34:18Z","isPatch":false,"sender":{"key":"novalis@novalis.org","avatar":"https://avatars.githubusercontent.com/u/77003?v=4"},"body":"On Tue, 2016-05-03 at 22:34 +0100, Ramsay Jones wrote:\n> Hi David,\n> \n> Test t7900.5 fails for me, thus:\n> \n>   $ ./t7900-index-helper.sh -i -v -x -d\n>   \n>   ...\n>   \n>   + test -S .git/index-helper.sock\n>   + git status\n>   On branch master\n>   Untracked files:\n>     (use \"git add <file>...\" to include in what will be committed)\n>   \n>   \terr\n>   \n>   nothing added to commit but untracked files present (use \"git add\"\n> to track)\n>   + test -S .git/index-helper.sock\n>   + grep -q . err\n>   error: last command exited with $?=1\n>   not ok 5 - index-helper autorun works\n>   #\t\n>   #\t\trm -f .git/index-helper.sock &&\n>   #\t\tgit status &&\n>   #\t\ttest_path_is_missing .git/index-helper.sock &&\n>   #\t\ttest_config indexhelper.autorun true &&\n>   #\t\tgit status &&\n>   #\t\ttest -S .git/index-helper.sock &&\n>   #\t\tgit status 2>err &&\n>   #\t\ttest -S .git/index-helper.sock &&\n>   #\t\t! grep -q . err &&\n>   #\t\tgit index-helper --kill &&\n>   #\t\ttest_config indexhelper.autorun false &&\n>   #\t\tgit status &&\n>   #\t\ttest_path_is_missing .git/index-helper.sock\n>   #\t\n>   $ cd trash\\ directory.t7900-index-helper/\n>   $ ls\n>   err  x.t\n>   $ cat err\n>   warning: We requested watchman support from index-helper, but it\n> doesn't support it. Please use a version of git index-helper with\n> watchman support.\n>   $ \n> \n> [Yes, that is one long line in err!]\n\nOK, the failure here is due to a bad check in the code -- it's intended\nthat index-helper work without watchman.  Will re-roll with a fix.\n\n> [At least, this is one of the failures, I have also seen git status\n> failing\n> with a SIGPIPE.]\n\nI'll add in a sig_ign on that.\n\n> Note that I do not have the watchman libraries etc., so USE_WATCHMAN\n> is\n> not defined. Note also, that I had an instance of git-index-helper\n> still\n> running after the test failure (which I kill-ed).\n\nI missed a test_when_finished (note that in the case of test failures\nin debug mode, test_when_finished statements are not executed on\nfailing tests, so you would still see an index-helper in that case;\nsince test failures are not expected, that shouldn't be a problem).\n\nWill fix, thanks.\n\n> I haven't spent any time debuging this, but some questions spring to\n> mind:\n> \n>     - can index-helper be used without watchman support?\n\nYes (once I re-roll with the bug fix).\n\n>     - why is index-helper requesting watchman support, when it was\n>       built without USE_WATCHMAN being defined?\n\nIt's not; the code that checks for that request is mistakenly detecting\nthat it is.\n\n>     - why is read-cache.o exporting hte verify_index and\n>       write_watchman_ext symbols?\n\nverify_index should be used in index-helper but that somehow got lost\nin v3.  Will fix on reroll.\nwrite_watchman_ext is exported because index-helper currently uses it.\n\n>     - is index-helper any use/help without watchman support?\n\nYes for large indexes -- see the measurements in patch v3 (which is\nearlier in the series than watchman is introduced).\n\n>     - is '! grep -q . err' meant to determine if the err file is\n>       empty (ie git status did not issue an error message)?\n>       [if yes, maybe 'test_must_be_empty err &&' would read better!]\n\nWill fix, thanks.\n"}]}