{"thread":{"id":"42179","subject":"[PATCH] t9824: fix wrong reference value","startedAt":"2016-04-29T15:57:02Z","lastAt":"2016-04-29T20:40:05Z","messageCount":4,"participants":["Lars Schneider","Junio C Hamano","Luke Diamand"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"284943","messageId":"0102015462bcd1c3-4196e36b-515b-447f-beca-649922456098-000000@eu-west-1.amazonses.com","threadId":"42179","inReplyTo":null,"subject":"[PATCH] t9824: fix wrong reference value","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-04-29T15:57:02Z","receivedAt":"2016-04-29T15:57:02Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"0492eb4 fixed a broken &&-chain in this test which broke the test as it\nchecked for a wrong size. The expected size of the file under test is\n39 bytes. The test checked that the size is 13 bytes. Fix the reference\nvalue to make the test pass, again.\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\n---\n t/t9824-git-p4-git-lfs.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh\nindex 64f8d18..3fc6790 100755\n--- a/t/t9824-git-p4-git-lfs.sh\n+++ b/t/t9824-git-p4-git-lfs.sh\n@@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr\n \t\t# We only import HEAD here (\"@all\" is missing!)\n \t\tgit p4 clone --destination=\"$git\" //depot &&\n \n-\t\ttest_file_in_lfs file6.bin 13 \"content 6 bin 39 bytes XXXXXYYYYYZZZZZ\" &&\n+\t\ttest_file_in_lfs file6.bin 39 \"content 6 bin 39 bytes XXXXXYYYYYZZZZZ\" &&\n \t\ttest_file_count_in_dir \".git/lfs/objects\" 1 &&\n \n \t\tcat >expect <<-\\EOF &&\n\n--\nhttps://github.com/git/git/pull/235\n"},{"id":"284954","messageId":"xmqqmvocz5d6.fsf@gitster.mtv.corp.google.com","threadId":"42179","inReplyTo":"0102015462bcd1c3-4196e36b-515b-447f-beca-649922456098-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] t9824: fix wrong reference value","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-29T17:34:13Z","receivedAt":"2016-04-29T17:34:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lars Schneider <larsxschneider@gmail.com> writes:\n\n> 0492eb4 fixed a broken &&-chain in this test which broke the test as it\n> checked for a wrong size. The expected size of the file under test is\n> 39 bytes. The test checked that the size is 13 bytes. Fix the reference\n> value to make the test pass, again.\n>\n> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>\n> ---\n\nThat breaking \"fix\" seems to have been acked by you.\n\nIt was sort of clear that SZEDER didn't actually ran the test from\nthe patch, saying \"As far as I can tell after eyeballing the test\nscript,\", but you obviously didn't actually have a chance to test it\nuntil now.\n\nThanks for fixing it before it hits 'master'; this time I think it\nis safe to assume that this was actually tested ;-)\n\n\n>  t/t9824-git-p4-git-lfs.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh\n> index 64f8d18..3fc6790 100755\n> --- a/t/t9824-git-p4-git-lfs.sh\n> +++ b/t/t9824-git-p4-git-lfs.sh\n> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr\n>  \t\t# We only import HEAD here (\"@all\" is missing!)\n>  \t\tgit p4 clone --destination=\"$git\" //depot &&\n>  \n> -\t\ttest_file_in_lfs file6.bin 13 \"content 6 bin 39 bytes XXXXXYYYYYZZZZZ\" &&\n> +\t\ttest_file_in_lfs file6.bin 39 \"content 6 bin 39 bytes XXXXXYYYYYZZZZZ\" &&\n>  \t\ttest_file_count_in_dir \".git/lfs/objects\" 1 &&\n>  \n>  \t\tcat >expect <<-\\EOF &&\n>\n> --\n> https://github.com/git/git/pull/235\n"},{"id":"284972","messageId":"ACC53CBE-D83A-49E9-9DC7-C99F485D3E55@gmail.com","threadId":"42179","inReplyTo":"xmqqmvocz5d6.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] t9824: fix wrong reference value","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-04-29T20:29:43Z","receivedAt":"2016-04-29T20:29:43Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\nOn 29 Apr 2016, at 19:34, Junio C Hamano <gitster@pobox.com> wrote:\n\n> Lars Schneider <larsxschneider@gmail.com> writes:\n> \n>> 0492eb4 fixed a broken &&-chain in this test which broke the test as it\n>> checked for a wrong size. The expected size of the file under test is\n>> 39 bytes. The test checked that the size is 13 bytes. Fix the reference\n>> value to make the test pass, again.\n>> \n>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>\n>> ---\n> \n> That breaking \"fix\" seems to have been acked by you.\n> \n> It was sort of clear that SZEDER didn't actually ran the test from\n> the patch, saying \"As far as I can tell after eyeballing the test\n> script,\", but you obviously didn't actually have a chance to test it\n> until now.\n> \n> Thanks for fixing it before it hits 'master'; this time I think it\n> is safe to assume that this was actually tested ;-)\n\nYes! Lesson learned! Sorry Szeder!\n\n- Lars\n\n\n> \n> \n>> t/t9824-git-p4-git-lfs.sh | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh\n>> index 64f8d18..3fc6790 100755\n>> --- a/t/t9824-git-p4-git-lfs.sh\n>> +++ b/t/t9824-git-p4-git-lfs.sh\n>> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr\n>> \t\t# We only import HEAD here (\"@all\" is missing!)\n>> \t\tgit p4 clone --destination=\"$git\" //depot &&\n>> \n>> -\t\ttest_file_in_lfs file6.bin 13 \"content 6 bin 39 bytes XXXXXYYYYYZZZZZ\" &&\n>> +\t\ttest_file_in_lfs file6.bin 39 \"content 6 bin 39 bytes XXXXXYYYYYZZZZZ\" &&\n>> \t\ttest_file_count_in_dir \".git/lfs/objects\" 1 &&\n>> \n>> \t\tcat >expect <<-\\EOF &&\n>> \n>> --\n>> https://github.com/git/git/pull/235\n"},{"id":"284973","messageId":"CAE5ih7-AZCoJp2tO2KWRO4A9mWhdsNb_QTew93CmFCRh9kmATw@mail.gmail.com","threadId":"42179","inReplyTo":"ACC53CBE-D83A-49E9-9DC7-C99F485D3E55@gmail.com","subject":"Re: [PATCH] t9824: fix wrong reference value","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2016-04-29T20:40:05Z","receivedAt":"2016-04-29T20:40:05Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"On 29 April 2016 at 21:29, Lars Schneider <larsxschneider@gmail.com> wrote:\n>\n> On 29 Apr 2016, at 19:34, Junio C Hamano <gitster@pobox.com> wrote:\n>\n>> Lars Schneider <larsxschneider@gmail.com> writes:\n>>\n>>> 0492eb4 fixed a broken &&-chain in this test which broke the test as it\n>>> checked for a wrong size. The expected size of the file under test is\n>>> 39 bytes. The test checked that the size is 13 bytes. Fix the reference\n>>> value to make the test pass, again.\n>>>\n>>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>\n>>> ---\n>>\n>> That breaking \"fix\" seems to have been acked by you.\n>>\n>> It was sort of clear that SZEDER didn't actually ran the test from\n>> the patch, saying \"As far as I can tell after eyeballing the test\n>> script,\", but you obviously didn't actually have a chance to test it\n>> until now.\n>>\n>> Thanks for fixing it before it hits 'master'; this time I think it\n>> is safe to assume that this was actually tested ;-)\n>\n> Yes! Lesson learned! Sorry Szeder!\n\nHow does the old saying go? If it hasn't been tested, it doesn't work!\n\nLuke\n"}]}