{"thread":{"id":"42174","subject":"[PATCH 1/2] Documentation: config: improve word ordering for http.cookieFile","startedAt":"2016-04-29T06:23:56Z","lastAt":"2016-04-29T17:56:51Z","messageCount":12,"participants":["Brian Norris","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"284891","messageId":"20160429062357.12647-1-computersforpeace@gmail.com","threadId":"42174","inReplyTo":null,"subject":"[PATCH 1/2] Documentation: config: improve word ordering for http.cookieFile","fromName":"Brian Norris","fromEmail":"computersforpeace@gmail.com","sentAt":"2016-04-29T06:23:56Z","receivedAt":"2016-04-29T06:23:56Z","isPatch":true,"sender":{"key":"computersforpeace@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2268082?v=4"},"body":"Signed-off-by: Brian Norris <computersforpeace@gmail.com>\n---\n Documentation/config.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 42d2b50477b2..a775ad885a76 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1660,7 +1660,7 @@ http.cookieFile::\n \tin the Git http session, if they match the server. The file format\n \tof the file to read cookies from should be plain HTTP headers or\n \tthe Netscape/Mozilla cookie file format (see linkgit:curl[1]).\n-\tNOTE that the file specified with http.cookieFile is only used as\n+\tNOTE that the file specified with http.cookieFile is used only as\n \tinput unless http.saveCookies is set.\n \n http.saveCookies::\n-- \n2.8.1.340.g018a5d0.dirty\n"},{"id":"284892","messageId":"20160429062357.12647-2-computersforpeace@gmail.com","threadId":"42174","inReplyTo":"20160429062357.12647-1-computersforpeace@gmail.com","subject":"[PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Brian Norris","fromEmail":"computersforpeace@gmail.com","sentAt":"2016-04-29T06:23:57Z","receivedAt":"2016-04-29T06:23:57Z","isPatch":true,"sender":{"key":"computersforpeace@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2268082?v=4"},"body":"This should handle .gitconfig files that specify things like:\n\n[http]\n\tcookieFile = \"~/.gitcookies\"\n\nSigned-off-by: Brian Norris <computersforpeace@gmail.com>\n---\n Documentation/config.txt | 3 +++\n http.c                   | 2 +-\n 2 files changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex a775ad885a76..d3ef2d3b5d13 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1660,6 +1660,9 @@ http.cookieFile::\n \tin the Git http session, if they match the server. The file format\n \tof the file to read cookies from should be plain HTTP headers or\n \tthe Netscape/Mozilla cookie file format (see linkgit:curl[1]).\n+\tThe value of `http.cookieFile` is subject to tilde expansion: `~/` is\n+\texpanded to the value of `$HOME`, and `~user/` to the specified user's\n+\thome directory.\n \tNOTE that the file specified with http.cookieFile is used only as\n \tinput unless http.saveCookies is set.\n \ndiff --git a/http.c b/http.c\nindex 4304b80ad3ac..1044f9ba0e28 100644\n--- a/http.c\n+++ b/http.c\n@@ -293,7 +293,7 @@ static int http_options(const char *var, const char *value, void *cb)\n \t\treturn git_config_string(&http_proxy_authmethod, var, value);\n \n \tif (!strcmp(\"http.cookiefile\", var))\n-\t\treturn git_config_string(&curl_cookie_file, var, value);\n+\t\treturn git_config_pathname(&curl_cookie_file, var, value);\n \tif (!strcmp(\"http.savecookies\", var)) {\n \t\tcurl_save_cookies = git_config_bool(var, value);\n \t\treturn 0;\n-- \n2.8.1.340.g018a5d0.dirty\n"},{"id":"284922","messageId":"20160429141212.GB26643@sigill.intra.peff.net","threadId":"42174","inReplyTo":"20160429062357.12647-2-computersforpeace@gmail.com","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-04-29T14:12:12Z","receivedAt":"2016-04-29T14:12:12Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Apr 29, 2016 at 12:23:57AM -0600, Brian Norris wrote:\n\n> This should handle .gitconfig files that specify things like:\n> \n> [http]\n> \tcookieFile = \"~/.gitcookies\"\n\nSeems like a good idea, and the implementation looks obviously correct.\n\nFor the documentation:\n\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index a775ad885a76..d3ef2d3b5d13 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -1660,6 +1660,9 @@ http.cookieFile::\n>  \tin the Git http session, if they match the server. The file format\n>  \tof the file to read cookies from should be plain HTTP headers or\n>  \tthe Netscape/Mozilla cookie file format (see linkgit:curl[1]).\n> +\tThe value of `http.cookieFile` is subject to tilde expansion: `~/` is\n> +\texpanded to the value of `$HOME`, and `~user/` to the specified user's\n> +\thome directory.\n>  \tNOTE that the file specified with http.cookieFile is used only as\n>  \tinput unless http.saveCookies is set.\n\nI'm not sure if it's a good idea to go into so much detail about\nexpand_user_path() here. There are a lot of options that use the same\nrules, and we probably don't want to go into a complete explanation\ninside each option's description. Is there a canonical definition of how\nwe do expansion in config.txt that we can just reference (and if not,\ncan we add one)?\n\n-Peff\n"},{"id":"284942","messageId":"20160429155532.GA57118@google.com","threadId":"42174","inReplyTo":"20160429141212.GB26643@sigill.intra.peff.net","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Brian Norris","fromEmail":"computersforpeace@gmail.com","sentAt":"2016-04-29T15:55:32Z","receivedAt":"2016-04-29T15:55:32Z","isPatch":true,"sender":{"key":"computersforpeace@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2268082?v=4"},"body":"On Fri, Apr 29, 2016 at 10:12:12AM -0400, Jeff King wrote:\n> On Fri, Apr 29, 2016 at 12:23:57AM -0600, Brian Norris wrote:\n> \n> > This should handle .gitconfig files that specify things like:\n> > \n> > [http]\n> > \tcookieFile = \"~/.gitcookies\"\n> \n> Seems like a good idea, and the implementation looks obviously correct.\n> \n> For the documentation:\n> \n> > diff --git a/Documentation/config.txt b/Documentation/config.txt\n> > index a775ad885a76..d3ef2d3b5d13 100644\n> > --- a/Documentation/config.txt\n> > +++ b/Documentation/config.txt\n> > @@ -1660,6 +1660,9 @@ http.cookieFile::\n> >  \tin the Git http session, if they match the server. The file format\n> >  \tof the file to read cookies from should be plain HTTP headers or\n> >  \tthe Netscape/Mozilla cookie file format (see linkgit:curl[1]).\n> > +\tThe value of `http.cookieFile` is subject to tilde expansion: `~/` is\n> > +\texpanded to the value of `$HOME`, and `~user/` to the specified user's\n> > +\thome directory.\n> >  \tNOTE that the file specified with http.cookieFile is used only as\n> >  \tinput unless http.saveCookies is set.\n> \n> I'm not sure if it's a good idea to go into so much detail about\n> expand_user_path() here. There are a lot of options that use the same\n> rules, and we probably don't want to go into a complete explanation\n> inside each option's description. Is there a canonical definition of how\n> we do expansion in config.txt that we can just reference (and if not,\n> can we add one)?\n\nI mostly just copied from boilerplate on another option. IIRC, there\nwere at least two other options that were documented similarly.\n\nI think it's very important to note this somehow in the documentation.\nFor months, I've just had to keep a delta among the (otherwise\nidentical, shared) .gitconfig on my various machines just to account for\nthe different home directories. I thought that the \"no-expansion\" thing\nwas an intentional policy, since there are various blogs/forums that\nmention the lack of this kind of expansion when you search for related\nproblems. But apparently this was a bug/oversight. So having clear\ndocumentation to state the reality is imperative, IMO.\n\nThe best kind of documentation might mention that all paths can be\nexpanded in this way, and then just include \"path\" language on the\nrelevant options. But then we'd have to do a quick audit to make sure\nthat every path-based option does indeed use this path-expansion helper.\n(As this patch proves, we haven't been very consistent so far.)\n\nIf you have a good overall recommendation for this, I can try to send a\nnew patch sometime next week.\n\nBrian\n"},{"id":"284949","messageId":"xmqqziscz6ej.fsf@gitster.mtv.corp.google.com","threadId":"42174","inReplyTo":"20160429141212.GB26643@sigill.intra.peff.net","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-29T17:11:48Z","receivedAt":"2016-04-29T17:11:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> I'm not sure if it's a good idea to go into so much detail about\n> expand_user_path() here. There are a lot of options that use the same\n> rules, and we probably don't want to go into a complete explanation\n> inside each option's description. Is there a canonical definition of how\n> we do expansion in config.txt that we can just reference (and if not,\n> can we add one)?\n\nWe have a dedicated section for various value-types used in the\nconfiguration variables already, because we needed to describe how\nbooleans and scaled integers can be spelled, and the pathname type\nwould fit there.\n\n Documentation/config.txt | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 59d7046..1bf42a6 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -169,6 +169,11 @@ thing on the same output line (e.g. opening parenthesis before the\n list of branch names in `log --decorate` output) is set to be\n painted with `bold` or some other attribute.\n \n+pathname::\n+\tA variable that takes a pathname value can be given a\n+\tstring that begins with \"~/\" or \"~user/\", and the usual\n+\ttilde expansion happens to such a string.\n+\n \n Variables\n ~~~~~~~~~\n"},{"id":"284951","messageId":"20160429171631.GA29571@sigill.intra.peff.net","threadId":"42174","inReplyTo":"xmqqziscz6ej.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-04-29T17:16:31Z","receivedAt":"2016-04-29T17:16:31Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Apr 29, 2016 at 10:11:48AM -0700, Junio C Hamano wrote:\n\n> Jeff King <peff@peff.net> writes:\n> \n> > I'm not sure if it's a good idea to go into so much detail about\n> > expand_user_path() here. There are a lot of options that use the same\n> > rules, and we probably don't want to go into a complete explanation\n> > inside each option's description. Is there a canonical definition of how\n> > we do expansion in config.txt that we can just reference (and if not,\n> > can we add one)?\n> \n> We have a dedicated section for various value-types used in the\n> configuration variables already, because we needed to describe how\n> booleans and scaled integers can be spelled, and the pathname type\n> would fit there.\n> \n>  Documentation/config.txt | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index 59d7046..1bf42a6 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -169,6 +169,11 @@ thing on the same output line (e.g. opening parenthesis before the\n>  list of branch names in `log --decorate` output) is set to be\n>  painted with `bold` or some other attribute.\n>  \n> +pathname::\n> +\tA variable that takes a pathname value can be given a\n> +\tstring that begins with \"~/\" or \"~user/\", and the usual\n> +\ttilde expansion happens to such a string.\n> +\n>  \n>  Variables\n>  ~~~~~~~~~\n\nYeah, this is what I had in mind. My only reservation would be that we\nneed to make sure it is clear that this applies only to keys marked as\ntaking a \"pathname\" type in the documentation. I'm suspect there are\nones that are logically paths but do not currently do the expansion, but\nthe wording above makes it sound like any pathname-like thing does.\n\nAlternatively, it might be worth going through the list to make sure all\npaths use git_config_pathname() internally. Brian asked earlier if the\n\"no expansion\" was an intentional policy, but it's not. It's just that\npathname expansion came much later, and config keys were ported over to\nit one by one as people found it useful to do so.\n\n-Peff\n"},{"id":"284953","messageId":"xmqqr3doz5od.fsf@gitster.mtv.corp.google.com","threadId":"42174","inReplyTo":"20160429171631.GA29571@sigill.intra.peff.net","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-29T17:27:30Z","receivedAt":"2016-04-29T17:27:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> Yeah, this is what I had in mind. My only reservation would be that we\n> need to make sure it is clear that this applies only to keys marked as\n> taking a \"pathname\" type in the documentation. I'm suspect there are\n> ones that are logically paths but do not currently do the expansion, but\n> the wording above makes it sound like any pathname-like thing does.\n\nYeah, my initial draft phrased it more like how we describe boolean,\nbut somehow the language used there felt awkward to me.\n\nWith \"A variable that take a pathname value\", the users who read it\nwould find \"ones that are logically paths but do not do the\nexpansion\" and file a bug.  We'd resolve each of them by seeing if\nthe documentation says the variable does take a pathname, and adjust\neither the documentation (if the value for the variable should not\nbe expanded but the documentation hints it might be a pathname-like\nthing, clarify that it is not pathname-like at all) or the code (if\nthe value for the variable should be expanded but we forgot, we call\nthe user_path() function).\n\n> Alternatively, it might be worth going through the list to make sure all\n> paths use git_config_pathname() internally.\n\nI was hoping that with the patch we can farm out the bug-hunting\nprocess to the end users.\n\n> Brian asked earlier if the \"no expansion\" was an intentional\n> policy, but it's not. It's just that pathname expansion came much\n> later, and config keys were ported over to it one by one as people\n> found it useful to do so.\n\nYes, that matches the actual order of events.\n"},{"id":"284955","messageId":"xmqqfuu4z4pr.fsf@gitster.mtv.corp.google.com","threadId":"42174","inReplyTo":"20160429155532.GA57118@google.com","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-29T17:48:16Z","receivedAt":"2016-04-29T17:48:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brian Norris <computersforpeace@gmail.com> writes:\n\n> I mostly just copied from boilerplate on another option. IIRC, there\n> were at least two other options that were documented similarly.\n\nMy quick grep didn't find 'another option' other than include.path,\nbut how about this as a preparatory step?\n\n-- >8 --\nSubject: [PATCH] config: describe 'pathname' value type\n\nWe have a dedicated section for various value-types used in the\nconfiguration variables already, because we needed to describe how\nbooleans and scaled integers can be spelled, and the pathname type\nwould fit there.\n\nAdjust the description of `include.path` variable slightly to\nclarify that the variable is of this type.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n Documentation/config.txt | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 42d2b50..64a57fa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -81,13 +81,16 @@ Includes\n \n You can include one config file from another by setting the special\n `include.path` variable to the name of the file to be included. The\n+variable takes a pathname as its value, and is subject to tilde\n+expansion.\n+\n+The\n included file is expanded immediately, as if its contents had been\n found at the location of the include directive. If the value of the\n `include.path` variable is a relative path, the path is considered to be\n relative to the configuration file in which the include directive was\n-found. The value of `include.path` is subject to tilde expansion: `~/`\n-is expanded to the value of `$HOME`, and `~user/` to the specified\n-user's home directory. See below for examples.\n+found.  See below for examples.\n+\n \n Example\n ~~~~~~~\n@@ -169,6 +172,13 @@ thing on the same output line (e.g. opening parenthesis before the\n list of branch names in `log --decorate` output) is set to be\n painted with `bold` or some other attribute.\n \n+pathname::\n+\tA variable that takes a pathname value can be given a\n+\tstring that begins with \"~/\" or \"~user/\", and the usual\n+\ttilde expansion happens to such a string: `~/`\n+\tis expanded to the value of `$HOME`, and `~user/` to the\n+\tspecified user's home directory.\n+\n \n Variables\n ~~~~~~~~~\n-- \n2.8.1-521-g705491b\n"},{"id":"284956","messageId":"20160429174958.GA30593@sigill.intra.peff.net","threadId":"42174","inReplyTo":"xmqqfuu4z4pr.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-04-29T17:49:58Z","receivedAt":"2016-04-29T17:49:58Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Apr 29, 2016 at 10:48:16AM -0700, Junio C Hamano wrote:\n\n> Brian Norris <computersforpeace@gmail.com> writes:\n> \n> > I mostly just copied from boilerplate on another option. IIRC, there\n> > were at least two other options that were documented similarly.\n> \n> My quick grep didn't find 'another option' other than include.path,\n> but how about this as a preparatory step?\n\nI found core.excludesFile and commit.template which could use the same\ntreatment.\n\n-Peff\n"},{"id":"284957","messageId":"xmqqbn4sz4j2.fsf@gitster.mtv.corp.google.com","threadId":"42174","inReplyTo":"xmqqfuu4z4pr.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-29T17:52:17Z","receivedAt":"2016-04-29T17:52:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> Brian Norris <computersforpeace@gmail.com> writes:\n>\n>> I mostly just copied from boilerplate on another option. IIRC, there\n>> were at least two other options that were documented similarly.\n>\n> My quick grep didn't find 'another option' other than include.path,\n> but how about this as a preparatory step?\n>\n> -- >8 --\n> Subject: [PATCH] config: describe 'pathname' value type\n\nAnd then, after applying this either before or after your 1/2, we can\nsquash this into your 2/2.\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 39867f5..b7d3e69 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1665,13 +1665,11 @@ http.emptyAuth::\n \tauthentication.\n \n http.cookieFile::\n-\tFile containing previously stored cookie lines which should be used\n+\tThe pathname of a file containing previously stored cookie lines,\n+\twhich should be used\n \tin the Git http session, if they match the server. The file format\n \tof the file to read cookies from should be plain HTTP headers or\n \tthe Netscape/Mozilla cookie file format (see linkgit:curl[1]).\n-\tThe value of `http.cookieFile` is subject to tilde expansion: `~/` is\n-\texpanded to the value of `$HOME`, and `~user/` to the specified user's\n-\thome directory.\n \tNOTE that the file specified with http.cookieFile is used only as\n \tinput unless http.saveCookies is set.\n \n"},{"id":"284959","messageId":"xmqq7ffgz4ej.fsf@gitster.mtv.corp.google.com","threadId":"42174","inReplyTo":"20160429174958.GA30593@sigill.intra.peff.net","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-29T17:55:00Z","receivedAt":"2016-04-29T17:55:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Fri, Apr 29, 2016 at 10:48:16AM -0700, Junio C Hamano wrote:\n>\n>> Brian Norris <computersforpeace@gmail.com> writes:\n>> \n>> > I mostly just copied from boilerplate on another option. IIRC, there\n>> > were at least two other options that were documented similarly.\n>> \n>> My quick grep didn't find 'another option' other than include.path,\n>> but how about this as a preparatory step?\n>\n> I found core.excludesFile and commit.template which could use the same\n> treatment.\n>\n> -Peff\n\nThanks.  Perhaps squash this to the patch in the message you are\nresponding to.\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex ff7eaaf..786e0fa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -603,11 +603,10 @@ be delta compressed, but larger binary media files won't be.\n Common unit suffixes of 'k', 'm', or 'g' are supported.\n \n core.excludesFile::\n-\tIn addition to '.gitignore' (per-directory) and\n-\t'.git/info/exclude', Git looks into this file for patterns\n-\tof files which are not meant to be tracked.  \"`~/`\" is expanded\n-\tto the value of `$HOME` and \"`~user/`\" to the specified user's\n-\thome directory. Its default value is $XDG_CONFIG_HOME/git/ignore.\n+\tSpecifies the pathname to the file that contains patterns to\n+\tdescribe paths that are not meant to be tracked, in addition\n+\tto '.gitignore' (per-directory) and '.git/info/exclude'.\n+\tDefaults to $XDG_CONFIG_HOME/git/ignore.\n \tIf $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/ignore\n \tis used instead. See linkgit:gitignore[5].\n \n@@ -1116,9 +1115,8 @@ commit.status::\n \tmessage.  Defaults to true.\n \n commit.template::\n-\tSpecify a file to use as the template for new commit messages.\n-\t\"`~/`\" is expanded to the value of `$HOME` and \"`~user/`\" to the\n-\tspecified user's home directory.\n+\tSpecify the pathname of a file to use as the template for\n+\tnew commit messages.\n \n credential.helper::\n \tSpecify an external helper to be called when a username or\n"},{"id":"284960","messageId":"20160429175651.GA30765@sigill.intra.peff.net","threadId":"42174","inReplyTo":"xmqq7ffgz4ej.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 2/2] http: expand http.cookieFile as a path","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-04-29T17:56:51Z","receivedAt":"2016-04-29T17:56:51Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Apr 29, 2016 at 10:55:00AM -0700, Junio C Hamano wrote:\n\n> Thanks.  Perhaps squash this to the patch in the message you are\n> responding to.\n> \n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index ff7eaaf..786e0fa 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> [...]\n\nYeah, this (and the rest of the plan you outlined) all look good to me.\nThanks.\n\n-Peff\n"}]}