{"thread":{"id":"4215","subject":"[PATCH] Document that \"git add\" only adds non-ignored files.","startedAt":"2006-05-19T21:02:34Z","lastAt":"2006-05-20T09:54:07Z","messageCount":3,"participants":["Santi","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"20299","messageId":"8aa486160605191402k2863e5edk@mail.gmail.com","threadId":"4215","inReplyTo":null,"subject":"[PATCH] Document that \"git add\" only adds non-ignored files.","fromName":"Santi","fromEmail":"sbejar@gmail.com","sentAt":"2006-05-19T21:02:34Z","receivedAt":"2006-05-19T21:02:34Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"Signed-off-by: Santi Béjar <sbejar@gmail.com>\n\n\n---\n\n Documentation/git-add.txt |    9 ++++++---\n 1 files changed, 6 insertions(+), 3 deletions(-)\n\n9c057bcba388450963085eb5c751b734c04ff045\ndiff --git a/Documentation/git-add.txt b/Documentation/git-add.txt\nindex 5e31129..1b6a22a 100644\n--- a/Documentation/git-add.txt\n+++ b/Documentation/git-add.txt\n@@ -7,18 +7,20 @@ git-add - Add files to the index file\n\n SYNOPSIS\n --------\n-'git-add' [-n] [-v] [--] <file>...\n+'git-add' [-n] [-v] [--] <filepattern>...\n\n DESCRIPTION\n -----------\n A simple wrapper for git-update-index to add files to the index,\n for people used to do \"cvs add\".\n\n+It only adds non-ignored files, to add ignored files use\n+\"git update-index --add\".\n\n OPTIONS\n -------\n-<file>...::\n-       Files to add to the index.\n+<filepattern>...::\n+       Files to add to the index, see gitlink:git-ls-files[1].\n\n -n::\n         Don't actually add the file(s), just show if they exist.\n@@ -68,6 +70,7 @@ git-add git-*.sh::\n See Also\n --------\n gitlink:git-rm[1]\n+gitlink:git-ls-files[1]\n\n Author\n ------\n--\n1.3.3.g97ee3\n"},{"id":"20302","messageId":"7vfyj5ispx.fsf@assigned-by-dhcp.cox.net","threadId":"4215","inReplyTo":"8aa486160605191402k2863e5edk@mail.gmail.com","subject":"Re: [PATCH] Document that \"git add\" only adds non-ignored files.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-19T21:56:42Z","receivedAt":"2006-05-19T21:56:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks for the reminder, but I wonder if it is good to update\nthe description of this command, and ls-files to use the\nsame wording for consistency.  We seem to use <pathspec> to mean\n\"this is not necessarily a filename -- we glob\", so that may be\na good candidate (we do not have <pathspec> in glossary yet --\nwe would need to add).\n\nPlease don't touch description for diff-* family -- right now,\nthey say <path>, because they do not glob.  If we decide that it\nis a good idea to glob (which I suspect we don't for the\nlow-level stuff, but we probably do for the \"git-diff\" wrapper),\nwe would update the code and the description at the same time.\n"},{"id":"20317","messageId":"8aa486160605200254yef22fadj@mail.gmail.com","threadId":"4215","inReplyTo":"7vfyj5ispx.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Document that \"git add\" only adds non-ignored files.","fromName":"Santi","fromEmail":"sbejar@gmail.com","sentAt":"2006-05-20T09:54:07Z","receivedAt":"2006-05-20T09:54:07Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"2006/5/19, Junio C Hamano <junkio@cox.net>:\n> Thanks for the reminder, but I wonder if it is good to update\n> the description of this command, and ls-files to use the\n> same wording for consistency.  We seem to use <pathspec> to mean\n> \"this is not necessarily a filename -- we glob\", so that may be\n> a good candidate (we do not have <pathspec> in glossary yet --\n> we would need to add).\n\nI changed it to match with the new usage string in the buildin-add.c.\n\n>\n> Please don't touch description for diff-* family -- right now,\n> they say <path>, because they do not glob.  If we decide that it\n> is a good idea to glob (which I suspect we don't for the\n> low-level stuff, but we probably do for the \"git-diff\" wrapper),\n> we would update the code and the description at the same time.\n>\n\nOK.\n\nSanti\n"}]}