{"thread":{"id":"42149","subject":"[PATCH] config doc: improve exit code listing","startedAt":"2016-04-26T18:10:58Z","lastAt":"2016-04-26T19:41:30Z","messageCount":5,"participants":["Stefan Beller","Junio C Hamano","Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"284557","messageId":"20160426181058.7901-1-sbeller@google.com","threadId":"42149","inReplyTo":null,"subject":"[PATCH] config doc: improve exit code listing","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-04-26T18:10:58Z","receivedAt":"2016-04-26T18:10:58Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The possible reasons for exiting are now ordered by the exit code value.\nWhile at it, rewrite the `can not write to the config file` to\n`the config file cannot be written` to be grammatically correct and a\nproper sentence.\n\nSigned-off-by: Stefan Beller \n---\n Documentation/git-config.txt | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 6fc08e3..6843114 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -58,10 +58,10 @@ that location (you can say '--local' but that is the default).\n This command will fail with non-zero status upon error. Some exit\n codes are:\n \n-- The config file is invalid (ret=3),\n-- can not write to the config file (ret=4),\n+- The section or key is invalid (ret=1),\n - no section or name was provided (ret=2),\n-- the section or key is invalid (ret=1),\n+- the config file is invalid (ret=3),\n+- the config file cannot be written (ret=4),\n - you try to unset an option which does not exist (ret=5),\n - you try to unset/set an option for which multiple lines match (ret=5), or\n - you try to use an invalid regexp (ret=6).\n-- \n2.8.1.343.gb96d81e\n\nbase-commit: 3ad15fd5e17bbb73fb1161ff4e9c3ed254d5b243\n"},{"id":"284567","messageId":"xmqq8u00gr31.fsf@gitster.mtv.corp.google.com","threadId":"42149","inReplyTo":"20160426181058.7901-1-sbeller@google.com","subject":"Re: [PATCH] config doc: improve exit code listing","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-26T18:30:58Z","receivedAt":"2016-04-26T18:30:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n> The possible reasons for exiting are now ordered by the exit code value.\n\nWhich makes sense. Will queue.\n"},{"id":"284572","messageId":"571FBD52.4040206@ramsayjones.plus.com","threadId":"42149","inReplyTo":"20160426181058.7901-1-sbeller@google.com","subject":"Re: [PATCH] config doc: improve exit code listing","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-04-26T19:11:14Z","receivedAt":"2016-04-26T19:11:14Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 26/04/16 19:10, Stefan Beller wrote:\n> The possible reasons for exiting are now ordered by the exit code value.\n> While at it, rewrite the `can not write to the config file` to\n> `the config file cannot be written` to be grammatically correct and a\n> proper sentence.\n> \n> Signed-off-by: Stefan Beller \n> ---\n> Documentation/git-config.txt | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\n> index 6fc08e3..6843114 100644\n> --- a/Documentation/git-config.txt\n> +++ b/Documentation/git-config.txt\n> @@ -58,10 +58,10 @@ that location (you can say '--local' but that is the default).\n> This command will fail with non-zero status upon error. Some exit\n> codes are:\n> \n> -- The config file is invalid (ret=3),\n ^\nI don't see why this is capitalised, so ...\n\n> -- can not write to the config file (ret=4),\n> +- The section or key is invalid (ret=1),\n ^\nI don't think you should transfer the capital here. ;-)\n\n> - no section or name was provided (ret=2),\n> -- the section or key is invalid (ret=1),\n> +- the config file is invalid (ret=3),\n> +- the config file cannot be written (ret=4),\n> - you try to unset an option which does not exist (ret=5),\n> - you try to unset/set an option for which multiple lines match (ret=5), or\n> - you try to use an invalid regexp (ret=6).\n> \n\nOnly a minor point.\n\nATB,\nRamsay Jones\n"},{"id":"284574","messageId":"CAGZ79ka_spZCCwpKtUhJTA+osetbzZDpmmv6GWYV+QeBkU5Tmg@mail.gmail.com","threadId":"42149","inReplyTo":"571FBD52.4040206@ramsayjones.plus.com","subject":"Re: [PATCH] config doc: improve exit code listing","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-04-26T19:18:29Z","receivedAt":"2016-04-26T19:18:29Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Apr 26, 2016 at 12:11 PM, Ramsay Jones\n wrote:\n>\n>\n> On 26/04/16 19:10, Stefan Beller wrote:\n>> The possible reasons for exiting are now ordered by the exit code value.\n>> While at it, rewrite the `can not write to the config file` to\n>> `the config file cannot be written` to be grammatically correct and a\n>> proper sentence.\n>>\n>> Signed-off-by: Stefan Beller \n>> ---\n>> Documentation/git-config.txt | 6 +++---\n>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\n>> index 6fc08e3..6843114 100644\n>> --- a/Documentation/git-config.txt\n>> +++ b/Documentation/git-config.txt\n>> @@ -58,10 +58,10 @@ that location (you can say '--local' but that is the default).\n>> This command will fail with non-zero status upon error. Some exit\n>> codes are:\n>>\n>> -- The config file is invalid (ret=3),\n> ^\n> I don't see why this is capitalised, so ...\n\nBecause the whole listing is a bunch of sentences,\nstringed together with commas at the end of each line.\nNote that there is a ',' at the end of each line, except for\nthe last, where you see a '.'. I thought about breaking that\nup into a list and make all of the bullet points either a sentence\n(all capitalised and ending in dot) or part sentences (lower\ncase for each bullet point, not clear about the ending)\n\nI kept it as is in a long sentence as I expected to see\nlowest resistance there. ;)\n\n>\n>> -- can not write to the config file (ret=4),\n>> +- The section or key is invalid (ret=1),\n> ^\n> I don't think you should transfer the capital here. ;-)\n\nIt's the first bullet point starting the long sentence.\n\n>\n>> - no section or name was provided (ret=2),\n>> -- the section or key is invalid (ret=1),\n>> +- the config file is invalid (ret=3),\n>> +- the config file cannot be written (ret=4),\n>> - you try to unset an option which does not exist (ret=5),\n>> - you try to unset/set an option for which multiple lines match (ret=5), or\n>> - you try to use an invalid regexp (ret=6).\n>>\n>\n> Only a minor point.\n\nIf the current state bothers you too much,\nplease send a patch with correct lists. :)\n(Feel free to squash this patch into that or\njust on top of this)\n\nThanks,\nStefan\n\n>\n> ATB,\n> Ramsay Jones\n>\n>\n"},{"id":"284576","messageId":"571FC46A.1090202@ramsayjones.plus.com","threadId":"42149","inReplyTo":"CAGZ79ka_spZCCwpKtUhJTA+osetbzZDpmmv6GWYV+QeBkU5Tmg@mail.gmail.com","subject":"Re: [PATCH] config doc: improve exit code listing","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-04-26T19:41:30Z","receivedAt":"2016-04-26T19:41:30Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 26/04/16 20:18, Stefan Beller wrote:\n> On Tue, Apr 26, 2016 at 12:11 PM, Ramsay Jones\n> wrote:\n>>\n>>\n>> On 26/04/16 19:10, Stefan Beller wrote:\n>>> The possible reasons for exiting are now ordered by the exit code value.\n>>> While at it, rewrite the `can not write to the config file` to\n>>> `the config file cannot be written` to be grammatically correct and a\n>>> proper sentence.\n>>>\n>>> Signed-off-by: Stefan Beller \n>>> ---\n>>> Documentation/git-config.txt | 6 +++---\n>>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\n>>> index 6fc08e3..6843114 100644\n>>> --- a/Documentation/git-config.txt\n>>> +++ b/Documentation/git-config.txt\n>>> @@ -58,10 +58,10 @@ that location (you can say '--local' but that is the default).\n>>> This command will fail with non-zero status upon error. Some exit\n>>> codes are:\n>>>\n>>> -- The config file is invalid (ret=3),\n>> ^\n>> I don't see why this is capitalised, so ...\n> \n> Because the whole listing is a bunch of sentences,\n> stringed together with commas at the end of each line.\n> Note that there is a ',' at the end of each line, except for\n> the last, where you see a '.'.\n\nHeh, I hadn't noticed the commas, no - I assumed periods.\n\n> I thought about breaking that\n> up into a list and make all of the bullet points either a sentence\n> (all capitalised and ending in dot) or part sentences (lower\n> case for each bullet point, not clear about the ending)\n\nThat's probably what I would have done.\n\n> I kept it as is in a long sentence as I expected to see\n> lowest resistance there. ;)\n\n'One long sentence' split into a bullet/numbered list is err ...\nHmm, I'm lost for words. ;-)\n\n>> Only a minor point.\n> \n> If the current state bothers you too much,\n> please send a patch with correct lists. :)\n> (Feel free to squash this patch into that or\n> just on top of this)\n\nHaving said all that, (since I have very few documentation\nskills), I will leave this for others to improve, if\nnecessary.\n\nATB,\nRamsay Jones\n"}]}