{"thread":{"id":"42122","subject":"Awkward and confusing question in git --send-email","startedAt":"2016-04-23T18:22:35Z","lastAt":"2016-04-24T19:31:44Z","messageCount":2,"participants":["John Darrington","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"284227","messageId":"20160423182235.GA20615@jocasta.intra","threadId":"42122","inReplyTo":null,"subject":"Awkward and confusing question in git --send-email","fromName":"John Darrington","fromEmail":"john@darrington.wattle.id.au","sentAt":"2016-04-23T18:22:35Z","receivedAt":"2016-04-23T18:22:35Z","isPatch":false,"sender":{"key":"john@darrington.wattle.id.au","avatar":null},"body":"Git --send-email poses the question:\n\n \"Who should the emails be sent to (if any)?\"\n\nApart from sounding clumsy (not to mention incorrect grammar), it took me a while to work out what this meant.\n\nI suggest this be changed to :\n\n\"To whom should the email be sent (if anyone) ?\"\n\nJ'\n\n-- \nAvoid eavesdropping.  Send strong encryted email.\nPGP Public key ID: 1024D/2DE827B3 \nfingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3\nSee http://sks-keyservers.net or any PGP keyserver for public key.\n\n"},{"id":"284357","messageId":"xmqqlh42n6qn.fsf@gitster.mtv.corp.google.com","threadId":"42122","inReplyTo":"20160423182235.GA20615@jocasta.intra","subject":"Re: Awkward and confusing question in git --send-email","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-24T19:31:44Z","receivedAt":"2016-04-24T19:31:44Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"John Darrington <john@darrington.wattle.id.au> writes:\n\n> Git --send-email poses the question:\n>\n>  \"Who should the emails be sent to (if any)?\"\n>\n> Apart from sounding clumsy (not to mention incorrect grammar), it took me a while to work out what this meant.\n>\n> I suggest this be changed to :\n>\n> \"To whom should the email be sent (if anyone) ?\"\n\nSounds good.\n\n-- >8 --\nSubject: send-email: fix grammo in the prompt that asks e-mail recipients\n\nThe message, which dates back to the very original version 83b24437\nmade in 2005, sounds clumsy, grammatically incorrect, and is hard to\nunderstand.\n\nReported-by: John Darrington <john@darrington.wattle.id.au>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n git-send-email.perl | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex c45b22a..1ef94f6 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -827,9 +827,10 @@ sub file_declares_8bit_cte {\n # But it's a no-op to run sanitize_address on an already sanitized address.\n $sender = sanitize_address($sender);\n \n+my $to_whom = \"To whom should the emails be sent (if anyone)?\";\n my $prompting = 0;\n if (!@initial_to && !defined $to_cmd) {\n-\tmy $to = ask(\"Who should the emails be sent to (if any)? \",\n+\tmy $to = ask(\"$to_whom \",\n \t\t     default => \"\",\n \t\t     valid_re => qr/\\@.*\\./, confirm_only => 1);\n \tpush @initial_to, parse_address_line($to) if defined $to; # sanitized/validated later\n@@ -924,7 +925,7 @@ sub validate_address {\n \t\t\tcleanup_compose_files();\n \t\t\texit(0);\n \t\t}\n-\t\t$address = ask(\"Who should the email be sent to (if any)? \",\n+\t\t$address = ask(\"$to_whom \",\n \t\t\tdefault => \"\",\n \t\t\tvalid_re => qr/\\@.*\\./, confirm_only => 1);\n \t}\n"}]}