{"thread":{"id":"42111","subject":"[PATCH] string_list: use string-list API in unsorted_string_list_lookup()","startedAt":"2016-04-22T17:35:00Z","lastAt":"2016-04-26T15:42:50Z","messageCount":6,"participants":["Ralf Thielow","Johannes Schindelin","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"284158","messageId":"20160422173500.32329-1-ralf.thielow@gmail.com","threadId":"42111","inReplyTo":null,"subject":"[PATCH] string_list: use string-list API in unsorted_string_list_lookup()","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2016-04-22T17:35:00Z","receivedAt":"2016-04-22T17:35:00Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"Using the string-list API in function unsorted_string_list_lookup()\nmakes the code more readable. So let's do this.\n\nSigned-off-by: Ralf Thielow \n---\n string-list.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/string-list.c b/string-list.c\nindex 2a32a3f..8127e12 100644\n--- a/string-list.c\n+++ b/string-list.c\n@@ -231,12 +231,13 @@ void string_list_sort(struct string_list *list)\n struct string_list_item *unsorted_string_list_lookup(struct string_list *list,\n \t\t\t\t\t\t const char *string)\n {\n-\tint i;\n+\tstruct string_list_item *item;\n \tcompare_strings_fn cmp = list->cmp ? list->cmp : strcmp;\n \n-\tfor (i = 0; i < list->nr; i++)\n-\t\tif (!cmp(string, list->items[i].string))\n-\t\t\treturn list->items + i;\n+\tfor_each_string_list_item(item, list) {\n+\t\tif (!cmp(string, item->string))\n+\t\t\treturn item;\n+\t}\n \treturn NULL;\n }\n \n-- \n2.8.1.382.g1352ede\n"},{"id":"284239","messageId":"alpine.DEB.2.20.1604240901570.2896@virtualbox","threadId":"42111","inReplyTo":"20160422173500.32329-1-ralf.thielow@gmail.com","subject":"Re: [PATCH] string_list: use string-list API in unsorted_string_list_lookup()","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-04-24T07:06:12Z","receivedAt":"2016-04-24T07:06:12Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Ralf,\n\nOn Fri, 22 Apr 2016, Ralf Thielow wrote:\n\n> Using the string-list API in function unsorted_string_list_lookup()\n> makes the code more readable. So let's do this.\n> \n> Signed-off-by: Ralf Thielow \n> ---\n> string-list.c | 9 +++++----\n> 1 file changed, 5 insertions(+), 4 deletions(-)\n\nOh. I hoped for a reduction, not an increase.\n\n> diff --git a/string-list.c b/string-list.c\n> index 2a32a3f..8127e12 100644\n> --- a/string-list.c\n> +++ b/string-list.c\n> @@ -231,12 +231,13 @@ void string_list_sort(struct string_list *list)\n> struct string_list_item *unsorted_string_list_lookup(struct string_list *list,\n> \t\t\t\t\t\t const char *string)\n> {\n> -\tint i;\n> +\tstruct string_list_item *item;\n> \tcompare_strings_fn cmp = list->cmp ? list->cmp : strcmp;\n> \n> -\tfor (i = 0; i < list->nr; i++)\n> -\t\tif (!cmp(string, list->items[i].string))\n> -\t\t\treturn list->items + i;\n> +\tfor_each_string_list_item(item, list) {\n> +\t\tif (!cmp(string, item->string))\n> +\t\t\treturn item;\n> +\t}\n> \treturn NULL;\n\nIf you drop the extra curly braces (thereby matching Git's coding style as\nan additional bonus), at least the patch won't increase the number of\nlines.\n\nIn any case, I like the simplification of the code.\n\nCiao,\nDscho\n"},{"id":"284453","messageId":"87eg9t8uc2.fsf@gmail.com","threadId":"42111","inReplyTo":"alpine.DEB.2.20.1604240901570.2896@virtualbox","subject":"Re: [PATCH] string_list: use string-list API in unsorted_string_list_lookup()","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2016-04-25T17:35:41Z","receivedAt":"2016-04-25T17:35:41Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"Johannes Schindelin writes:\n\n>> \n>> -\tfor (i = 0; i < list->nr; i++)\n>> -\t\tif (!cmp(string, list->items[i].string))\n>> -\t\t\treturn list->items + i;\n>> +\tfor_each_string_list_item(item, list) {\n>> +\t\tif (!cmp(string, item->string))\n>> +\t\t\treturn item;\n>> +\t}\n>> \treturn NULL;\n>\n> If you drop the extra curly braces (thereby matching Git's coding style as\n> an additional bonus), at least the patch won't increase the number of\n> lines.\n>\n\nOops. I'll send a new version of the patch without these\nextra curly braces.\n\nThanks!\n\n> In any case, I like the simplification of the code.\n>\n> Ciao,\n> Dscho\n"},{"id":"284454","messageId":"20160425174000.24943-1-ralf.thielow@gmail.com","threadId":"42111","inReplyTo":"20160422173500.32329-1-ralf.thielow@gmail.com","subject":"[PATCH v2] string_list: use string-list API in unsorted_string_list_lookup()","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2016-04-25T17:40:00Z","receivedAt":"2016-04-25T17:40:00Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"Using the string-list API in function unsorted_string_list_lookup()\nmakes the code more readable.\n\nSigned-off-by: Ralf Thielow \n---\nChanges since v1:\n- remove extra curly braces\n\n string-list.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/string-list.c b/string-list.c\nindex 2a32a3f..62d2084 100644\n--- a/string-list.c\n+++ b/string-list.c\n@@ -231,12 +231,12 @@ void string_list_sort(struct string_list *list)\n struct string_list_item *unsorted_string_list_lookup(struct string_list *list,\n \t\t\t\t\t\t const char *string)\n {\n-\tint i;\n+\tstruct string_list_item *item;\n \tcompare_strings_fn cmp = list->cmp ? list->cmp : strcmp;\n \n-\tfor (i = 0; i < list->nr; i++)\n-\t\tif (!cmp(string, list->items[i].string))\n-\t\t\treturn list->items + i;\n+\tfor_each_string_list_item(item, list)\n+\t\tif (!cmp(string, item->string))\n+\t\t\treturn item;\n \treturn NULL;\n }\n \n-- \n2.8.1.430.g7c694c5\n"},{"id":"284457","messageId":"CAGZ79kbjtcnRmKPz-vP3C38hsjD3OauAvqctCmhhhfy7g4WDFQ@mail.gmail.com","threadId":"42111","inReplyTo":"20160425174000.24943-1-ralf.thielow@gmail.com","subject":"Re: [PATCH v2] string_list: use string-list API in unsorted_string_list_lookup()","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-04-25T17:47:09Z","receivedAt":"2016-04-25T17:47:09Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Mon, Apr 25, 2016 at 10:40 AM, Ralf Thielow wrote:\n> Using the string-list API in function unsorted_string_list_lookup()\n> makes the code more readable.\n>\n> Signed-off-by: Ralf Thielow \n> ---\n> Changes since v1:\n> - remove extra curly braces\n\nReviewed-by: Stefan Beller \n\n>\n> string-list.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/string-list.c b/string-list.c\n> index 2a32a3f..62d2084 100644\n> --- a/string-list.c\n> +++ b/string-list.c\n> @@ -231,12 +231,12 @@ void string_list_sort(struct string_list *list)\n> struct string_list_item *unsorted_string_list_lookup(struct string_list *list,\n> const char *string)\n> {\n> - int i;\n> + struct string_list_item *item;\n> compare_strings_fn cmp = list->cmp ? list->cmp : strcmp;\n>\n> - for (i = 0; i < list->nr; i++)\n> - if (!cmp(string, list->items[i].string))\n> - return list->items + i;\n> + for_each_string_list_item(item, list)\n> + if (!cmp(string, item->string))\n> + return item;\n> return NULL;\n> }\n>\n> --\n> 2.8.1.430.g7c694c5\n>\n"},{"id":"284529","messageId":"alpine.DEB.2.20.1604261742390.2896@virtualbox","threadId":"42111","inReplyTo":"20160425174000.24943-1-ralf.thielow@gmail.com","subject":"Re: [PATCH v2] string_list: use string-list API in unsorted_string_list_lookup()","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-04-26T15:42:50Z","receivedAt":"2016-04-26T15:42:50Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Ralf,\n\nOn Mon, 25 Apr 2016, Ralf Thielow wrote:\n\n> Using the string-list API in function unsorted_string_list_lookup()\n> makes the code more readable.\n> \n> Signed-off-by: Ralf Thielow \n> ---\n> Changes since v1:\n> - remove extra curly braces\n\nACK!\nDscho\n"}]}