{"thread":{"id":"42088","subject":"[PATCH] tag.c: remove extern keyword from function definition","startedAt":"2016-04-20T15:34:25Z","lastAt":"2016-04-20T15:39:28Z","messageCount":2,"participants":["Ramsay Jones","Santiago Torres"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"283952","messageId":"5717A181.1000603@ramsayjones.plus.com","threadId":"42088","inReplyTo":null,"subject":"[PATCH] tag.c: remove extern keyword from function definition","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-04-20T15:34:25Z","receivedAt":"2016-04-20T15:34:25Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Santiago,\n\nIf you need to re-roll your 'st/verify-tag' branch, could you\nplease squash this into the relevant patch (commit c5213b40,\n\"verify-tag: move tag verification code to tag.c\", 19-04-2016).\n\nAlthough not actually an error, it is very unusual for an extern\nkeyword to be used on a function definition (it seems to be getting\nquite unusual on a function declaration these days!), which causes\nsparse to issue a warning.\n\nThanks!\n\nATB,\nRamsay Jones\n\n tag.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/tag.c b/tag.c\nindex ace619a..93c6ae6 100644\n--- a/tag.c\n+++ b/tag.c\n@@ -30,7 +30,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)\n \treturn ret;\n }\n \n-extern int gpg_verify_tag(const unsigned char *sha1,\n+int gpg_verify_tag(const unsigned char *sha1,\n \t\tconst char *name_to_report, unsigned flags)\n {\n \tenum object_type type;\n-- \n2.8.0\n"},{"id":"283953","messageId":"20160420153928.GA1314@LykOS","threadId":"42088","inReplyTo":"5717A181.1000603@ramsayjones.plus.com","subject":"Re: [PATCH] tag.c: remove extern keyword from function definition","fromName":"Santiago Torres","fromEmail":"santiago@nyu.edu","sentAt":"2016-04-20T15:39:28Z","receivedAt":"2016-04-20T15:39:28Z","isPatch":true,"sender":{"key":"santiago@nyu.edu","avatar":"https://avatars.githubusercontent.com/u/3579933?v=4"},"body":"On Wed, Apr 20, 2016 at 04:34:25PM +0100, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Santiago,\n> \n> If you need to re-roll your 'st/verify-tag' branch, could you\n> please squash this into the relevant patch (commit c5213b40,\n> \"verify-tag: move tag verification code to tag.c\", 19-04-2016).\n> \n> Although not actually an error, it is very unusual for an extern\n> keyword to be used on a function definition (it seems to be getting\n> quite unusual on a function declaration these days!), which causes\n> sparse to issue a warning.\n\nOh sure! I'm waiting to see if there are more reviews regarding this and\nI'll re-roll. It's defintely unecessary to have the extern keyword\nthere.\n\nThanks for pointing it out!\n\n-Santiago.\n"}]}