{"thread":{"id":"42068","subject":"[PATCH resubmission] config.mak.uname: Cygwin: Use renames for creation","startedAt":"2016-04-19T09:10:55Z","lastAt":"2016-04-19T09:10:55Z","messageCount":1,"participants":["Adam Dinwoodie"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"283776","messageId":"20160419091055.GF2345@dinwoodie.org","threadId":"42068","inReplyTo":null,"subject":"[PATCH resubmission] config.mak.uname: Cygwin: Use renames for creation","fromName":"Adam Dinwoodie","fromEmail":"adam@dinwoodie.org","sentAt":"2016-04-19T09:10:55Z","receivedAt":"2016-04-19T09:10:55Z","isPatch":true,"sender":{"key":"adam@dinwoodie.org","avatar":"https://avatars.githubusercontent.com/u/1397507?v=4"},"body":"When generating build options for Cygwin, enable\nOBJECT_CREATION_USES_RENAMES.  This is necessary to use Git on Windows\nshared directories, and is already enabled for the MinGW and plain\nWindows builds.\n\nReported-by: Peter Rosin <peda@lysator.liu.se>\nSigned-off-by: Adam Dinwoodie <adam@dinwoodie.org>\n---\n\nThis patch has previously been discussed on the mailing list (see\nhttp://thread.gmane.org/gmane.comp.version-control.git/275485), back in\nAugust 2015.  The conclusion then was that the downstream Cygwin builds\nshould take this patch for a few Git releases, and then resubmit the\npatch to be taken upstream if it was causing no problems.\n\nAs the Cygwin Git maintainer, I've been applying this patch downstream\nsince v2.4.5-3 (where the \"-3\" is the Cygwin build/patch number), and\nI've seen no reports of problems caused by this patch, and the reports\nof Git on Cygwin being unable to work with Windows shared directories\nhave stopped.  As such, I'm resubmitting.\n\n config.mak.uname | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 943c439..be5cbec 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -187,6 +187,7 @@ ifeq ($(uname_O),Cygwin)\n \tX = .exe\n \tUNRELIABLE_FSTAT = UnfortunatelyYes\n \tSPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield\n+\tOBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo\n endif\n ifeq ($(uname_S),FreeBSD)\n \tNEEDS_LIBICONV = YesPlease\n-- \n2.4.5\n"}]}