{"thread":{"id":"41947","subject":"[PATCH] send-email: do not load Data::Dumper","startedAt":"2016-04-06T20:25:38Z","lastAt":"2016-04-06T21:07:32Z","messageCount":2,"participants":["Eric Wong","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"282790","messageId":"20160406202538.GA27651@dcvr.yhbt.net","threadId":"41947","inReplyTo":null,"subject":"[PATCH] send-email: do not load Data::Dumper","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2016-04-06T20:25:38Z","receivedAt":"2016-04-06T20:25:38Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"We never used Data::Dumper in this script.  The only reference\nof it was always commented out and removed over a decade ago in\ncommit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b\n(\"send-email: Change from Mail::Sendmail to Net::SMTP\")\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n While I'm in the area...\n\n git-send-email.perl | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 52cf828..38f0a7e 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -23,7 +23,6 @@ use POSIX qw/strftime/;\n use Term::ReadLine;\n use Getopt::Long;\n use Text::ParseWords;\n-use Data::Dumper;\n use Term::ANSIColor;\n use File::Temp qw/ tempdir tempfile /;\n use File::Spec::Functions qw(catfile);\n-- \nEW\n"},{"id":"282793","messageId":"20160406210706.GK28749@google.com","threadId":"41947","inReplyTo":"20160406202538.GA27651@dcvr.yhbt.net","subject":"Re: [PATCH] send-email: do not load Data::Dumper","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2016-04-06T21:07:32Z","receivedAt":"2016-04-06T21:07:32Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Eric Wong wrote:\n\n> We never used Data::Dumper in this script.  The only reference\n> of it was always commented out and removed over a decade ago in\n> commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b\n> (\"send-email: Change from Mail::Sendmail to Net::SMTP\")\n>\n> Signed-off-by: Eric Wong <normalperson@yhbt.net>\n> ---\n>  While I'm in the area...\n>\n>  git-send-email.perl | 1 -\n>  1 file changed, 1 deletion(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks.\n"}]}