{"thread":{"id":"41942","subject":"bug: nested submodules get an absolute gitdir path","startedAt":"2016-04-06T07:02:47Z","lastAt":"2016-04-07T06:44:13Z","messageCount":3,"participants":["Antti Halttunen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"282753","messageId":"CALoo-5WcdMNMcCW0EQv1VqkE5Ax7bMnvo2r7niYhYyMjA8c4wg@mail.gmail.com","threadId":"41942","inReplyTo":null,"subject":"bug: nested submodules get an absolute gitdir path","fromName":"Antti Halttunen","fromEmail":"antti.halttunen@iki.fi","sentAt":"2016-04-06T07:02:47Z","receivedAt":"2016-04-06T07:02:47Z","isPatch":false,"sender":{"key":"antti.halttunen@iki.fi","avatar":null},"body":"Hi all,\n\nStarting with git v2.7.0,\n\nsubmodules two levels deep get a .git contents of:\n gitdir: /absolute/path/name\n\nThis breaks repos that are moved or copied:\n\nfatal: Not a git repository:\n/tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub\nfatal: 'git status --porcelain' failed in submodule sub\n\nThe script https://gitlab.com/snippets/17301 reproduces the issue.\n\ngit bisect points to commit ee8838d1.\n\nthanks,\n-- \nantti\n"},{"id":"282765","messageId":"xmqqmvp6zsos.fsf@gitster.mtv.corp.google.com","threadId":"41942","inReplyTo":"CALoo-5WcdMNMcCW0EQv1VqkE5Ax7bMnvo2r7niYhYyMjA8c4wg@mail.gmail.com","subject":"Re: bug: nested submodules get an absolute gitdir path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-06T15:02:27Z","receivedAt":"2016-04-06T15:02:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Antti Halttunen <Antti.Halttunen@iki.fi> writes:\n\n> Starting with git v2.7.0,\n>\n> submodules two levels deep get a .git contents of:\n>  gitdir: /absolute/path/name\n\nI think that this is $gmane/290491\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/290491\n\nand queued as sb/submodule-helper-clone-regression-fix topic,\ncurrently included on the 'pu' branch.  Can you try it and see if it\nfixes your issue?\n\nThanks.\n\n>\n> This breaks repos that are moved or copied:\n>\n> fatal: Not a git repository:\n> /tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub\n> fatal: 'git status --porcelain' failed in submodule sub\n>\n> The script https://gitlab.com/snippets/17301 reproduces the issue.\n>\n> git bisect points to commit ee8838d1.\n>\n> thanks,\n"},{"id":"282832","messageId":"CALoo-5XQtLsiEneqLdJyi8Wa5pTX_Kz8f7C1H6ir2=J2ZLAyLg@mail.gmail.com","threadId":"41942","inReplyTo":"xmqqmvp6zsos.fsf@gitster.mtv.corp.google.com","subject":"Re: bug: nested submodules get an absolute gitdir path","fromName":"Antti Halttunen","fromEmail":"antti.halttunen@iki.fi","sentAt":"2016-04-07T06:44:13Z","receivedAt":"2016-04-07T06:44:13Z","isPatch":false,"sender":{"key":"antti.halttunen@iki.fi","avatar":null},"body":"On Wed, Apr 6, 2016 at 6:02 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Antti Halttunen <Antti.Halttunen@iki.fi> writes:\n>\n>> Starting with git v2.7.0,\n>>\n>> submodules two levels deep get a .git contents of:\n>>  gitdir: /absolute/path/name\n>\n> I think that this is $gmane/290491\n>\n> http://thread.gmane.org/gmane.comp.version-control.git/290491\n>\n> and queued as sb/submodule-helper-clone-regression-fix topic,\n> currently included on the 'pu' branch.  Can you try it and see if it\n> fixes your issue?\n\nit does, thanks.\n\n> Thanks.\n>\n>>\n>> This breaks repos that are moved or copied:\n>>\n>> fatal: Not a git repository:\n>> /tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub\n>> fatal: 'git status --porcelain' failed in submodule sub\n>>\n>> The script https://gitlab.com/snippets/17301 reproduces the issue.\n>>\n>> git bisect points to commit ee8838d1.\n>>\n>> thanks,\n\n-- \nantti\n"}]}