{"thread":{"id":"4193","subject":"[PATCH] Make git-check-format-ref a builtin.","startedAt":"2006-05-18T12:15:55Z","lastAt":"2006-05-18T12:17:22Z","messageCount":2,"participants":["Lukas Sandström"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"20226","messageId":"446C657B.7020100@etek.chalmers.se","threadId":"4193","inReplyTo":null,"subject":"[PATCH] Make git-check-format-ref a builtin.","fromName":"Lukas Sandström","fromEmail":"lukass@etek.chalmers.se","sentAt":"2006-05-18T12:15:55Z","receivedAt":"2006-05-18T12:15:55Z","isPatch":true,"sender":{"key":"luksan@gmail.com","avatar":"https://avatars.githubusercontent.com/u/152281?v=4"},"body":"\nSigned-off-by: Lukas Sandström <lukass@etek.chalmers.se>\n\n---\nIt was already written in C, but now it's 219k less in my ~/bin dir.\n\n Makefile                   |    4 ++--\n builtin-check-ref-format.c |   13 +++++++++++++\n builtin.h                  |    2 ++\n git.c                      |    1 +\n 4 files changed, 18 insertions(+), 2 deletions(-)\n create mode 100644 builtin-check-ref-format.c\n\n2e18872b12d1635a6814053f3cfc3c9e433db428\ndiff --git a/Makefile b/Makefile\nindex 3a28580..b737cb8 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -170,7 +170,7 @@ PROGRAMS = \\\n \n BUILT_INS = git-log$X git-whatchanged$X git-show$X \\\n \tgit-count-objects$X git-diff$X git-push$X \\\n-\tgit-grep$X git-add$X\n+\tgit-grep$X git-add$X git-check-ref-format$X\n \n # what 'all' will build and 'install' will install, in gitexecdir\n ALL_PROGRAMS = $(PROGRAMS) $(SIMPLE_PROGRAMS) $(SCRIPTS)\n@@ -218,7 +218,7 @@ LIB_OBJS = \\\n \n BUILTIN_OBJS = \\\n \tbuiltin-log.o builtin-help.o builtin-count.o builtin-diff.o builtin-push.o \\\n-\tbuiltin-grep.o builtin-add.o\n+\tbuiltin-grep.o builtin-add.o builtin-check-ref-format.o\n \n GITLIBS = $(LIB_FILE) $(XDIFF_LIB)\n LIBS = $(GITLIBS) -lz\ndiff --git a/builtin-check-ref-format.c b/builtin-check-ref-format.c\nnew file mode 100644\nindex 0000000..ac29383\n--- /dev/null\n+++ b/builtin-check-ref-format.c\n@@ -0,0 +1,13 @@\n+/*\n+ * GIT - The information manager from hell\n+ */\n+\n+#include \"cache.h\"\n+#include \"refs.h\"\n+\n+int cmd_check_ref_format(int argc, const char **argv, char **envp)\n+{\n+\tif (argc != 2)\n+\t\tusage(\"git check-ref-format refname\");\n+\treturn check_ref_format(argv[1]) == 0 ? 0 : 1;\n+}\ndiff --git a/builtin.h b/builtin.h\nindex ccd0e31..a26f2c2 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -27,4 +27,6 @@ extern int cmd_push(int argc, const char\n extern int cmd_grep(int argc, const char **argv, char **envp);\n extern int cmd_add(int argc, const char **argv, char **envp);\n \n+extern int cmd_check_ref_format(int argc, const char **argv, char **envp);\n+\n #endif\ndiff --git a/git.c b/git.c\nindex 6a470cf..62baf25 100644\n--- a/git.c\n+++ b/git.c\n@@ -52,6 +52,7 @@ static void handle_internal_command(int \n \t\t{ \"diff\", cmd_diff },\n \t\t{ \"grep\", cmd_grep },\n \t\t{ \"add\", cmd_add },\n+\t\t{ \"check-ref-format\", cmd_check_ref_format }\n \t};\n \tint i;\n \n-- \n1.3.2.g3c45-dirty\n"},{"id":"20227","messageId":"446C65D2.7080107@etek.chalmers.se","threadId":"4193","inReplyTo":"446C657B.7020100@etek.chalmers.se","subject":"[PATCH] Remove the non-builtin git-check-ref-format","fromName":"Lukas Sandström","fromEmail":"lukass@etek.chalmers.se","sentAt":"2006-05-18T12:17:22Z","receivedAt":"2006-05-18T12:17:22Z","isPatch":true,"sender":{"key":"luksan@gmail.com","avatar":"https://avatars.githubusercontent.com/u/152281?v=4"},"body":"\nSigned-off-by: Lukas Sandström <lukass@etek.chalmers.se>\n\n---\n\n Makefile           |    2 +-\n check-ref-format.c |   17 -----------------\n 2 files changed, 1 insertions(+), 18 deletions(-)\n delete mode 100644 check-ref-format.c\n\nd459dd88b8b541bbfa03bb3bebfac152d3d1b9e5\ndiff --git a/Makefile b/Makefile\nindex b737cb8..ee62ca2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -164,7 +164,7 @@ PROGRAMS = \\\n \tgit-ssh-upload$X git-tar-tree$X git-unpack-file$X \\\n \tgit-unpack-objects$X git-update-index$X git-update-server-info$X \\\n \tgit-upload-pack$X git-verify-pack$X git-write-tree$X \\\n-\tgit-update-ref$X git-symbolic-ref$X git-check-ref-format$X \\\n+\tgit-update-ref$X git-symbolic-ref$X \\\n \tgit-name-rev$X git-pack-redundant$X git-repo-config$X git-var$X \\\n \tgit-describe$X git-merge-tree$X git-blame$X git-imap-send$X\n \ndiff --git a/check-ref-format.c b/check-ref-format.c\ndeleted file mode 100644\nindex a0adb3d..0000000\n--- a/check-ref-format.c\n+++ /dev/null\n@@ -1,17 +0,0 @@\n-/*\n- * GIT - The information manager from hell\n- */\n-\n-#include \"cache.h\"\n-#include \"refs.h\"\n-\n-#include <stdio.h>\n-\n-int main(int ac, char **av)\n-{\n-\tif (ac != 2)\n-\t\tusage(\"git-check-ref-format refname\");\n-\tif (check_ref_format(av[1]))\n-\t\texit(1);\n-\treturn 0;\n-}\n-- \n1.3.2.g3c45-dirty\n"}]}