{"thread":{"id":"41916","subject":"[PATCH] comment for a long #ifdef","startedAt":"2016-04-04T01:00:49Z","lastAt":"2016-04-04T17:54:18Z","messageCount":4,"participants":["Ivan Pozdeev","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"282589","messageId":"5701BCC1.9050306@mail.mipt.ru","threadId":"41916","inReplyTo":null,"subject":"[PATCH] comment for a long #ifdef","fromName":"Ivan Pozdeev","fromEmail":"vano@mail.mipt.ru","sentAt":"2016-04-04T01:00:49Z","receivedAt":"2016-04-04T01:00:49Z","isPatch":true,"sender":{"key":"vano@mail.mipt.ru","avatar":null},"body":"---\ncompat/poll/poll.c | 4 ++--\n1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/compat/poll/poll.c b/compat/poll/poll.c\nindex db4e03e..5eb0280 100644\n--- a/compat/poll/poll.c\n+++ b/compat/poll/poll.c\n@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)\n}\n\nreturn rc;\n-#else\n+#else /* #ifndef WIN32_NATIVE */\nstatic struct timeval tv0;\nstatic HANDLE hEvent;\nWSANETWORKEVENTS ev;\n@@ -622,5 +622,5 @@ restart:\n}\n\nreturn rc;\n-#endif\n+#endif /* #ifndef WIN32_NATIVE */\n}\n-- \n1.9.5.msysgit.1\n\n\n-- \nRegards,\nIvan\n"},{"id":"282593","messageId":"CAPig+cS=oGvs3zWA782APy7moo3N-4-Oe9B8obej5oWKxw9Gsg@mail.gmail.com","threadId":"41916","inReplyTo":"5701BCC1.9050306@mail.mipt.ru","subject":"Re: [PATCH] comment for a long #ifdef","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-04-04T01:54:16Z","receivedAt":"2016-04-04T01:54:16Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Apr 3, 2016 at 9:00 PM, Ivan Pozdeev <vano@mail.mipt.ru> wrote:\n> ---\n\nMissing sign-off. See Documentation/SubmittingPatches.\n\n> compat/poll/poll.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/compat/poll/poll.c b/compat/poll/poll.c\n> index db4e03e..5eb0280 100644\n> --- a/compat/poll/poll.c\n> +++ b/compat/poll/poll.c\n> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)\n> }\n>\n> return rc;\n> -#else\n> +#else /* #ifndef WIN32_NATIVE */\n> static struct timeval tv0;\n> static HANDLE hEvent;\n> WSANETWORKEVENTS ev;\n> @@ -622,5 +622,5 @@ restart:\n> }\n>\n> return rc;\n> -#endif\n> +#endif /* #ifndef WIN32_NATIVE */\n> }\n"},{"id":"282625","messageId":"5702A319.9030708@mail.mipt.ru","threadId":"41916","inReplyTo":"CAPig+cS=oGvs3zWA782APy7moo3N-4-Oe9B8obej5oWKxw9Gsg@mail.gmail.com","subject":"Re: [PATCH] comment for a long #ifdef","fromName":"Ivan Pozdeev","fromEmail":"vano@mail.mipt.ru","sentAt":"2016-04-04T17:23:37Z","receivedAt":"2016-04-04T17:23:37Z","isPatch":true,"sender":{"key":"vano@mail.mipt.ru","avatar":null},"body":"Signed-off-by: Ivan Pozdeev\n---\ncompat/poll/poll.c | 4 ++--\n1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/compat/poll/poll.c b/compat/poll/poll.c\nindex db4e03e..5eb0280 100644\n--- a/compat/poll/poll.c\n+++ b/compat/poll/poll.c\n@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)\n}\n\nreturn rc;\n-#else\n+#else /* #ifndef WIN32_NATIVE */\nstatic struct timeval tv0;\nstatic HANDLE hEvent;\nWSANETWORKEVENTS ev;\n@@ -622,5 +622,5 @@ restart:\n}\n\nreturn rc;\n-#endif\n+#endif /* #ifndef WIN32_NATIVE */\n}\n-- \n1.9.5.msysgit.1\n\n\n-- \nRegards,\nIvan\n"},{"id":"282634","messageId":"xmqq4mbh5kfp.fsf@gitster.mtv.corp.google.com","threadId":"41916","inReplyTo":"5701BCC1.9050306@mail.mipt.ru","subject":"Re: [PATCH] comment for a long #ifdef","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-04-04T17:54:18Z","receivedAt":"2016-04-04T17:54:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ivan Pozdeev <vano@mail.mipt.ru> writes:\n\n> ---\n> compat/poll/poll.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nAs Eric pointed out, please sign-off your patch.\n\n> diff --git a/compat/poll/poll.c b/compat/poll/poll.c\n> index db4e03e..5eb0280 100644\n> --- a/compat/poll/poll.c\n> +++ b/compat/poll/poll.c\n> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)\n> }\n>\n> return rc;\n> -#else\n> +#else /* #ifndef WIN32_NATIVE */\n> static struct timeval tv0;\n> static HANDLE hEvent;\n> WSANETWORKEVENTS ev;\n> @@ -622,5 +622,5 @@ restart:\n> }\n>\n> return rc;\n> -#endif\n> +#endif /* #ifndef WIN32_NATIVE */\n> }\n> -- \n> 1.9.5.msysgit.1\n\nThere also is an #ifndef/#else/#endif in abspath.c that is larger\nthan a typical patch context; could you include a fix for that, too?\n"}]}