{"thread":{"id":"41913","subject":"[PATCH] convert.c: fix some sparse warnings","startedAt":"2016-04-03T18:43:35Z","lastAt":"2016-04-03T18:43:35Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"282568","messageId":"57016457.30405@ramsayjones.plus.com","threadId":"41913","inReplyTo":null,"subject":"[PATCH] convert.c: fix some sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-04-03T18:43:35Z","receivedAt":"2016-04-03T18:43:35Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSparse complains thus:\n\n        SP convert.c\n    convert.c:180:24: warning: Using plain integer as NULL pointer\n    convert.c:241:28: warning: dubious: !x & y\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Torsten,\n\nWhen you re-roll your 'tb/safe-crlf-output-fix' branch, could you\nplease squash this into your patch (corresponding to commit 9c7b132f,\n\"convert.c: more safer crlf handling with text attribute\", 01-04-2016).\n\n>From an earlier email, I see that you are aware that t6038 is failing, so\nI won't look into that.\n\nThanks!\n\nATB,\nRamsay Jones\n\n convert.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/convert.c b/convert.c\nindex 1fddbe8..1fa7986 100644\n--- a/convert.c\n+++ b/convert.c\n@@ -177,7 +177,7 @@ const char *get_wt_convert_stats_ascii(const char *path)\n \tmemset(&stats, 0, sizeof(stats));\n \tfd = open(path, O_RDONLY);\n \tif (fd < 0)\n-\t\treturn 0;\n+\t\treturn NULL;\n \tfor (;;) {\n \t\tchar buf[1024];\n \t\tssize_t readlen = read(fd, buf, sizeof(buf));\n@@ -238,7 +238,7 @@ static int would_convert_lf_at_checkout(unsigned convert_stats,\n \t\treturn 0;\n \n \t/* No \"naked\" LF? Nothing to convert, regardless. */\n-\tif (!convert_stats & CONVERT_STAT_BITS_TXT_LF)\n+\tif (!(convert_stats & CONVERT_STAT_BITS_TXT_LF))\n \t\treturn 0;\n \n \tif (crlf_action == CRLF_AUTO ||\n-- \n2.8.0\n"}]}