{"thread":{"id":"41847","subject":"[RFC/PATCH] t/perf: \"make clean\" from the top-level to clean results","startedAt":"2016-03-28T20:16:50Z","lastAt":"2016-03-29T10:44:29Z","messageCount":3,"participants":["Junio C Hamano","Jeff King","Beat Bolli"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"281985","messageId":"xmqqfuvaxsr1.fsf@gitster.mtv.corp.google.com","threadId":"41847","inReplyTo":null,"subject":"[RFC/PATCH] t/perf: \"make clean\" from the top-level to clean results","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-28T20:16:50Z","receivedAt":"2016-03-28T20:16:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Running \"make clean\" from the top-level after running perf tests\nleft t/perf/test-results/ directory and tons of files in it.  At\nleast \"make distclean\" should turn things back to pristine state.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * Perhaps I am missing some reason why this was deliberately left\n   out when we added t/perf/Makefile that does have the clean\n   target?  Cc'ing the suspects found by \"shortlog t/perf\".\n\n t/Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 18e2b28..e0aef9a 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -48,6 +48,7 @@ pre-clean:\n clean-except-prove-cache:\n \t$(RM) -r 'trash directory'.* '$(TEST_RESULTS_DIRECTORY_SQ)'\n \t$(RM) -r valgrind/bin\n+\tcd perf && $(MAKE) clean\n \n clean: clean-except-prove-cache\n \t$(RM) .prove\n"},{"id":"281986","messageId":"20160328202042.GA23792@sigill.intra.peff.net","threadId":"41847","inReplyTo":"xmqqfuvaxsr1.fsf@gitster.mtv.corp.google.com","subject":"Re: [RFC/PATCH] t/perf: \"make clean\" from the top-level to clean results","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-03-28T20:20:42Z","receivedAt":"2016-03-28T20:20:42Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Mar 28, 2016 at 01:16:50PM -0700, Junio C Hamano wrote:\n\n> Running \"make clean\" from the top-level after running perf tests\n> left t/perf/test-results/ directory and tons of files in it.  At\n> least \"make distclean\" should turn things back to pristine state.\n> \n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n> \n>  * Perhaps I am missing some reason why this was deliberately left\n>    out when we added t/perf/Makefile that does have the clean\n>    target?  Cc'ing the suspects found by \"shortlog t/perf\".\n\nI don't think I've ever touched the \"clean\" code path.\n\nThis change is fine by me. I have noticed that the contents of\nt/perf/build can pile up and consume quite a lot of space, as they are\nall full builds of git. They're a little more expensive to reproduce\nthan some other things, but they're inherently still a cache. I think\nyour patch is doing the right thing.\n\n-Peff\n"},{"id":"282045","messageId":"loom.20160329T124227-493@post.gmane.org","threadId":"41847","inReplyTo":"xmqqfuvaxsr1.fsf@gitster.mtv.corp.google.com","subject":"Re: [RFC/PATCH] t/perf:","fromName":"Beat Bolli","fromEmail":"dev+git@drbeat.li","sentAt":"2016-03-29T10:44:29Z","receivedAt":"2016-03-29T10:44:29Z","isPatch":true,"sender":{"key":"dev+git@drbeat.li","avatar":"https://avatars.githubusercontent.com/u/21444?v=4"},"body":"Junio C Hamano <gitster <at> pobox.com> writes:\n\n> +\tcd perf && $(MAKE) clean\n\nI think the clean way to do this is\n\n\t$(make) -C perf clean\n\nRegards,\nBeat\n"}]}