{"thread":{"id":"41813","subject":"[PATCH 1/2] completion: add option '--guides' to 'git help'","startedAt":"2016-03-24T18:27:12Z","lastAt":"2016-03-24T21:45:32Z","messageCount":7,"participants":["Ralf Thielow","Junio C Hamano","Philip Oakley"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"281705","messageId":"1458844034-12855-1-git-send-email-ralf.thielow@gmail.com","threadId":"41813","inReplyTo":null,"subject":"[PATCH 0/2] completion: git-help: add missing option and params","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2016-03-24T18:27:12Z","receivedAt":"2016-03-24T18:27:12Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"The bash completion is missing the option '--guides' for 'git-help'\nand some params you see there. Add them both.\n\nRalf Thielow (2):\n completion: add option '--guides' to 'git help'\n completion: add 'revisions' and 'everyday' to 'git help'\n\n contrib/completion/git-completion.bash | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n-- \n2.8.0.rc4.7.g35d7ca9.dirty\n"},{"id":"281704","messageId":"1458844034-12855-2-git-send-email-ralf.thielow@gmail.com","threadId":"41813","inReplyTo":"1458844034-12855-1-git-send-email-ralf.thielow@gmail.com","subject":"[PATCH 1/2] completion: add option '--guides' to 'git help'","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2016-03-24T18:27:13Z","receivedAt":"2016-03-24T18:27:13Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"Signed-off-by: Ralf Thielow \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex e3918c8..70f4171 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1339,7 +1339,7 @@ _git_help ()\n {\n \tcase \"$cur\" in\n \t--*)\n-\t\t__gitcomp \"--all --info --man --web\"\n+\t\t__gitcomp \"--all --guides --info --man --web\"\n \t\treturn\n \t\t;;\n \tesac\n-- \n2.8.0.rc4.7.g35d7ca9.dirty\n"},{"id":"281706","messageId":"1458844034-12855-3-git-send-email-ralf.thielow@gmail.com","threadId":"41813","inReplyTo":"1458844034-12855-1-git-send-email-ralf.thielow@gmail.com","subject":"[PATCH 2/2] completion: add 'revisions' and 'everyday' to 'git help'","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2016-03-24T18:27:14Z","receivedAt":"2016-03-24T18:27:14Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"Signed-off-by: Ralf Thielow \n---\n contrib/completion/git-completion.bash | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 70f4171..ffe6004 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1346,8 +1346,8 @@ _git_help ()\n \t__git_compute_all_commands\n \t__gitcomp \"$__git_all_commands $(__git_aliases)\n \t\tattributes cli core-tutorial cvs-migration\n-\t\tdiffcore gitk glossary hooks ignore modules\n-\t\tnamespaces repository-layout tutorial tutorial-2\n+\t\tdiffcore everyday gitk glossary hooks ignore modules\n+\t\tnamespaces repository-layout revisions tutorial tutorial-2\n \t\tworkflows\n \t\t\"\n }\n-- \n2.8.0.rc4.7.g35d7ca9.dirty\n"},{"id":"281717","messageId":"xmqqbn638x2i.fsf@gitster.mtv.corp.google.com","threadId":"41813","inReplyTo":"1458844034-12855-2-git-send-email-ralf.thielow@gmail.com","subject":"Re: [PATCH 1/2] completion: add option '--guides' to 'git help'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-24T20:01:25Z","receivedAt":"2016-03-24T20:01:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ralf Thielow writes:\n\n> Signed-off-by: Ralf Thielow \n> ---\n> contrib/completion/git-completion.bash | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nSounds sensible. Thanks.\n\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index e3918c8..70f4171 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1339,7 +1339,7 @@ _git_help ()\n> {\n> \tcase \"$cur\" in\n> \t--*)\n> -\t\t__gitcomp \"--all --info --man --web\"\n> +\t\t__gitcomp \"--all --guides --info --man --web\"\n> \t\treturn\n> \t\t;;\n> \tesac\n"},{"id":"281718","messageId":"xmqq7fgr8wqc.fsf@gitster.mtv.corp.google.com","threadId":"41813","inReplyTo":"1458844034-12855-3-git-send-email-ralf.thielow@gmail.com","subject":"Re: [PATCH 2/2] completion: add 'revisions' and 'everyday' to 'git help'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-24T20:08:43Z","receivedAt":"2016-03-24T20:08:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ralf Thielow writes:\n\n> Signed-off-by: Ralf Thielow \n> ---\n> contrib/completion/git-completion.bash | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nIt is somewhat silly that we have to maintain this list to be in\nsync with the set of documents we offer. Wouldn't it make more\nsense to go in the direction of _removing_ this list of hardcoded\nwords here?\n\nThe first step may be to teach a new subcommand to \"git help\"\nto show a list of these words, and then _git_help can use it to\nlazily compute the list just like __git_commands does.\n\nBut this change itself is not wrong per-se; will queue to see where\nfollow-up discussion will lead us to.\n\nThanks.\n\n\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 70f4171..ffe6004 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1346,8 +1346,8 @@ _git_help ()\n> \t__git_compute_all_commands\n> \t__gitcomp \"$__git_all_commands $(__git_aliases)\n> \t\tattributes cli core-tutorial cvs-migration\n> -\t\tdiffcore gitk glossary hooks ignore modules\n> -\t\tnamespaces repository-layout tutorial tutorial-2\n> +\t\tdiffcore everyday gitk glossary hooks ignore modules\n> +\t\tnamespaces repository-layout revisions tutorial tutorial-2\n> \t\tworkflows\n> \t\t\"\n> }\n"},{"id":"281720","messageId":"B40A8BBB3787424787785220EA6BFCFE@PhilipOakley","threadId":"41813","inReplyTo":"xmqq7fgr8wqc.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 2/2] completion: add 'revisions' and 'everyday' to 'git help'","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.org","sentAt":null,"receivedAt":"2016-03-24T20:15:53Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: \"Junio C Hamano\" \n> Ralf Thielow writes:\n>\n>> Signed-off-by: Ralf Thielow \n>> ---\n>> contrib/completion/git-completion.bash | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> It is somewhat silly that we have to maintain this list to be in\n> sync with the set of documents we offer. Wouldn't it make more\n> sense to go in the direction of _removing_ this list of hardcoded\n> words here?\n>\n> The first step may be to teach a new subcommand to \"git help\"\n> to show a list of these words, and then _git_help can use it to\n> lazily compute the list just like __git_commands does.\n\n'git help -a' (or --all) already determines the list of commands available, \nbut then formats it prettily for user consumption. Maybe an alternate --list \noption?\n\n>\n> But this change itself is not wrong per-se; will queue to see where\n> follow-up discussion will lead us to.\n>\n> Thanks.\n>\n>\n>> diff --git a/contrib/completion/git-completion.bash \n>> b/contrib/completion/git-completion.bash\n>> index 70f4171..ffe6004 100644\n>> --- a/contrib/completion/git-completion.bash\n>> +++ b/contrib/completion/git-completion.bash\n>> @@ -1346,8 +1346,8 @@ _git_help ()\n>> __git_compute_all_commands\n>> __gitcomp \"$__git_all_commands $(__git_aliases)\n>> attributes cli core-tutorial cvs-migration\n>> - diffcore gitk glossary hooks ignore modules\n>> - namespaces repository-layout tutorial tutorial-2\n>> + diffcore everyday gitk glossary hooks ignore modules\n>> + namespaces repository-layout revisions tutorial tutorial-2\n>> workflows\n>> \"\n>> }\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n"},{"id":"281729","messageId":"xmqqmvpn7doj.fsf@gitster.mtv.corp.google.com","threadId":"41813","inReplyTo":"B40A8BBB3787424787785220EA6BFCFE@PhilipOakley","subject":"Re: [PATCH 2/2] completion: add 'revisions' and 'everyday' to 'git help'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-24T21:45:32Z","receivedAt":"2016-03-24T21:45:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Philip Oakley\" writes:\n\n>> The first step may be to teach a new subcommand to \"git help\"\n>> to show a list of these words, and then _git_help can use it to\n>> lazily compute the list just like __git_commands does.\n>\n> 'git help -a' (or --all) already determines the list of commands\n> available, but then formats it prettily for user consumption. Maybe an\n> alternate --list option?\n\nYes, that is exactly what I meant.\n"}]}