{"thread":{"id":"41763","subject":"[PATCH v2 0/2] git-p4: fix AsciiDoc formatting","startedAt":"2016-03-20T18:39:19Z","lastAt":"2016-03-21T17:53:42Z","messageCount":4,"participants":["larsxschneider@gmail.com","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"281298","messageId":"1458499161-61642-1-git-send-email-larsxschneider@gmail.com","threadId":"41763","inReplyTo":null,"subject":"[PATCH v2 0/2] git-p4: fix AsciiDoc formatting","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-03-20T18:39:19Z","receivedAt":"2016-03-20T18:39:19Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\ndiff to v1:\n* reference external pages similar to git-bisect-lk2009 (thanks Luke)\n* fix quotation marks (you can see the error here:\n https://git-scm.com/docs/git-p4/2.7.4 ... search for cp1252 )\n\nThanks,\nLars\n\n\nLars Schneider (2):\n Documentation: fix git-p4 AsciiDoc formatting\n Documentation: use ASCII quotation marks in git-p4\n\n Documentation/git-p4.txt | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)\n\n--\n2.5.1\n"},{"id":"281299","messageId":"1458499161-61642-2-git-send-email-larsxschneider@gmail.com","threadId":"41763","inReplyTo":"1458499161-61642-1-git-send-email-larsxschneider@gmail.com","subject":"[PATCH v2 1/2] Documentation: fix git-p4 AsciiDoc formatting","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-03-20T18:39:20Z","receivedAt":"2016-03-20T18:39:20Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nNoticed-by: Eric Sunshine \nSigned-off-by: Lars Schneider \n---\n Documentation/git-p4.txt | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\nindex 738cfde..6457634 100644\n--- a/Documentation/git-p4.txt\n+++ b/Documentation/git-p4.txt\n@@ -520,15 +520,13 @@ git-p4.pathEncoding::\n git-p4.largeFileSystem::\n \tSpecify the system that is used for large (binary) files. Please note\n \tthat large file systems do not support the 'git p4 submit' command.\n-\tOnly Git LFS [1] is implemented right now. Download\n+\tOnly Git LFS <<1>> is implemented right now. Download\n \tand install the Git LFS command line extension to use this option\n \tand configure it like this:\n +\n -------------\n git config git-p4.largeFileSystem GitLFS\n -------------\n-+\n-\t[1] https://git-lfs.github.com/\n \n git-p4.largeFileExtensions::\n \tAll files matching a file extension in the list will be processed\n@@ -626,3 +624,8 @@ IMPLEMENTATION DETAILS\n message indicating the p4 depot location and change number. This\n line is used by later 'git p4 sync' operations to know which p4\n changes are new.\n+\n+REFERENCES\n+----------\n+\n+- [[[1]]] https://git-lfs.github.com/[Git LFS - An open source Git extension for versioning large files]\n-- \n2.5.1\n"},{"id":"281300","messageId":"1458499161-61642-3-git-send-email-larsxschneider@gmail.com","threadId":"41763","inReplyTo":"1458499161-61642-1-git-send-email-larsxschneider@gmail.com","subject":"[PATCH v2 2/2] Documentation: use ASCII quotation marks in git-p4","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-03-20T18:39:21Z","receivedAt":"2016-03-20T18:39:21Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nSigned-off-by: Lars Schneider \n---\n Documentation/git-p4.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt\nindex 6457634..8afb31d 100644\n--- a/Documentation/git-p4.txt\n+++ b/Documentation/git-p4.txt\n@@ -515,7 +515,7 @@ git-p4.pathEncoding::\n \tGit expects paths encoded as UTF-8. Use this config to tell git-p4\n \twhat encoding Perforce had used for the paths. This encoding is used\n \tto transcode the paths to UTF-8. As an example, Perforce on Windows\n-\toften uses “cp1252” to encode path names.\n+\toften uses \"cp1252\" to encode path names.\n \n git-p4.largeFileSystem::\n \tSpecify the system that is used for large (binary) files. Please note\n-- \n2.5.1\n"},{"id":"281354","messageId":"xmqqpounn2e1.fsf@gitster.mtv.corp.google.com","threadId":"41763","inReplyTo":"1458499161-61642-1-git-send-email-larsxschneider@gmail.com","subject":"Re: [PATCH v2 0/2] git-p4: fix AsciiDoc formatting","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-21T17:53:42Z","receivedAt":"2016-03-21T17:53:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"larsxschneider@gmail.com writes:\n\n> From: Lars Schneider \n>\n> diff to v1:\n> * reference external pages similar to git-bisect-lk2009 (thanks Luke)\n> * fix quotation marks (you can see the error here:\n> https://git-scm.com/docs/git-p4/2.7.4 ... search for cp1252 )\n>\n> Thanks,\n> Lars\n>\n>\n> Lars Schneider (2):\n> Documentation: fix git-p4 AsciiDoc formatting\n> Documentation: use ASCII quotation marks in git-p4\n>\n> Documentation/git-p4.txt | 11 +++++++----\n> 1 file changed, 7 insertions(+), 4 deletions(-)\n\nHmph, this seems to break my build.\n\nxmlto: /home/gitster/w/git.git/Documentation/git-p4.xml does not validate (status 3)\nxmlto: Fix document syntax or use --skip-validation option\n/home/gitster/w/git.git/Documentation/git-p4.xml:812: element xref: validity error : Syntax of value for attribute linkend of xref is not valid\n/home/gitster/w/git.git/Documentation/git-p4.xml:1077: element anchor: validity error : Syntax of value for attribute id of anchor is not valid\nDocument /home/gitster/w/git.git/Documentation/git-p4.xml does not validate\n\n\nOn line #812 of the generated file I see this:\n\n Only Git LFS is implemented right now. Download\n\nAnd line #1077 I see this:\n\n[1] Git LFS - An open source Git extension for versioning large files\n\nIt could be that mimicking git-bisect-lk2009 that never is formatted\nas manpage is a bad idea to begin with?\n\n$ xmlto --version\nxmlto version 0.0.25\n"}]}