{"thread":{"id":"41700","subject":"[PATCH] t/lib-httpd: pass through GIT_CONFIG_NOSYSTEM env","startedAt":"2016-03-16T00:56:52Z","lastAt":"2016-03-16T00:56:52Z","messageCount":1,"participants":["Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"280862","messageId":"20160316005651.GA29541@sigill.intra.peff.net","threadId":"41700","inReplyTo":null,"subject":"[PATCH] t/lib-httpd: pass through GIT_CONFIG_NOSYSTEM env","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-03-16T00:56:52Z","receivedAt":"2016-03-16T00:56:52Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"We set GIT_CONFIG_NOSYSTEM in our test scripts so that we do\nnot accidentally read /etc/gitconfig and have it influence\nthe outcome of the tests. But when running smart-http tests,\nApache will clean the environment, including this variable,\nand the \"server\" side of our http operations will read it.\n\nYou can see this breakage by doing something like:\n\n  make\n  ./git config --system http.getanyfile false\n  make test\n\nwhich will cause t5561 to fail when it tests the\nfallback-to-dumb operation.\n\nWe can fix this by instructing Apache to pass through the\nvariable. Unlike with other variables (e.g., 89c57ab3's\nGIT_TRACE), we don't need to set a dummy value to prevent\nwarnings from Apache. test-lib.sh already makes sure that\nGIT_CONFIG_NOSYSTEM is set and exported.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nObviously trivial enough for \"maint\", but not at all urgent; it has\nbeen this way for ages. I only noticed because I happened to recently\nmunge my system config to replicate a particular server config which\ndisables http.getanyfile.\n\n t/lib-httpd/apache.conf | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf\nindex f667e7c..9317ba0 100644\n--- a/t/lib-httpd/apache.conf\n+++ b/t/lib-httpd/apache.conf\n@@ -74,6 +74,7 @@ PassEnv GIT_VALGRIND_OPTIONS\n PassEnv GNUPGHOME\n PassEnv ASAN_OPTIONS\n PassEnv GIT_TRACE\n+PassEnv GIT_CONFIG_NOSYSTEM\n \n Alias /dumb/ www/\n Alias /auth/dumb/ www/auth/dumb/\n-- \n2.8.0.rc2.331.ga574393\n"}]}