{"thread":{"id":"41530","subject":"[PATCH] SubmittingPatches : WIP tag in patches","startedAt":"2016-02-26T08:00:26Z","lastAt":"2016-02-26T14:19:21Z","messageCount":5,"participants":["Pranit Bauva","Eric Sunshine","Stefan Tatschner"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"279493","messageId":"CAPig+cT9Aqm0+AEGz0F-CTihMJtMw45fq4h6zxKs_7uxHak0bg@mail.gmail.com","threadId":"41530","inReplyTo":"56D05BA2.1090502@zoho.com","subject":"Re: [PATCH] SubmittingPatches : WIP tag in patches","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-02-26T08:00:26Z","receivedAt":"2016-02-26T08:00:26Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote:\n> ---\n\nMissing sign-off.\n\n> diff --git a/Documentation/SubmittingPatches\n> @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch\n> is also\n> encouraged. E.g. [PATCH/RFC] is often used when the patch is\n> not ready to be applied but it is for discussion, [PATCH v2],\n> [PATCH v3] etc. are often seen when you are sending an update to\n> -what you have previously sent.\n> +what you have previously sent. [PATCH/WIP] is often used when some\n\nPerhaps: /is often/can be/\n\n> +work is yet left to be done on the patch but you want to get the\n> +review on the completed part of the patch.\n\nMaybe: s/review/feedback/\n\n> \"git format-patch\" command follows the best current practice to\n> format the body of an e-mail message. At the beginning of the\n> --\n> 2.1.4\n"},{"id":"279497","messageId":"CAPig+cTmUo_9Ji+73EiEXibjy=kN7w6bhFYraBNdhc1nO7D0pg@mail.gmail.com","threadId":"41530","inReplyTo":"56D05EE9.8020400@zoho.com","subject":"Re: [PATCH] SubmittingPatches : WIP tag in patches","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-02-26T08:19:50Z","receivedAt":"2016-02-26T08:19:50Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Feb 26, 2016 at 9:19 AM, Pranit Bauva wrote:\n> Eric Sunshine:\n>> On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote:\n>>> ---\n>> Missing sign-off.\n>\n> I have to inoculate the habit of signing off every time.\n>>> diff --git a/Documentation/SubmittingPatches\n>>> @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch\n>>> is also\n>>> encouraged. E.g. [PATCH/RFC] is often used when the patch is\n>>> not ready to be applied but it is for discussion, [PATCH v2],\n>>> [PATCH v3] etc. are often seen when you are sending an update to\n>>> -what you have previously sent.\n>>> +what you have previously sent. [PATCH/WIP] is often used when some\n>>\n>> Perhaps: /is often/can be/\n>>\n>>> +work is yet left to be done on the patch but you want to get the\n>>> +review on the completed part of the patch.\n>>\n>> Maybe: s/review/feedback/\n>>\n>>> \"git format-patch\" command follows the best current practice to\n>>> format the body of an e-mail message. At the beginning of the\n>>> --\n>>> 2.1.4\n>\n> I have done the required changes, now I should send another email with\n> tag [PATCH v2] right?\n\nYes, you can do that, or wait a bit longer for feedback from other reviewers.\n\nIt's also a good idea in the commentary section to say what changed\nbetween v1 and v2, and, as an aid to reviewers, provide a link like\nthis[1] to the previous version.\n\n[1]: http://thread.gmane.org/gmane.comp.version-control.git/287544\n"},{"id":"279501","messageId":"56D00AA6.4060302@sevenbyte.org","threadId":"41530","inReplyTo":"56D05EE9.8020400@zoho.com","subject":"Re: [PATCH] SubmittingPatches : WIP tag in patches","fromName":"Stefan Tatschner","fromEmail":"rumpelsepp@sevenbyte.org","sentAt":"2016-02-26T08:19:50Z","receivedAt":"2016-02-26T08:19:50Z","isPatch":true,"sender":{"key":"rumpelsepp@sevenbyte.org","avatar":"https://gravatar.com/avatar/49dd3c8f0ded4869dda004471ce2ea006089614d92fde839d8ccb289275b050e?d=mp&s=160"},"body":"On 26.02.2016 15:19, Pranit Bauva wrote:\n> I have to inoculate the habit of signing off every time.\n\nThere is this in git-config(1); hope that helps.\n\nformat.signOff\n A boolean value which lets you enable the -s/--signoff option of\n format-patch by default. Note: Adding the Signed-off-by: line to a\n patch should be a conscious act and means that you certify you have\n the rights to submit this work under the same open source license.\n Please see the SubmittingPatches document for further discussion.\n\nStefan\n"},{"id":"279491","messageId":"56D05BA2.1090502@zoho.com","threadId":"41530","inReplyTo":null,"subject":"[PATCH] SubmittingPatches : WIP tag in patches","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@zoho.com","sentAt":"2016-02-26T14:05:22Z","receivedAt":"2016-02-26T14:05:22Z","isPatch":true,"sender":{"key":"pranit.bauva@zoho.com","avatar":null},"body":"\n---\n Documentation/SubmittingPatches | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/SubmittingPatches\nb/Documentation/SubmittingPatches\nindex 98fc4cc..b2c7664 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch\nis also\n encouraged. E.g. [PATCH/RFC] is often used when the patch is\n not ready to be applied but it is for discussion, [PATCH v2],\n [PATCH v3] etc. are often seen when you are sending an update to\n-what you have previously sent.\n+what you have previously sent. [PATCH/WIP] is often used when some\n+work is yet left to be done on the patch but you want to get the\n+review on the completed part of the patch.\n\n \"git format-patch\" command follows the best current practice to\n format the body of an e-mail message. At the beginning of the\n-- \n2.1.4\n"},{"id":"279495","messageId":"56D05EE9.8020400@zoho.com","threadId":"41530","inReplyTo":"CAPig+cT9Aqm0+AEGz0F-CTihMJtMw45fq4h6zxKs_7uxHak0bg@mail.gmail.com","subject":"Re: [PATCH] SubmittingPatches : WIP tag in patches","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@zoho.com","sentAt":"2016-02-26T14:19:21Z","receivedAt":"2016-02-26T14:19:21Z","isPatch":true,"sender":{"key":"pranit.bauva@zoho.com","avatar":null},"body":"Eric Sunshine:\n> On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote:\n>> ---\n> \n> Missing sign-off.\n> \n\nI have to inoculate the habit of signing off every time.\n>> diff --git a/Documentation/SubmittingPatches\n>> @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch\n>> is also\n>> encouraged. E.g. [PATCH/RFC] is often used when the patch is\n>> not ready to be applied but it is for discussion, [PATCH v2],\n>> [PATCH v3] etc. are often seen when you are sending an update to\n>> -what you have previously sent.\n>> +what you have previously sent. [PATCH/WIP] is often used when some\n> \n> Perhaps: /is often/can be/\n> \n>> +work is yet left to be done on the patch but you want to get the\n>> +review on the completed part of the patch.\n> \n> Maybe: s/review/feedback/\n> \n>> \"git format-patch\" command follows the best current practice to\n>> format the body of an e-mail message. At the beginning of the\n>> --\n>> 2.1.4\n\nI have done the required changes, now I should send another email with\ntag [PATCH v2] right?\n"}]}