{"thread":{"id":"41523","subject":"[PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings","startedAt":"2016-02-25T19:42:00Z","lastAt":"2016-02-25T20:28:06Z","messageCount":2,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"279372","messageId":"56CF5908.7090800@ramsayjones.plus.com","threadId":"41523","inReplyTo":null,"subject":"[PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-02-25T19:42:00Z","receivedAt":"2016-02-25T19:42:00Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll (err, one of your) 'sb/submodule-parallel-update'\nbranches, could you please squash this into the relevant patch.\n(ie. \"git submodule update: have a dedicated helper for cloning\", 23-02-2016).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/submodule--helper.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex f8cdce9..482a3cc 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -563,7 +563,7 @@ struct submodule_update_clone {\n \t/* index into 'list', the list of submodules to look into for cloning */\n \tint current;\n \tstruct module_list list;\n-\tint warn_if_uninitialized : 1;\n+\tunsigned int warn_if_uninitialized : 1;\n \t/* update parameter passed via commandline*/\n \tstruct submodule_update_strategy update;\n \t/* configuration parameters which are passed on to the children */\n@@ -575,7 +575,7 @@ struct submodule_update_clone {\n \t/* lines to be output */\n \tstruct string_list projectlines;\n \t/* If we want to stop as fast as possible and return an error */\n-\tint quickstop : 1;\n+\tunsigned int quickstop : 1;\n };\n #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \\\n \tSUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \\\n-- \n2.7.0\n"},{"id":"279379","messageId":"CAGZ79kb5YGyeEeW0LyA=1nX9+XkUPwxsFp6xQqRekvb9W2M2pA@mail.gmail.com","threadId":"41523","inReplyTo":"56CF5908.7090800@ramsayjones.plus.com","subject":"Re: [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-02-25T20:28:06Z","receivedAt":"2016-02-25T20:28:06Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Feb 25, 2016 at 11:42 AM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll (err, one of your) 'sb/submodule-parallel-update'\n> branches, could you please squash this into the relevant patch.\n> (ie. \"git submodule update: have a dedicated helper for cloning\", 23-02-2016).\n>\n> Thanks!\n\nIt's part of v17 already.\n\nThanks,\nStefan\n\n>\n> ATB,\n> Ramsay Jones\n>\n>  builtin/submodule--helper.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\n> index f8cdce9..482a3cc 100644\n> --- a/builtin/submodule--helper.c\n> +++ b/builtin/submodule--helper.c\n> @@ -563,7 +563,7 @@ struct submodule_update_clone {\n>         /* index into 'list', the list of submodules to look into for cloning */\n>         int current;\n>         struct module_list list;\n> -       int warn_if_uninitialized : 1;\n> +       unsigned int warn_if_uninitialized : 1;\n>         /* update parameter passed via commandline*/\n>         struct submodule_update_strategy update;\n>         /* configuration parameters which are passed on to the children */\n> @@ -575,7 +575,7 @@ struct submodule_update_clone {\n>         /* lines to be output */\n>         struct string_list projectlines;\n>         /* If we want to stop as fast as possible and return an error */\n> -       int quickstop : 1;\n> +       unsigned int quickstop : 1;\n>  };\n>  #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \\\n>         SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \\\n> --\n> 2.7.0\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"}]}