{"thread":{"id":"41521","subject":"[PATCH] refs: mark a file-local symbol as static","startedAt":"2016-02-25T19:28:45Z","lastAt":"2016-02-25T20:09:20Z","messageCount":2,"participants":["Ramsay Jones","David Turner"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"279367","messageId":"56CF55ED.9040906@ramsayjones.plus.com","threadId":"41521","inReplyTo":null,"subject":"[PATCH] refs: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-02-25T19:28:45Z","receivedAt":"2016-02-25T19:28:45Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi David,\n\nNo, you are not having flashbacks - you forgot to make the\nregister_ref_storage_backend() function static. ;-)\n\nBTW, I still have two symbols showing as exported but not used, namely:\n\n    $ diff nsc psc1\n    ...\n    32a35,36\n    > refs.o\t- resolve_ref_unsafe_submodule\n    > refs/files-backend.o\t- do_for_each_per_worktree_ref\n    $ \n\nBoth of these symbols are used by the lmdb backend, so I'm assuming that\nthey are part of the 'refs API' and will (may?) be used by other alternate\nreference backends. Is that the case?\n\n(I don't have the time right now to look at the code!)\n\nThanks!\n\nATB,\nRamsay Jones\n\n\n refs.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/refs.c b/refs.c\nindex 1c1d3ac..e448434 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -46,7 +46,7 @@ int ref_storage_backend_exists(const char *name)\n \treturn 0;\n }\n \n-void register_ref_storage_backend(struct ref_storage_be *be)\n+static void register_ref_storage_backend(struct ref_storage_be *be)\n {\n \tbe->next = refs_backends;\n \trefs_backends = be;\n-- \n2.7.0\n"},{"id":"279374","messageId":"1456430960.18017.49.camel@twopensource.com","threadId":"41521","inReplyTo":"56CF55ED.9040906@ramsayjones.plus.com","subject":"Re: [PATCH] refs: mark a file-local symbol as static","fromName":"David Turner","fromEmail":"dturner@twopensource.com","sentAt":"2016-02-25T20:09:20Z","receivedAt":"2016-02-25T20:09:20Z","isPatch":true,"sender":{"key":"novalis@novalis.org","avatar":"https://avatars.githubusercontent.com/u/77003?v=4"},"body":"On Thu, 2016-02-25 at 19:28 +0000, Ramsay Jones wrote:\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi David,\n> \n> No, you are not having flashbacks - you forgot to make the\n> register_ref_storage_backend() function static. ;-)\n\nOops!  Must have lost that in all of the rebasing!  Will fix, thanks.\n\n> BTW, I still have two symbols showing as exported but not used,\n> namely:\n> \n>     $ diff nsc psc1\n>     ...\n>     32a35,36\n>     > refs.o\t- resolve_ref_unsafe_submodule\n>     > refs/files-backend.o\t- do_for_each_per_worktree_ref\n>     $ \n> \n> Both of these symbols are used by the lmdb backend, so I'm assuming\n> that\n> they are part of the 'refs API' and will (may?) be used by other\n> alternate\n> reference backends. Is that the case?\n\nYes.\n"}]}