{"thread":{"id":"41477","subject":"[PATCH] refs: reduce the visibility of do_for_each_ref()","startedAt":"2016-02-23T00:39:13Z","lastAt":"2016-02-24T19:28:16Z","messageCount":2,"participants":["Ramsay Jones","David Turner"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"278955","messageId":"56CBAA31.7030809@ramsayjones.plus.com","threadId":"41477","inReplyTo":null,"subject":"[PATCH] refs: reduce the visibility of do_for_each_ref()","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-02-23T00:39:13Z","receivedAt":"2016-02-23T00:39:13Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi David,\n\nAgain, If you need to re-roll your 'dt/refs-backend-lmdb' branch ...\n\nThanks!\n\nATB,\nRamsay Jones\n\n refs.c | 16 ++++++++--------\n refs/refs-internal.h | 6 ------\n 2 files changed, 8 insertions(+), 14 deletions(-)\n\ndiff --git a/refs.c b/refs.c\nindex 337f110..bf70876 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -1236,6 +1236,14 @@ static int get_affected_refnames(struct ref_transaction *transaction,\n \treturn 0;\n }\n \n+static int do_for_each_ref(const char *submodule, const char *base,\n+\t\t\t each_ref_fn fn, int trim, int flags,\n+\t\t\t void *cb_data)\n+{\n+\treturn the_refs_backend->do_for_each_ref(submodule, base, fn, trim,\n+\t\t\t\t\t\t flags, cb_data);\n+}\n+\n int for_each_ref(each_ref_fn fn, void *cb_data)\n {\n \treturn do_for_each_ref(NULL, \"\", fn, 0, 0, cb_data);\n@@ -1501,14 +1509,6 @@ int resolve_gitlink_ref(const char *path, const char *refname,\n \treturn the_refs_backend->resolve_gitlink_ref(path, refname, sha1);\n }\n \n-int do_for_each_ref(const char *submodule, const char *base,\n-\t\t each_ref_fn fn, int trim, int flags,\n-\t\t void *cb_data)\n-{\n-\treturn the_refs_backend->do_for_each_ref(submodule, base, fn, trim,\n-\t\t\t\t\t\t flags, cb_data);\n-}\n-\n int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn,\n \t\t\t\tvoid *cb_data)\n {\ndiff --git a/refs/refs-internal.h b/refs/refs-internal.h\nindex ced6af4..4922e25 100644\n--- a/refs/refs-internal.h\n+++ b/refs/refs-internal.h\n@@ -227,12 +227,6 @@ int do_for_each_per_worktree_ref(const char *submodule, const char *base,\n \t\t\t\t each_ref_fn fn, int trim, int flags,\n \t\t\t\t void *cb_data);\n \n-/*\n- * The common backend for the for_each_*ref* functions\n- */\n-int do_for_each_ref(const char *submodule, const char *base,\n-\t\t each_ref_fn fn, int trim, int flags, void *cb_data);\n-\n /* refs backends */\n typedef int ref_init_db_fn(int shared, struct strbuf *err);\n typedef int ref_transaction_commit_fn(struct ref_transaction *transaction,\n-- \n2.7.0\n"},{"id":"279166","messageId":"1456342096.18017.2.camel@twopensource.com","threadId":"41477","inReplyTo":"56CBAA31.7030809@ramsayjones.plus.com","subject":"Re: [PATCH] refs: reduce the visibility of do_for_each_ref()","fromName":"David Turner","fromEmail":"dturner@twopensource.com","sentAt":"2016-02-24T19:28:16Z","receivedAt":"2016-02-24T19:28:16Z","isPatch":true,"sender":{"key":"novalis@novalis.org","avatar":"https://avatars.githubusercontent.com/u/77003?v=4"},"body":"Got it, thanks.\n\nOn Tue, 2016-02-23 at 00:39 +0000, Ramsay Jones wrote:\n> Signed-off-by: Ramsay Jones \n> ---\n> \n> Hi David,\n> \n> Again, If you need to re-roll your 'dt/refs-backend-lmdb' branch ...\n> \n> Thanks!\n> \n> ATB,\n> Ramsay Jones\n> \n> refs.c | 16 ++++++++--------\n> refs/refs-internal.h | 6 ------\n> 2 files changed, 8 insertions(+), 14 deletions(-)\n> \n> diff --git a/refs.c b/refs.c\n> index 337f110..bf70876 100644\n> --- a/refs.c\n> +++ b/refs.c\n> @@ -1236,6 +1236,14 @@ static int get_affected_refnames(struct\n> ref_transaction *transaction,\n> \treturn 0;\n> }\n> \n> +static int do_for_each_ref(const char *submodule, const char *base,\n> +\t\t\t each_ref_fn fn, int trim, int flags,\n> +\t\t\t void *cb_data)\n> +{\n> +\treturn the_refs_backend->do_for_each_ref(submodule, base,\n> fn, trim,\n> +\t\t\t\t\t\t flags, cb_data);\n> +}\n> +\n> int for_each_ref(each_ref_fn fn, void *cb_data)\n> {\n> \treturn do_for_each_ref(NULL, \"\", fn, 0, 0, cb_data);\n> @@ -1501,14 +1509,6 @@ int resolve_gitlink_ref(const char *path,\n> const char *refname,\n> \treturn the_refs_backend->resolve_gitlink_ref(path, refname,\n> sha1);\n> }\n> \n> -int do_for_each_ref(const char *submodule, const char *base,\n> -\t\t each_ref_fn fn, int trim, int flags,\n> -\t\t void *cb_data)\n> -{\n> -\treturn the_refs_backend->do_for_each_ref(submodule, base,\n> fn, trim,\n> -\t\t\t\t\t\t flags, cb_data);\n> -}\n> -\n> int for_each_reflog_ent_reverse(const char *refname,\n> each_reflog_ent_fn fn,\n> \t\t\t\tvoid *cb_data)\n> {\n> diff --git a/refs/refs-internal.h b/refs/refs-internal.h\n> index ced6af4..4922e25 100644\n> --- a/refs/refs-internal.h\n> +++ b/refs/refs-internal.h\n> @@ -227,12 +227,6 @@ int do_for_each_per_worktree_ref(const char\n> *submodule, const char *base,\n> \t\t\t\t each_ref_fn fn, int trim, int\n> flags,\n> \t\t\t\t void *cb_data);\n> \n> -/*\n> - * The common backend for the for_each_*ref* functions\n> - */\n> -int do_for_each_ref(const char *submodule, const char *base,\n> -\t\t each_ref_fn fn, int trim, int flags, void\n> *cb_data);\n> -\n> /* refs backends */\n> typedef int ref_init_db_fn(int shared, struct strbuf *err);\n> typedef int ref_transaction_commit_fn(struct ref_transaction\n> *transaction,\n"}]}