{"thread":{"id":"41467","subject":"contrib/diff-highlight: stop hard-coding perl location","startedAt":"2016-02-22T05:54:26Z","lastAt":"2016-02-22T07:13:23Z","messageCount":4,"participants":["Peter Dave Hello","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"278833","messageId":"CA+boQ6YWWkudgwC7zn-3UPWqfkw+uJZgwcBWcGvJDcCUakjzHA@mail.gmail.com","threadId":"41467","inReplyTo":null,"subject":"contrib/diff-highlight: stop hard-coding perl location","fromName":"Peter Dave Hello","fromEmail":"hsu@peterdavehello.org","sentAt":"2016-02-22T05:54:26Z","receivedAt":"2016-02-22T05:54:26Z","isPatch":false,"sender":{"key":"hsu@peterdavehello.org","avatar":"https://gravatar.com/avatar/f2a327ef8e09f04a35ebae7059f870b6281779441fad3d84b86ca9eef53e513b?d=mp&s=160"},"body":"From: Peter Dave Hello \n\nUse `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,\nthe util \"env\" can help located the \"perl\",\nso that it can work on FreeBSD and other platforms.\n\nSigned-off-by: Peter Dave Hello \n---\n contrib/diff-highlight/diff-highlight | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/diff-highlight/diff-highlight\nb/contrib/diff-highlight/diff-highlight\nindex ffefc31..b57b0fd 100755\n--- a/contrib/diff-highlight/diff-highlight\n+++ b/contrib/diff-highlight/diff-highlight\n@@ -1,4 +1,4 @@\n-#!/usr/bin/perl\n+#!/usr/bin/env perl\n\n use 5.008;\n use warnings FATAL => 'all';\n\n--\n"},{"id":"278834","messageId":"CAPig+cSE77JbD9CShrxnFsDLd9DrG9L15BSecERk_Qih9CMOig@mail.gmail.com","threadId":"41467","inReplyTo":"CA+boQ6YWWkudgwC7zn-3UPWqfkw+uJZgwcBWcGvJDcCUakjzHA@mail.gmail.com","subject":"Re: contrib/diff-highlight: stop hard-coding perl location","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-02-22T05:56:58Z","receivedAt":"2016-02-22T05:56:58Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello\n wrote:\n> From: Peter Dave Hello \n>\n> Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,\n> the util \"env\" can help located the \"perl\",\n> so that it can work on FreeBSD and other platforms.\n>\n> Signed-off-by: Peter Dave Hello \n\nBetter, thanks.\n\n> ---\n> contrib/diff-highlight/diff-highlight | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/diff-highlight/diff-highlight\n> b/contrib/diff-highlight/diff-highlight\n> index ffefc31..b57b0fd 100755\n> --- a/contrib/diff-highlight/diff-highlight\n> +++ b/contrib/diff-highlight/diff-highlight\n> @@ -1,4 +1,4 @@\n> -#!/usr/bin/perl\n> +#!/usr/bin/env perl\n>\n> use 5.008;\n> use warnings FATAL => 'all';\n"},{"id":"278836","messageId":"CA+boQ6bCH35hu9GfQY_P5bNZCdJ8Knr8zQ+S41RGF0z-JamVgw@mail.gmail.com","threadId":"41467","inReplyTo":"CAPig+cSE77JbD9CShrxnFsDLd9DrG9L15BSecERk_Qih9CMOig@mail.gmail.com","subject":"Re: contrib/diff-highlight: stop hard-coding perl location","fromName":"Peter Dave Hello","fromEmail":"hsu@peterdavehello.org","sentAt":"2016-02-22T06:49:57Z","receivedAt":"2016-02-22T06:49:57Z","isPatch":false,"sender":{"key":"hsu@peterdavehello.org","avatar":"https://gravatar.com/avatar/f2a327ef8e09f04a35ebae7059f870b6281779441fad3d84b86ca9eef53e513b?d=mp&s=160"},"body":"Hi Eric,\n\nThank you, is there anything I should do? Or I should just wait?\n\nBest,\nPeter\n\n2016/2/22 下午1:56於 \"Eric Sunshine\" 寫道：\n>\n> On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello\n> wrote:\n> > From: Peter Dave Hello \n> >\n> > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,\n> > the util \"env\" can help located the \"perl\",\n> > so that it can work on FreeBSD and other platforms.\n> >\n> > Signed-off-by: Peter Dave Hello \n>\n> Better, thanks.\n>\n> > ---\n> > contrib/diff-highlight/diff-highlight | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/contrib/diff-highlight/diff-highlight\n> > b/contrib/diff-highlight/diff-highlight\n> > index ffefc31..b57b0fd 100755\n> > --- a/contrib/diff-highlight/diff-highlight\n> > +++ b/contrib/diff-highlight/diff-highlight\n> > @@ -1,4 +1,4 @@\n> > -#!/usr/bin/perl\n> > +#!/usr/bin/env perl\n> >\n> > use 5.008;\n> > use warnings FATAL => 'all';\n"},{"id":"278837","messageId":"CAPig+cQp9H4K2D88bVxRRnwD_rY-8hROzVOp6aBCp9Y=Y6HwUA@mail.gmail.com","threadId":"41467","inReplyTo":"CA+boQ6bCH35hu9GfQY_P5bNZCdJ8Knr8zQ+S41RGF0z-JamVgw@mail.gmail.com","subject":"Re: contrib/diff-highlight: stop hard-coding perl location","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-02-22T07:13:23Z","receivedAt":"2016-02-22T07:13:23Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"[please don't top-post on this list]\n\nOn Mon, Feb 22, 2016 at 1:49 AM, Peter Dave Hello\n wrote:\n> Thank you, is there anything I should do? Or I should just wait?\n\nBest is to wait for other review comments, particularly from Junio.\nReviewers work at their own pace as time permits, so don't be\nsurprised if it takes days or a week or more. If you don't hear back\nfrom Junio after a week or two, and if you don't see that he has\nsilently picked it up in his \"pu\" branch and don't see mention of it\nin Junio's \"What's cooking\" email after that time, then it can be\nhelpful to send a reminder about the patch to the list.\n\n> Best,\n> Peter\n>\n> 2016/2/22 下午1:56於 \"Eric Sunshine\" 寫道：\n>>\n>> On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello\n>> wrote:\n>> > From: Peter Dave Hello \n>> >\n>> > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,\n>> > the util \"env\" can help located the \"perl\",\n>> > so that it can work on FreeBSD and other platforms.\n>> >\n>> > Signed-off-by: Peter Dave Hello \n>>\n>> Better, thanks.\n>>\n>> > ---\n>> > contrib/diff-highlight/diff-highlight | 2 +-\n>> > 1 file changed, 1 insertion(+), 1 deletion(-)\n>> >\n>> > diff --git a/contrib/diff-highlight/diff-highlight\n>> > b/contrib/diff-highlight/diff-highlight\n>> > index ffefc31..b57b0fd 100755\n>> > --- a/contrib/diff-highlight/diff-highlight\n>> > +++ b/contrib/diff-highlight/diff-highlight\n>> > @@ -1,4 +1,4 @@\n>> > -#!/usr/bin/perl\n>> > +#!/usr/bin/env perl\n>> >\n>> > use 5.008;\n>> > use warnings FATAL => 'all';\n>\n"}]}