{"thread":{"id":"41330","subject":"COPYING tabs vs whitespaces","startedAt":"2016-02-04T10:45:46Z","lastAt":"2016-02-09T19:25:23Z","messageCount":7,"participants":["Petr Stodulka","Junio C Hamano","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"277418","messageId":"56B32BDA.4010909@redhat.com","threadId":"41330","inReplyTo":null,"subject":"COPYING tabs vs whitespaces","fromName":"Petr Stodulka","fromEmail":"pstodulk@redhat.com","sentAt":"2016-02-04T10:45:46Z","receivedAt":"2016-02-04T10:45:46Z","isPatch":false,"sender":{"key":"pstodulk@redhat.com","avatar":"https://avatars.githubusercontent.com/u/1656374?v=4"},"body":"Hi,\n\nI found that license file COPYING is different as compared with http://www.gnu.org/licenses/gpl-2.0.txt\nIf I pass over with Linus's preamble, change is only about whitespaces - tabs vs. space.\nProbably it's minor non-essential change, but some projects do this change, so rather I ask about that.\n\n\n\nRegards,\nPetr\n\n"},{"id":"277446","messageId":"xmqqsi18i8xv.fsf@gitster.mtv.corp.google.com","threadId":"41330","inReplyTo":"56B32BDA.4010909@redhat.com","subject":"Re: COPYING tabs vs whitespaces","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-02-04T19:15:08Z","receivedAt":"2016-02-04T19:15:08Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Stodulka <pstodulk@redhat.com> writes:\n\n> I found that license file COPYING is different as compared with\n> http://www.gnu.org/licenses/gpl-2.0.txt If I pass over with\n> Linus's preamble, change is only about whitespaces - tabs\n> vs. space.  Probably it's minor non-essential change, but some\n> projects do this change, so rather I ask about that.\n\nInteresting.  I cannot quite connect \"some projects do this change\"\nand \"so rather I ask\".  Are you asking why this project changed it?\n\nAfter running \"diff\" between the two, I think the changes are only\non the indented section title lines, and \"git blame\" tells us that\nthe section title lines in the copy we have has always been that way\nsince Linus added to it at 075b845a (Add a COPYING notice, making it\nexplicit that the license is GPLv2., 2005-04-11).\n\nSo, perhaps the copy Linus got originally had leading runs of spaces\nthat are multiples-of-8-long unexpanded to leading tabs back then,\nor perhaps he did that unexpanding himself.\n"},{"id":"277717","messageId":"56B85ECE.4020607@redhat.com","threadId":"41330","inReplyTo":"xmqqsi18i8xv.fsf@gitster.mtv.corp.google.com","subject":"Re: COPYING tabs vs whitespaces","fromName":"Petr Stodulka","fromEmail":"pstodulk@redhat.com","sentAt":"2016-02-08T09:24:30Z","receivedAt":"2016-02-08T09:24:30Z","isPatch":false,"sender":{"key":"pstodulk@redhat.com","avatar":"https://avatars.githubusercontent.com/u/1656374?v=4"},"body":"\n\nOn 4.2.2016 20:15, Junio C Hamano wrote:\n> Petr Stodulka <pstodulk@redhat.com> writes:\n> \n>> I found that license file COPYING is different as compared with\n>> http://www.gnu.org/licenses/gpl-2.0.txt If I pass over with\n>> Linus's preamble, change is only about whitespaces - tabs\n>> vs. space.  Probably it's minor non-essential change, but some\n>> projects do this change, so rather I ask about that.\n> \n> Interesting.  I cannot quite connect \"some projects do this change\"\n> and \"so rather I ask\".  Are you asking why this project changed it?\n\nNope. I apologize for my czenglish. It means: From my colleagues I hear,\nthat some projects had same differences (tabs vs. spaces) in their copy\nof the license file and they make it later equivalent with the one in\ngnu.org. So I ask rather here / point out this difference, if you know\nabout that or you want to have same one.\n\nYes, I know, it's just about whitespaces.\n\nPetr.\n\n> \n> After running \"diff\" between the two, I think the changes are only\n> on the indented section title lines, and \"git blame\" tells us that\n> the section title lines in the copy we have has always been that way\n> since Linus added to it at 075b845a (Add a COPYING notice, making it\n> explicit that the license is GPLv2., 2005-04-11).\n> \n> So, perhaps the copy Linus got originally had leading runs of spaces\n> that are multiples-of-8-long unexpanded to leading tabs back then,\n> or perhaps he did that unexpanding himself.\n> \n> \n\n"},{"id":"277745","messageId":"xmqqfux39kmz.fsf@gitster.mtv.corp.google.com","threadId":"41330","inReplyTo":"56B85ECE.4020607@redhat.com","subject":"Re: COPYING tabs vs whitespaces","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-02-08T17:28:36Z","receivedAt":"2016-02-08T17:28:36Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Stodulka <pstodulk@redhat.com> writes:\n\n> On 4.2.2016 20:15, Junio C Hamano wrote:\n>> Petr Stodulka <pstodulk@redhat.com> writes:\n>> \n>>> I found that license file COPYING is different as compared with\n>>> http://www.gnu.org/licenses/gpl-2.0.txt If I pass over with\n>>> Linus's preamble, change is only about whitespaces - tabs\n>>> vs. space.  Probably it's minor non-essential change, but some\n>>> projects do this change, so rather I ask about that.\n>> \n>> Interesting.  I cannot quite connect \"some projects do this change\"\n>> and \"so rather I ask\".  Are you asking why this project changed it?\n>\n> Nope. I apologize for my czenglish. It means: From my colleagues I hear,\n> that some projects had same differences (tabs vs. spaces) in their copy\n> of the license file and they make it later equivalent with the one in\n> gnu.org.\n\nI'd guess that these projects (among which Linux kernel still has\nthese indentation the same as the copy we have) and we independently\nobtained the COPYING file from GNU in some past, and back then the\ncopy at GNU was indented that way--which later was changed.\n\nThe Wayback Machine supports this theory.\n\nhttps://web.archive.org/web/20070713225446/http://www.gnu.org/licenses/gpl-2.0.txt\n\ni.e. the FSF copy back in 2007-07 indented these section headers\nwith tabs, so those projects that obtained this copy would have\ntheir sections indented with tabs.\n\nAt 703601d6 (Update COPYING with GPLv2 with new FSF address,\n2010-01-15), we did a fresh update directly from the URL you cited\nabove to primarily replace the addresses of the FSF office.\n\nhttps://web.archive.org/web/20100105100239/http://www.gnu.org/licenses/gpl-2.0.txt\n\nmatches what we use (minus Linus's preamble, of course).\n\nThe file before that change was what Linus copied from Linux kernel\nproject.  The kernel project did their equivalent change at their\nb3358a11 ([PATCH] update FSF address in COPYING, 2005-09-10), and\nthe log message says http://www.gnu.org/licenses/gpl.txt was used.\n\nThe Wayback Machine agrees.\n\nhttps://web.archive.org/web/20050901115237/http://www.gnu.org/licenses/gpl.txt\n\ni.e. the FSF copy back in 2005-09 matches what the kernel uses\n(again, minus Linus's preamble).\n\n> So I ask rather here / point out this difference, if you know\n> about that or you want to have same one.\n\nSo the answers are:\n\n - No, I didn't personally know about the differences, and I suspect\n   nobody particularly cared.\n\n - Not really, unless the difference has more substance.  For an\n   example of an update with substance, the update we did in 2010\n   had not just the FSF address change but also updated the fully\n   spelled name of LGPL from Library to Lesser.\n\nYou may want to bug the kernel folks to update their copy; they\nstill spell it as Library General Public License.\n"},{"id":"277776","messageId":"56B91299.9060001@redhat.com","threadId":"41330","inReplyTo":"xmqqfux39kmz.fsf@gitster.mtv.corp.google.com","subject":"Re: COPYING tabs vs whitespaces","fromName":"Petr Stodulka","fromEmail":"pstodulk@redhat.com","sentAt":"2016-02-08T22:11:37Z","receivedAt":"2016-02-08T22:11:37Z","isPatch":false,"sender":{"key":"pstodulk@redhat.com","avatar":"https://avatars.githubusercontent.com/u/1656374?v=4"},"body":"\n\nOn 8.2.2016 18:28, Junio C Hamano wrote:\n> Petr Stodulka <pstodulk@redhat.com> writes:\n> \n>> On 4.2.2016 20:15, Junio C Hamano wrote:\n>>> Petr Stodulka <pstodulk@redhat.com> writes:\n>>>\n>>>> I found that license file COPYING is different as compared with\n>>>> http://www.gnu.org/licenses/gpl-2.0.txt If I pass over with\n>>>> Linus's preamble, change is only about whitespaces - tabs\n>>>> vs. space.  Probably it's minor non-essential change, but some\n>>>> projects do this change, so rather I ask about that.\n>>>\n>>> Interesting.  I cannot quite connect \"some projects do this change\"\n>>> and \"so rather I ask\".  Are you asking why this project changed it?\n>>\n>> Nope. I apologize for my czenglish. It means: From my colleagues I hear,\n>> that some projects had same differences (tabs vs. spaces) in their copy\n>> of the license file and they make it later equivalent with the one in\n>> gnu.org.\n> \n> I'd guess that these projects (among which Linux kernel still has\n> these indentation the same as the copy we have) and we independently\n> obtained the COPYING file from GNU in some past, and back then the\n> copy at GNU was indented that way--which later was changed.\n> \n> The Wayback Machine supports this theory.\n> \n> https://web.archive.org/web/20070713225446/http://www.gnu.org/licenses/gpl-2.0.txt\n> \n> i.e. the FSF copy back in 2007-07 indented these section headers\n> with tabs, so those projects that obtained this copy would have\n> their sections indented with tabs.\n> \n> At 703601d6 (Update COPYING with GPLv2 with new FSF address,\n> 2010-01-15), we did a fresh update directly from the URL you cited\n> above to primarily replace the addresses of the FSF office.\n> \n> https://web.archive.org/web/20100105100239/http://www.gnu.org/licenses/gpl-2.0.txt\n> \n> matches what we use (minus Linus's preamble, of course).\n> \n> The file before that change was what Linus copied from Linux kernel\n> project.  The kernel project did their equivalent change at their\n> b3358a11 ([PATCH] update FSF address in COPYING, 2005-09-10), and\n> the log message says http://www.gnu.org/licenses/gpl.txt was used.\n> \n> The Wayback Machine agrees.\n> \n> https://web.archive.org/web/20050901115237/http://www.gnu.org/licenses/gpl.txt\n> \n> i.e. the FSF copy back in 2005-09 matches what the kernel uses\n> (again, minus Linus's preamble).\n\nI have expected that license was copied correctly in the past from gnu.org,\nwhen same differences are in various projects. I just point out on another change.\n\nThank You for tip about web.archive.org - I really don't know about that web\nand it can be useful.\n\n> \n>> So I ask rather here / point out this difference, if you know\n>> about that or you want to have same one.\n> \n> So the answers are:\n> \n>  - No, I didn't personally know about the differences, and I suspect\n>    nobody particularly cared.\n> \n>  - Not really, unless the difference has more substance.  For an\n>    example of an update with substance, the update we did in 2010\n>    had not just the FSF address change but also updated the fully\n>    spelled name of LGPL from Library to Lesser.\n\nThank You for reponse.\n\n> \n> You may want to bug the kernel folks to update their copy; they\n> still spell it as Library General Public License.\n> \n\nEveryone can do that. I believe that someone report it already or at least\nconstult it. I write about this here because I should do that. When You\nknow about this difference in license in kernel, I believe that they know\nit too and they decide it is ok.\n\nRegards,\nPetr\n\n"},{"id":"277811","messageId":"CAGZ79kYaGDBunX8fFiEq0dD0Rq6vjZ3ttMnLZUmy3c7DhgfkOw@mail.gmail.com","threadId":"41330","inReplyTo":"56B91299.9060001@redhat.com","subject":"Re: COPYING tabs vs whitespaces","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-02-09T18:40:01Z","receivedAt":"2016-02-09T18:40:01Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"As a reference for this discussion,\nsee c376d96 in git.git or e00bfcbf04 in linux.git\nwhich deals with whitespaces in the developers certificate of origin.\n\nJust send a patch, I'd say.\n\nThanks,\nStefan\n"},{"id":"277814","messageId":"56BA3D23.8050506@redhat.com","threadId":"41330","inReplyTo":"CAGZ79kYaGDBunX8fFiEq0dD0Rq6vjZ3ttMnLZUmy3c7DhgfkOw@mail.gmail.com","subject":"Re: COPYING tabs vs whitespaces","fromName":"Petr Stodulka","fromEmail":"pstodulk@redhat.com","sentAt":"2016-02-09T19:25:23Z","receivedAt":"2016-02-09T19:25:23Z","isPatch":false,"sender":{"key":"pstodulk@redhat.com","avatar":"https://avatars.githubusercontent.com/u/1656374?v=4"},"body":"\n\nOn 9.2.2016 19:40, Stefan Beller wrote:\n> As a reference for this discussion,\n> see c376d96 in git.git or e00bfcbf04 in linux.git\n> which deals with whitespaces in the developers certificate of origin.\n> \n> Just send a patch, I'd say.\n> \n> Thanks,\n> Stefan\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n> \n\nJust patch makes from whole thread more and more absurd discussion, no offense.\nDon't matter if it is used or not. For me it's significant previous response from Junio.\n\nI am not familiar with git send-email, so:\n=======================[PATCH 1/2]====================================\nFrom b2509773edf7e886513f450cb8e215a87278cdfc Mon Sep 17 00:00:00 2001\nFrom: Petr Stodulka <pstodulk@redhat.com>\nDate: Tue, 9 Feb 2016 19:52:28 +0100\nSubject: [PATCH 1/2] COPYING: replace tabs by spaces in license file\n\nGPLv2 license file presented in gnu.org has replaced all tabs by spaces.\nUnify whitespaces to make equivalent files (except preamble).\n---\n COPYING | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)\n\ndiff --git a/COPYING b/COPYING\nindex 536e555..158a9b1 100644\n--- a/COPYING\n+++ b/COPYING\n@@ -19,15 +19,16 @@\n \n ----------------------------------------\n \n-\t\t    GNU GENERAL PUBLIC LICENSE\n-\t\t       Version 2, June 1991\n+\n+                    GNU GENERAL PUBLIC LICENSE\n+                       Version 2, June 1991\n \n  Copyright (C) 1989, 1991 Free Software Foundation, Inc.,\n  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA\n  Everyone is permitted to copy and distribute verbatim copies\n  of this license document, but changing it is not allowed.\n \n-\t\t\t    Preamble\n+                            Preamble\n \n   The licenses for most software are designed to take away your\n freedom to share and change it.  By contrast, the GNU General Public\n@@ -77,7 +78,7 @@ patent must be licensed for everyone's free use or not licensed at all.\n   The precise terms and conditions for copying, distribution and\n modification follow.\n \n-\t\t    GNU GENERAL PUBLIC LICENSE\n+                    GNU GENERAL PUBLIC LICENSE\n    TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION\n \n   0. This License applies to any program or other work which contains\n@@ -276,7 +277,7 @@ make exceptions for this.  Our decision will be guided by the two goals\n of preserving the free status of all derivatives of our free software and\n of promoting the sharing and reuse of software generally.\n \n-\t\t\t    NO WARRANTY\n+                            NO WARRANTY\n \n   11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY\n FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN\n@@ -298,9 +299,9 @@ YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER\n PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE\n POSSIBILITY OF SUCH DAMAGES.\n \n-\t\t     END OF TERMS AND CONDITIONS\n+                     END OF TERMS AND CONDITIONS\n \n-\t    How to Apply These Terms to Your New Programs\n+            How to Apply These Terms to Your New Programs\n \n   If you develop a new program, and you want it to be of the greatest\n possible use to the public, the best way to achieve this is to make it\n-- \n2.4.3\n\n\n=======================[PATCH 2/2]====================================\nFrom 5a7bfe0b05f35238c7bc8d2680b168ef729d0e91 Mon Sep 17 00:00:00 2001\nFrom: Petr Stodulka <pstodulk@redhat.com>\nDate: Tue, 9 Feb 2016 20:08:44 +0100\nSubject: [PATCH 2/2] Unify tabs and spaces in preamble of COPYING file\n\n---\n COPYING | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/COPYING b/COPYING\nindex 158a9b1..bc404d9 100644\n--- a/COPYING\n+++ b/COPYING\n@@ -9,13 +9,13 @@\n  decision, you might note so in your copyright message, ie something\n  like\n \n-\tThis file is licensed under the GPL v2, or a later version\n-\tat the discretion of Linus.\n+    This file is licensed under the GPL v2, or a later version\n+    at the discretion of Linus.\n \n   might avoid issues. But we can also just decide to synchronize and\n   contact all copyright holders on record if/when the occasion arises.\n \n-\t\t\tLinus Torvalds\n+            Linus Torvalds\n \n ----------------------------------------\n \n-- \n2.4.3\n\n\n"}]}