{"thread":{"id":"41324","subject":"[PATCH] gitk: Follow themed bgcolor in help dialogs","startedAt":"2016-02-04T02:32:19Z","lastAt":"2016-03-19T06:57:15Z","messageCount":2,"participants":["Guillermo S. Romero","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"277360","messageId":"20160204023219.GA27647@fortress.battleship","threadId":"41324","inReplyTo":null,"subject":"[PATCH] gitk: Follow themed bgcolor in help dialogs","fromName":"Guillermo S. Romero","fromEmail":"gsromero@infernal-iceberg.com","sentAt":"2016-02-04T02:32:19Z","receivedAt":"2016-02-04T02:32:19Z","isPatch":true,"sender":{"key":"gsromero@infernal-iceberg.com","avatar":null},"body":"Make Help > About & Key bindings dialogs readable if theme\nhas changed font color to something incompatible with white.\n\nSigned-off-by: Guillermo S. Romero <gsromero@infernal-iceberg.com>\n---\n\nHi:\n\nFound more places where themable colors makes things unreadable\nbecause not everything adapted to the changed style.\n\nGSR\n \nPS: Not subscribed to git@vger, so remember to CC: me.\n \n\n gitk | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 5f1255c..805a1c7 100755\n--- a/gitk\n+++ b/gitk\n@@ -3021,7 +3021,7 @@ proc bindall {event action} {\n }\n \n proc about {} {\n-    global uifont NS\n+    global bgcolor NS\n     set w .about\n     if {[winfo exists $w]} {\n \traise $w\n@@ -3036,7 +3036,7 @@ Gitk - a commit viewer for git\n Copyright \\u00a9 2005-2014 Paul Mackerras\n \n Use and redistribute under the terms of the GNU General Public License\"] \\\n-\t    -justify center -aspect 400 -border 2 -bg white -relief groove\n+\t    -justify center -aspect 400 -border 2 -bg $bgcolor -relief groove\n     pack $w.m -side top -fill x -padx 2 -pady 2\n     ${NS}::button $w.ok -text [mc \"Close\"] -command \"destroy $w\" -default active\n     pack $w.ok -side bottom\n@@ -3047,7 +3047,7 @@ Use and redistribute under the terms of the GNU General Public License\"] \\\n }\n \n proc keys {} {\n-    global NS\n+    global bgcolor NS\n     set w .keys\n     if {[winfo exists $w]} {\n \traise $w\n@@ -3103,7 +3103,7 @@ proc keys {} {\n [mc \"<%s-minus>\tDecrease font size\" $M1T]\n [mc \"<F5>\t\tUpdate\"]\n \" \\\n-\t    -justify left -bg white -border 2 -relief groove\n+\t    -justify left -bg $bgcolor -border 2 -relief groove\n     pack $w.m -side top -fill both -padx 2 -pady 2\n     ${NS}::button $w.ok -text [mc \"Close\"] -command \"destroy $w\" -default active\n     bind $w <Key-Escape> [list destroy $w]\n-- \n2.7.0.rc3\n"},{"id":"281216","messageId":"20160319065715.GF27126@fergus.ozlabs.ibm.com","threadId":"41324","inReplyTo":"20160204023219.GA27647@fortress.battleship","subject":"Re: [PATCH] gitk: Follow themed bgcolor in help dialogs","fromName":"Paul Mackerras","fromEmail":"paulus@ozlabs.org","sentAt":"2016-03-19T06:57:15Z","receivedAt":"2016-03-19T06:57:15Z","isPatch":true,"sender":{"key":"paulus@ozlabs.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Thu, Feb 04, 2016 at 03:32:19AM +0100, Guillermo S. Romero wrote:\n> Make Help > About & Key bindings dialogs readable if theme\n> has changed font color to something incompatible with white.\n> \n> Signed-off-by: Guillermo S. Romero <gsromero@infernal-iceberg.com>\n\nThanks, applied.\nPaul.\n"}]}