{"thread":{"id":"4130","subject":"[PATCH] Ensure author information is set before asking for commit message.","startedAt":"2006-05-14T01:51:15Z","lastAt":"2006-05-14T03:09:32Z","messageCount":3,"participants":["Sean","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"19900","messageId":"BAYC1-PASMTP10DC791E7560155D9E71F4AEA20@CEZ.ICE","threadId":"4130","inReplyTo":null,"subject":"[PATCH] Ensure author information is set before asking for commit message.","fromName":"Sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2006-05-14T01:51:15Z","receivedAt":"2006-05-14T01:51:15Z","isPatch":true,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"It's better to find out you need to set your author information\nproperly before you enter a long commit message.\n\nSigned-off-by: Sean Estabrooks <seanlkml@sympatico.ca>\n\n---\n\n git-commit.sh |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\nae880db6fc12a0774c25925abbcc353fe6c9e46f\ndiff --git a/git-commit.sh b/git-commit.sh\nindex 26cd7ca..866ed6c 100755\n--- a/git-commit.sh\n+++ b/git-commit.sh\n@@ -640,6 +640,7 @@ case \"$no_edit\" in\n \t\texit 1\n \t\t;;\n \tesac\n+\tgit-var GIT_AUTHOR_IDENT > /dev/null  || die\n \t${VISUAL:-${EDITOR:-vi}} \"$GIT_DIR/COMMIT_EDITMSG\"\n \t;;\n esac\n-- \n1.3.2.g260bd\n"},{"id":"19901","messageId":"7vlkt5s4yw.fsf@assigned-by-dhcp.cox.net","threadId":"4130","inReplyTo":"BAYC1-PASMTP10DC791E7560155D9E71F4AEA20@CEZ.ICE","subject":"Re: [PATCH] Ensure author information is set before asking for commit message.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-14T02:41:27Z","receivedAt":"2006-05-14T02:41:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sean <seanlkml@sympatico.ca> writes:\n\n> It's better to find out you need to set your author information\n> properly before you enter a long commit message.\n>\n> Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>\n\nMakes sense but I suspect you would want COMMITTER not AUTHOR.\nImagine you pulled from somewhere else and it conflicted,\nrequiring you to hand resolve and then run git-commit.\n"},{"id":"19902","messageId":"BAYC1-PASMTP06C5870DB0764F7F3284A3AEA20@CEZ.ICE","threadId":"4130","inReplyTo":"7vlkt5s4yw.fsf@assigned-by-dhcp.cox.net","subject":"[PATCH] Ensure author & committer before asking for commit message.","fromName":"Sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2006-05-14T03:09:32Z","receivedAt":"2006-05-14T03:09:32Z","isPatch":true,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"\nIt's better to find out you need to fix your author and\ncommitter information before you enter a long commit message.\n\nSigned-off-by: Sean Estabrooks <seanlkml@sympatico.ca>\n\n---\n\nOn Sat, 13 May 2006 19:41:27 -0700\nJunio C Hamano <junkio@cox.net> wrote:\n\n> Makes sense but I suspect you would want COMMITTER not AUTHOR.\n> Imagine you pulled from somewhere else and it conflicted,\n> requiring you to hand resolve and then run git-commit.\n\nHmm.. It seems that both sets of environment variables must be \nproperly set before commit will succeed?  For some reason I thought \nthat if AUTHOR was properly set it would be used as the committer too\nwhen the GIT_COMMITTER_* environment variables weren't set.  All I\never use are the config user.email/name variables which do work for\nboth author and committer.\n\nBut it looks like we have to test both variables before proceeding.\n\n git-commit.sh |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\n\n801ac3c2e4ec7fd0dd91975800897f30938b4e68\ndiff --git a/git-commit.sh b/git-commit.sh\nindex 26cd7ca..6ef1a9d 100755\n--- a/git-commit.sh\n+++ b/git-commit.sh\n@@ -640,6 +640,8 @@ case \"$no_edit\" in\n \t\texit 1\n \t\t;;\n \tesac\n+\tgit-var GIT_AUTHOR_IDENT > /dev/null  || die\n+\tgit-var GIT_COMMITTER_IDENT > /dev/null  || die\n \t${VISUAL:-${EDITOR:-vi}} \"$GIT_DIR/COMMIT_EDITMSG\"\n \t;;\n esac\n-- \n1.3.2.gd9a4\n"}]}