{"thread":{"id":"4125","subject":"[RFC] qgit with tabs","startedAt":"2006-05-13T10:44:35Z","lastAt":"2006-05-20T11:46:34Z","messageCount":10,"participants":["Marco Costalba","Pavel Roskin","Paul Mackerras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"19876","messageId":"e5bfff550605130344n75e3e55eq533c49fc2a4f5483@mail.gmail.com","threadId":"4125","inReplyTo":null,"subject":"[RFC] qgit with tabs","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-05-13T10:44:35Z","receivedAt":"2006-05-13T10:44:35Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Hi all,\n\n   I have pushed some patches that add tabs to qgit UI.\n\nI don't expect a new release any time soon, but I am interested to\nhear comments, especially on the usability front, so to be able to\nsteer new development in advance.\n\nWith new UI I found myself more and more using keyboard bindings\ninstead of mouse:\n\n- r, p, f to switch to revisions list, patch and file views respectively\n\n- t to toggle tree view\n\n- s to toggle split view (very useful IMHO)\n\n\nNOTE:\nDue to some repacking on a dumb host probably you need to re-clone:\n\ngit clone http://digilander.libero.it/mcostalba/scm/qgit.git\ncd qgit\nautoreconf -i\n./configure\nmake\nmake install-strip\n\n\n          Marco\n"},{"id":"19877","messageId":"20060513070726.qa5ssccws80go044@webmail.spamcop.net","threadId":"4125","inReplyTo":"e5bfff550605130344n75e3e55eq533c49fc2a4f5483@mail.gmail.com","subject":"Re: [RFC] qgit with tabs","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-05-13T11:07:26Z","receivedAt":"2006-05-13T11:07:26Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello, Marco!\n\nQuoting Marco Costalba <mcostalba@gmail.com>:\n\n>    I have pushed some patches that add tabs to qgit UI.\n\nThat's _really_ appreciated.\n\n> I don't expect a new release any time soon, but I am interested to\n> hear comments, especially on the usability front, so to be able to\n> steer new development in advance.\n\nJust one thing for now.  Double click on a file on the \"rev list\" tab should\nshow the patch (what Ctrl-P would do), not the whole file.  That would be more\ncompatible with gitk, and it's what I normally need if I just browse the latest\nchanges in the rev list.\n\n> With new UI I found myself more and more using keyboard bindings\n> instead of mouse:\n>\n> - r, p, f to switch to revisions list, patch and file views respectively\n>\n> - t to toggle tree view\n>\n> - s to toggle split view (very useful IMHO)\n\nThe later is very useful, but a bit hard to discover without checking the menu. \nMaybe it should be a button in the toolbar.\n\n> NOTE:\n> Due to some repacking on a dumb host probably you need to re-clone:\n\nI don't think re-clone should be needed.  I didn't re-clone, yet I could update.\n\nOn the other hand, that host sometimes returns something that crashes\ngit-http-fetch.  Sorry, no time to debug it right now.  I guess it returns\nerror messages in HTML without reporting error 404, but git-http-fetch should\nbe more robust anyway.\n\n--\nRegards,\nPavel Roskin\n"},{"id":"19878","messageId":"e5bfff550605130431w417b8aacl2b17cf5655b46f31@mail.gmail.com","threadId":"4125","inReplyTo":"20060513070726.qa5ssccws80go044@webmail.spamcop.net","subject":"Re: [RFC] qgit with tabs","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-05-13T11:31:12Z","receivedAt":"2006-05-13T11:31:12Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Hi Pavel,\n\n>\n> Just one thing for now.  Double click on a file on the \"rev list\" tab should\n> show the patch (what Ctrl-P would do), not the whole file.  That would be more\n> compatible with gitk, and it's what I normally need if I just browse the latest\n> changes in the rev list.\n>\n\nWell, double click activates the current top entry in context menu.\n\nThis behaviour has not changed from past releases. To show the patch\nperhaps you may, as always, double click on the selected revision, in\nrevisions list.\n\nFWIK gitk does not have a file content viewer.\n\nThanks\nMarco\n"},{"id":"19889","messageId":"20060513142840.39c0kwkw84g8g88g@webmail.spamcop.net","threadId":"4125","inReplyTo":"e5bfff550605130431w417b8aacl2b17cf5655b46f31@mail.gmail.com","subject":"Re: [RFC] qgit with tabs","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-05-13T18:28:40Z","receivedAt":"2006-05-13T18:28:40Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Quoting Marco Costalba <mcostalba@gmail.com>:\n\n> > Just one thing for now.  Double click on a file on the \"rev list\" tab\n> should\n> > show the patch (what Ctrl-P would do), not the whole file.  That would be\n> more\n> > compatible with gitk, and it's what I normally need if I just browse the\n> latest\n> > changes in the rev list.\n> >\n>\n> Well, double click activates the current top entry in context menu.\n\nThat's a good thing.  But I think that the top entry should be different.\n\n> This behaviour has not changed from past releases.\n\nI know.  But as the more prominent issues are sorted out, minor things become\nmore visible.\n\n> To show the patch\n> perhaps you may, as always, double click on the selected revision, in\n> revisions list.\n\nSure, but I often want to see what changed in a particular file.\n\nAnd of course I only mean the subwindow dislaying the files affected by the\npatch.  The file tree should still have file annotation bound to the double\nclick.\n\n> FWIK gitk does not have a file content viewer.\n\nThat's true.  The reason may be because changes are more interesing than the\nwhole file in the context of git (as opposed to the context of an editor or a\ncompiler).\n\n--\nRegards,\nPavel Roskin\n"},{"id":"19896","messageId":"e5bfff550605131538u63b87002o3e9b5542c0e15bf7@mail.gmail.com","threadId":"4125","inReplyTo":"20060513142840.39c0kwkw84g8g88g@webmail.spamcop.net","subject":"Re: [RFC] qgit with tabs","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-05-13T22:38:46Z","receivedAt":"2006-05-13T22:38:46Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Hi Pavel,\n\n>\n> Sure, but I often want to see what changed in a particular file.\n>\n> And of course I only mean the subwindow dislaying the files affected by the\n> patch.  The file tree should still have file annotation bound to the double\n> click.\n>\n\nI understand your reasons, but I have some doubts about this change:\n\n1) The context menu is currently shared between the tree and the file\nlist, splitting in two subcases adds some crap to the code (ok, this\nis not the real doubt ;-)  )\n\n2) The context menu is currently shared between the file list in main\nview and the file list in patch view. The file list in patch view, of\ncourse, does not need a double click, a single click is enough to\nselect corresponding file's diff. In main view you currently need a\nsingle click _plus_  a 'p' key press to change the view. So we should\nadd another subcase here.\n\n3) It is true that double clicking on a revision switch to the patch\nview at top position (if no file is selected), but it's also true that\nyou can select the file's related diff directly in patch view with a\nsingle click on the right column file list.\n\n4) Once a file is selected, as example with a single click, you can\nbrowse through rev list and the selection is preserved, it means that\nanytime you switch to patch view page the content will be _already_\ncentered on the correct diff.\n\n5) Double clicking on a file name is currently the only way (without\nopening the menu) to show the file content tab, with your suggested\nchange we will have two ways to switch to patch view and no one to\nswitch to file view.\n\n6) Selecting from the tree view is very slow if you have to search for\nthe correct file, it is fast only if the file is already selected, but\nin this case is faster to press 'p' key ;-)\n\n\n       Marco\n"},{"id":"20194","messageId":"1147908094.32050.22.camel@dv","threadId":"4125","inReplyTo":"e5bfff550605131538u63b87002o3e9b5542c0e15bf7@mail.gmail.com","subject":"Re: [RFC] qgit with tabs","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-05-17T23:21:34Z","receivedAt":"2006-05-17T23:21:34Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hi, Marco!\n\nOn Sun, 2006-05-14 at 00:38 +0200, Marco Costalba wrote:\n> Hi Pavel,\n> \n> >\n> > Sure, but I often want to see what changed in a particular file.\n> >\n> > And of course I only mean the subwindow dislaying the files affected by the\n> > patch.  The file tree should still have file annotation bound to the double\n> > click.\n> >\n> \n> I understand your reasons, but I have some doubts about this change:\n> \n> 1) The context menu is currently shared between the tree and the file\n> list, splitting in two subcases adds some crap to the code (ok, this\n> is not the real doubt ;-)  )\n\nActually, \"Get revision/patch\" and \"External diff\" shouldn't be in the\npopup used in the tree, or at least they should only appear for the\nfiles affected by the currently selected patch.\n\n\"External diff\" may be a good candidate for the toolbar if you find out\nhow to feed a multi-file patch to kompare (I guess you'll need two\ntemporary directories populated with differing files).\n\n> 2) The context menu is currently shared between the file list in main\n> view and the file list in patch view. The file list in patch view, of\n> course, does not need a double click, a single click is enough to\n> select corresponding file's diff. In main view you currently need a\n> single click _plus_  a 'p' key press to change the view. So we should\n> add another subcase here.\n\nYes.  It should be perfectly OK to have different menus for different\ncontexts.\n\n> 3) It is true that double clicking on a revision switch to the patch\n> view at top position (if no file is selected), but it's also true that\n> you can select the file's related diff directly in patch view with a\n> single click on the right column file list.\n\nThat's true.  But I still find myself double clicking on the file in the\nfile list and expecting to see the patch for the file.  It's very\nnatural.  \n\nIf I see the list of the recent patches, I see the descriptions and the\naffected files.  If I'm interested to see what changed in the file, it's\nonly natural for me to double-click the corresponding entry in the list.\n\nFull history of a file is a much more advanced operation, and it's not\nsomething I need to do often while browsing recently merged changes.\n\n> 4) Once a file is selected, as example with a single click, you can\n> browse through rev list and the selection is preserved, it means that\n> anytime you switch to patch view page the content will be _already_\n> centered on the correct diff.\n\nThat's useful, but irrelevant.\n\n> 5) Double clicking on a file name is currently the only way (without\n> opening the menu) to show the file content tab, with your suggested\n> change we will have two ways to switch to patch view and no one to\n> switch to file view.\n\nThat's a good thing.  That's called consistency.  git is about patches,\nso showing the patches should be the default whenever practical.\n\nThe file viewer is a great feature, and it should be discoverable, but\nit doesn't mean it should pop up when users expect something else.\n\n> \n> 6) Selecting from the tree view is very slow if you have to search for\n> the correct file, it is fast only if the file is already selected, but\n> in this case is faster to press 'p' key ;-)\n\nThat's true, but we are talking about double click behavior.  Every\nreasonable person can learn shortcuts, but the software should work\npredictably even if operated by the mouse.\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"20291","messageId":"e5bfff550605190954w4baab5fcj4f48a539bd120364@mail.gmail.com","threadId":"4125","inReplyTo":"1147908094.32050.22.camel@dv","subject":"Re: [RFC] qgit with tabs","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-05-19T16:54:24Z","receivedAt":"2006-05-19T16:54:24Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 5/18/06, Pavel Roskin <proski@gnu.org> wrote:\n>\n> > 3) It is true that double clicking on a revision switch to the patch\n> > view at top position (if no file is selected), but it's also true that\n> > you can select the file's related diff directly in patch view with a\n> > single click on the right column file list.\n>\n> That's true.  But I still find myself double clicking on the file in the\n> file list and expecting to see the patch for the file.  It's very\n> natural.\n>\n> If I see the list of the recent patches, I see the descriptions and the\n> affected files.  If I'm interested to see what changed in the file, it's\n> only natural for me to double-click the corresponding entry in the list.\n>\n\nOk. patch pushed.\n\nPerhaps I'm not using gitk a lot so I still have to get used to this\nnew file double clicking behaviour.\n\n  Marco\n"},{"id":"20316","messageId":"20060520054201.11po8xb4gwwowo0k@webmail.spamcop.net","threadId":"4125","inReplyTo":"e5bfff550605190954w4baab5fcj4f48a539bd120364@mail.gmail.com","subject":"Re: [RFC] qgit with tabs","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-05-20T09:42:01Z","receivedAt":"2006-05-20T09:42:01Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Quoting Marco Costalba <mcostalba@gmail.com>:\n\n> > If I see the list of the recent patches, I see the descriptions and the\n> > affected files.  If I'm interested to see what changed in the file, it's\n> > only natural for me to double-click the corresponding entry in the list.\n> >\n>\n> Ok. patch pushed.\n\nWorking fine here.  Thank you!\n\n--\nRegards,\nPavel Roskin\n"},{"id":"20318","messageId":"17518.61262.957027.606886@cargo.ozlabs.ibm.com","threadId":"4125","inReplyTo":"e5bfff550605130431w417b8aacl2b17cf5655b46f31@mail.gmail.com","subject":"Re: [RFC] qgit with tabs","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2006-05-20T10:28:30Z","receivedAt":"2006-05-20T10:28:30Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Marco Costalba writes:\n\n> FWIK gitk does not have a file content viewer.\n\nIt does now, actually.\n\nPaul.\n"},{"id":"20319","messageId":"e5bfff550605200446g75d9fd0clc68215e2d44671ed@mail.gmail.com","threadId":"4125","inReplyTo":"17518.61262.957027.606886@cargo.ozlabs.ibm.com","subject":"Re: [RFC] qgit with tabs","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-05-20T11:46:34Z","receivedAt":"2006-05-20T11:46:34Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 5/20/06, Paul Mackerras <paulus@samba.org> wrote:\n> Marco Costalba writes:\n>\n> > FWIK gitk does not have a file content viewer.\n>\n> It does now, actually.\n>\n> Paul.\n>\n\nYes, I've checked the current gitk version only _after_ email was sent.\n\nSorry for this.\n\n   Marco\n"}]}