{"thread":{"id":"41209","subject":"[PATCH 1/1] contrib/subtree: Make testing easier","startedAt":"2016-01-17T23:47:59Z","lastAt":"2016-01-20T19:28:33Z","messageCount":2,"participants":["David Greene","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"276263","messageId":"44704afe6f728263b5200da2b343783a5a209eca.1453074427.git.greened@obbligato.org","threadId":"41209","inReplyTo":null,"subject":"[PATCH 1/1] contrib/subtree: Make testing easier","fromName":"David Greene","fromEmail":"greened@obbligato.org","sentAt":"2016-01-17T23:47:59Z","receivedAt":"2016-01-17T23:47:59Z","isPatch":true,"sender":{"key":"greened@obbligato.org","avatar":"https://avatars.githubusercontent.com/u/5291869?v=4"},"body":"From: David A. Greene <greened@obbligato.org>\n\nAdd some Makefile dependencies to ensure an updated git-subtree\ngets copied to the main area before testing begins.\n\nSigned-off-by: David A. Greene <greened@obbligato.org>\n---\n\nNotes:\n    v1 - Initial patch\n\n contrib/subtree/Makefile | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex 3071baf..6afa9aa 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -37,6 +37,7 @@ GIT_SUBTREE_DOC := git-subtree.1\n GIT_SUBTREE_XML := git-subtree.xml\n GIT_SUBTREE_TXT := git-subtree.txt\n GIT_SUBTREE_HTML := git-subtree.html\n+GIT_SUBTREE_TEST := ../../git-subtree\n \n all:: $(GIT_SUBTREE)\n \n@@ -71,7 +72,10 @@ $(GIT_SUBTREE_HTML): $(GIT_SUBTREE_TXT)\n \t$(ASCIIDOC) -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \\\n \t\t-agit_version=$(GIT_VERSION) $^\n \n-test:\n+$(GIT_SUBTREE_TEST): $(GIT_SUBTREE)\n+\tcp $< $@\n+\n+test: $(GIT_SUBTREE_TEST)\n \t$(MAKE) -C t/ test\n \n clean:\n-- \n2.6.1\n"},{"id":"276444","messageId":"xmqqvb6o59um.fsf@gitster.mtv.corp.google.com","threadId":"41209","inReplyTo":"44704afe6f728263b5200da2b343783a5a209eca.1453074427.git.greened@obbligato.org","subject":"Re: [PATCH 1/1] contrib/subtree: Make testing easier","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-01-20T19:28:33Z","receivedAt":"2016-01-20T19:28:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David Greene <greened@obbligato.org> writes:\n\n> From: David A. Greene <greened@obbligato.org>\n>\n> Add some Makefile dependencies to ensure an updated git-subtree\n> gets copied to the main area before testing begins.\n>\n> Signed-off-by: David A. Greene <greened@obbligato.org>\n> ---\n>\n> Notes:\n>     v1 - Initial patch\n\nThis looks OK to me, but does this change make what's written in\ncontrib/subtree/INSTALL somewhat stale?\n\n>\n>  contrib/subtree/Makefile | 6 +++++-\n>  1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\n> index 3071baf..6afa9aa 100644\n> --- a/contrib/subtree/Makefile\n> +++ b/contrib/subtree/Makefile\n> @@ -37,6 +37,7 @@ GIT_SUBTREE_DOC := git-subtree.1\n>  GIT_SUBTREE_XML := git-subtree.xml\n>  GIT_SUBTREE_TXT := git-subtree.txt\n>  GIT_SUBTREE_HTML := git-subtree.html\n> +GIT_SUBTREE_TEST := ../../git-subtree\n>  \n>  all:: $(GIT_SUBTREE)\n>  \n> @@ -71,7 +72,10 @@ $(GIT_SUBTREE_HTML): $(GIT_SUBTREE_TXT)\n>  \t$(ASCIIDOC) -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \\\n>  \t\t-agit_version=$(GIT_VERSION) $^\n>  \n> -test:\n> +$(GIT_SUBTREE_TEST): $(GIT_SUBTREE)\n> +\tcp $< $@\n> +\n> +test: $(GIT_SUBTREE_TEST)\n>  \t$(MAKE) -C t/ test\n>  \n>  clean:\n"}]}