{"thread":{"id":"4118","subject":"[Patch] git-cvsimport: tiny fix","startedAt":"2006-05-10T17:37:04Z","lastAt":"2006-05-18T13:29:57Z","messageCount":4,"participants":["Elrond","Junio C Hamano","Martin Langhoff"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"19838","messageId":"20060510173703.GA10335@memak.tu-darmstadt.de","threadId":"4118","inReplyTo":null,"subject":"[Patch] git-cvsimport: tiny fix","fromName":"Elrond","fromEmail":"elrond+kernel.org@samba-tng.org","sentAt":"2006-05-10T17:37:04Z","receivedAt":"2006-05-10T17:37:04Z","isPatch":true,"sender":{"key":"elrond+kernel.org@samba-tng.org","avatar":null},"body":"git-cvsimport: Handle \"Removed\" from pserver\n\nSometimes the pserver says \"Removed\" instead of\n\"Remove-entry\".\n\nSigned-off-by: Elrond <elrond+kernel.org@samba-tng.org>\n---\nHi,\n\nAt least the above happened to me on a repository I tried\nto convert.\nWithout the patch, it just die(\"Unknown: Removed ...\")s.\n\n\n    Elrond\n\n--- git-cvsimport.perl\n+++ git-cvsimport.perl\n@@ -350,7 +350,7 @@ sub _line {\n \t\t\t\treturn $res;\n \t\t\t} elsif($line =~ s/^E //) {\n \t\t\t\t# print STDERR \"S: $line\\n\";\n-\t\t\t} elsif($line =~ /^Remove-entry /i) {\n+\t\t\t} elsif($line =~ /^(Remove-entry|Removed) /i) {\n \t\t\t\t$line = $self->readline(); # filename\n \t\t\t\t$line = $self->readline(); # OK\n \t\t\t\tchomp $line;\n"},{"id":"20169","messageId":"7vd5eccvns.fsf@assigned-by-dhcp.cox.net","threadId":"4118","inReplyTo":"20060510173703.GA10335@memak.tu-darmstadt.de","subject":"Re: [Patch] git-cvsimport: tiny fix","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-17T19:12:55Z","receivedAt":"2006-05-17T19:12:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elrond <elrond+kernel.org@samba-tng.org> writes:\n\n> git-cvsimport: Handle \"Removed\" from pserver\n>\n> Sometimes the pserver says \"Removed\" instead of\n> \"Remove-entry\".\n>\n> Signed-off-by: Elrond <elrond+kernel.org@samba-tng.org>\n> ---\n> Hi,\n>\n> At least the above happened to me on a repository I tried\n> to convert.\n> Without the patch, it just die(\"Unknown: Removed ...\")s.\n\nCould somebody who actually works with CVS import Ack this?\nPretty please?\n"},{"id":"20203","messageId":"46a038f90605172153mac96f40id9a50d2f29c75915@mail.gmail.com","threadId":"4118","inReplyTo":"7vd5eccvns.fsf@assigned-by-dhcp.cox.net","subject":"Re: [Patch] git-cvsimport: tiny fix","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2006-05-18T04:53:56Z","receivedAt":"2006-05-18T04:53:56Z","isPatch":true,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 5/18/06, Junio C Hamano <junkio@cox.net> wrote:\n> Could somebody who actually works with CVS import Ack this?\n> Pretty please?\n\nSounds sane. It would be interesting to hear about what repo (and\nserver) this was seen against. Elrond, can you tell us more about\nthis?\n\ncheers,\n\n\nmartin\n"},{"id":"20229","messageId":"20060518132956.GA19476@memak.tu-darmstadt.de","threadId":"4118","inReplyTo":"46a038f90605172153mac96f40id9a50d2f29c75915@mail.gmail.com","subject":"Re: [Patch] git-cvsimport: tiny fix","fromName":"Elrond","fromEmail":"elrond+kernel.org@samba-tng.org","sentAt":"2006-05-18T13:29:57Z","receivedAt":"2006-05-18T13:29:57Z","isPatch":true,"sender":{"key":"elrond+kernel.org@samba-tng.org","avatar":null},"body":"On Thu, May 18, 2006 at 04:53:56PM +1200, Martin Langhoff wrote:\n> On 5/18/06, Junio C Hamano <junkio@cox.net> wrote:\n> >Could somebody who actually works with CVS import Ack this?\n> >Pretty please?\n> \n> Sounds sane. It would be interesting to hear about what repo (and\n> server) this was seen against. Elrond, can you tell us more about\n> this?\n\nThis is a private local repository.\ngit-cvsimport starts a local \"cvs server\" for this.\n\nI tried to create a minimal repo, that would trigger the\nsame behaviour, but didn't succeed. My current guessing is,\nthat this happened in cooperation with \"cvsps\" caching.\n(cvsps is a tool used by git-cvsimport).\n\nI will move the cvsps cache for my problematic repo out of\nthe way and try a git-cvsimport from scratch to verify that\nthe above mentioned issue is related to cvsps caching.\nBut I still think, that handling all cvs pserver replies\nshould be done anyway in git-cvsimport (when it relies on\nthis mode of operation).\n\n\n    Elrond\n"}]}