{"thread":{"id":"41172","subject":"[PATCH 08/12] t9150-svk-mergetickets.sh: use the $( ... ) construct for command substitution","startedAt":"2016-01-12T11:49:26Z","lastAt":"2016-01-12T19:59:45Z","messageCount":15,"participants":["Elia Pinto","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":12},"messages":[{"id":"275793","messageId":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":null,"subject":"[PATCH 00/12] use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:26Z","receivedAt":"2016-01-12T11:49:26Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"This patch series continues the changes introduced with the merge\n6753d8a85d543253d95184ec2faad6dc197f248:\n\n    Merge branch 'ep/shell-command-substitution'\n\n    Adjust shell scripts to use $(cmd) instead of `cmd`.\n\n\nThis is the is the ninth and final series.\n\n\n*** BLURB HERE ***\n\nElia Pinto (12):\n  t9119-git-svn-info.sh: use the $( ... ) construct for command\n    substitution\n  t9129-git-svn-i18n-commitencoding.sh: use the $( ... ) construct for\n    command substitution\n  t9130-git-svn-authors-file.sh: use the $( ... ) construct for command\n    substitution\n  t9132-git-svn-broken-symlink.sh: use the $( ... ) construct for\n    command substitution\n  t9137-git-svn-dcommit-clobber-series.sh: use the $( ... ) construct\n    for command substitution\n  t9138-git-svn-authors-prog.sh: use the $( ... ) construct for command\n    substitution\n  t9145-git-svn-master-branch.sh: use the $( ... ) construct for command\n    substitution\n  t9150-svk-mergetickets.sh: use the $( ... ) construct for command\n    substitution\n  t9300-fast-import.sh: use the $( ... ) construct for command\n    substitution\n  t9350-fast-export.sh: use the $( ... ) construct for command\n    substitution\n  t9501-gitweb-standalone-http-status.sh: use the $( ... ) construct for\n    command substitution\n  t9901-git-web--browse.sh: use the $( ... ) construct for command\n    substitution\n\n t/t9119-git-svn-info.sh                   |  2 +-\n t/t9129-git-svn-i18n-commitencoding.sh    |  4 +-\n t/t9130-git-svn-authors-file.sh           | 12 +++---\n t/t9132-git-svn-broken-symlink.sh         |  4 +-\n t/t9137-git-svn-dcommit-clobber-series.sh | 24 +++++------\n t/t9138-git-svn-authors-prog.sh           |  2 +-\n t/t9145-git-svn-master-branch.sh          |  4 +-\n t/t9150-svk-mergetickets.sh               |  2 +-\n t/t9300-fast-import.sh                    | 68 +++++++++++++++----------------\n t/t9350-fast-export.sh                    |  6 +--\n t/t9501-gitweb-standalone-http-status.sh  |  6 +--\n t/t9901-git-web--browse.sh                |  2 +-\n 12 files changed, 68 insertions(+), 68 deletions(-)\n\n-- \n2.5.0\n"},{"id":"275799","messageId":"1452599378-47882-2-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 01/12] t9119-git-svn-info.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:27Z","receivedAt":"2016-01-12T11:49:27Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9119-git-svn-info.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh\nindex f16f323..88241ba 100755\n--- a/t/t9119-git-svn-info.sh\n+++ b/t/t9119-git-svn-info.sh\n@@ -8,7 +8,7 @@ test_description='git svn info'\n \n # Tested with: svn, version 1.4.4 (r25188)\n # Tested with: svn, version 1.6.[12345689]\n-v=`svn_cmd --version | sed -n -e 's/^svn, version \\(1\\.[0-9]*\\.[0-9]*\\).*$/\\1/p'`\n+v=$(svn_cmd --version | sed -n -e 's/^svn, version \\(1\\.[0-9]*\\.[0-9]*\\).*$/\\1/p')\n case $v in\n 1.[456].*)\n \t;;\n-- \n2.5.0\n"},{"id":"275792","messageId":"1452599378-47882-3-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/12] t9129-git-svn-i18n-commitencoding.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:28Z","receivedAt":"2016-01-12T11:49:28Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9129-git-svn-i18n-commitencoding.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t9129-git-svn-i18n-commitencoding.sh b/t/t9129-git-svn-i18n-commitencoding.sh\nindex 8cfdfe7..39b6bcb 100755\n--- a/t/t9129-git-svn-i18n-commitencoding.sh\n+++ b/t/t9129-git-svn-i18n-commitencoding.sh\n@@ -7,7 +7,7 @@ test_description='git svn honors i18n.commitEncoding in config'\n . ./lib-git-svn.sh\n \n compare_git_head_with () {\n-\tnr=`wc -l < \"$1\"`\n+\tnr=$(wc -l < \"$1\")\n \ta=7\n \tb=$(($a + $nr - 1))\n \tgit cat-file commit HEAD | sed -ne \"$a,${b}p\" >current &&\n@@ -29,7 +29,7 @@ fi\n compare_svn_head_with () {\n \t# extract just the log message and strip out committer info.\n \t# don't use --limit here since svn 1.1.x doesn't have it,\n-\tLC_ALL=\"$a_utf8_locale\" svn log `git svn info --url` | perl -w -e '\n+\tLC_ALL=\"$a_utf8_locale\" svn log $(git svn info --url) | perl -w -e '\n \t\tuse bytes;\n \t\t$/ = (\"-\"x72) . \"\\n\";\n \t\tmy @x = <STDIN>;\n-- \n2.5.0\n"},{"id":"275802","messageId":"1452599378-47882-4-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/12] t9130-git-svn-authors-file.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:29Z","receivedAt":"2016-01-12T11:49:29Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9130-git-svn-authors-file.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t9130-git-svn-authors-file.sh b/t/t9130-git-svn-authors-file.sh\nindex c44de26..d306b77 100755\n--- a/t/t9130-git-svn-authors-file.sh\n+++ b/t/t9130-git-svn-authors-file.sh\n@@ -26,7 +26,7 @@ test_expect_success 'start import with incomplete authors file' '\n test_expect_success 'imported 2 revisions successfully' '\n \t(\n \t\tcd x\n-\t\ttest \"`git rev-list refs/remotes/git-svn | wc -l`\" -eq 2 &&\n+\t\ttest \"$(git rev-list refs/remotes/git-svn | wc -l)\" -eq 2 &&\n \t\tgit rev-list -1 --pretty=raw refs/remotes/git-svn | \\\n \t\t  grep \"^author BBBBBBB BBBBBBB <bb@example\\.com> \" &&\n \t\tgit rev-list -1 --pretty=raw refs/remotes/git-svn~1 | \\\n@@ -43,7 +43,7 @@ test_expect_success 'continues to import once authors have been added' '\n \t(\n \t\tcd x\n \t\tgit svn fetch --authors-file=../svn-authors &&\n-\t\ttest \"`git rev-list refs/remotes/git-svn | wc -l`\" -eq 4 &&\n+\t\ttest \"$(git rev-list refs/remotes/git-svn | wc -l)\" -eq 4 &&\n \t\tgit rev-list -1 --pretty=raw refs/remotes/git-svn | \\\n \t\t  grep \"^author DDDDDDD DDDDDDD <dd@example\\.com> \" &&\n \t\tgit rev-list -1 --pretty=raw refs/remotes/git-svn~1 | \\\n@@ -73,8 +73,8 @@ tmp_config_get () {\n test_expect_success 'failure happened without negative side effects' '\n \t(\n \t\tcd aa-work &&\n-\t\ttest 6 -eq \"`tmp_config_get svn-remote.svn.branches-maxRev`\" &&\n-\t\ttest 6 -eq \"`tmp_config_get svn-remote.svn.tags-maxRev`\"\n+\t\ttest 6 -eq \"$(tmp_config_get svn-remote.svn.branches-maxRev)\" &&\n+\t\ttest 6 -eq \"$(tmp_config_get svn-remote.svn.tags-maxRev)\"\n \t)\n \t'\n \n@@ -86,8 +86,8 @@ test_expect_success 'fetch continues after authors-file is fixed' '\n \t(\n \t\tcd aa-work &&\n \t\tgit svn fetch --authors-file=../svn-authors &&\n-\t\ttest 8 -eq \"`tmp_config_get svn-remote.svn.branches-maxRev`\" &&\n-\t\ttest 8 -eq \"`tmp_config_get svn-remote.svn.tags-maxRev`\"\n+\t\ttest 8 -eq \"$(tmp_config_get svn-remote.svn.branches-maxRev)\" &&\n+\t\ttest 8 -eq \"$(tmp_config_get svn-remote.svn.tags-maxRev)\"\n \t)\n \t'\n \n-- \n2.5.0\n"},{"id":"275801","messageId":"1452599378-47882-5-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/12] t9132-git-svn-broken-symlink.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:30Z","receivedAt":"2016-01-12T11:49:30Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9132-git-svn-broken-symlink.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t9132-git-svn-broken-symlink.sh b/t/t9132-git-svn-broken-symlink.sh\nindex 6c4c90b..aeceffa 100755\n--- a/t/t9132-git-svn-broken-symlink.sh\n+++ b/t/t9132-git-svn-broken-symlink.sh\n@@ -87,7 +87,7 @@ test_expect_success 'clone using git svn' 'git svn clone -r1 \"$svnrepo\" x'\n \n test_expect_success SYMLINKS '\"bar\" is a symlink that points to \"asdf\"' '\n \ttest -L x/bar &&\n-\t(cd x && test xasdf = x\"`git cat-file blob HEAD:bar`\")\n+\t(cd x && test xasdf = x\"$(git cat-file blob HEAD:bar)\")\n '\n \n test_expect_success 'get \"bar\" => symlink fix from svn' '\n@@ -96,7 +96,7 @@ test_expect_success 'get \"bar\" => symlink fix from svn' '\n \n test_expect_success SYMLINKS '\"bar\" remains a proper symlink' '\n \ttest -L x/bar &&\n-\t(cd x && test xdoink = x\"`git cat-file blob HEAD:bar`\")\n+\t(cd x && test xdoink = x\"$(git cat-file blob HEAD:bar)\")\n '\n \n test_done\n-- \n2.5.0\n"},{"id":"275800","messageId":"1452599378-47882-6-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/12] t9137-git-svn-dcommit-clobber-series.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:31Z","receivedAt":"2016-01-12T11:49:31Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9137-git-svn-dcommit-clobber-series.sh | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)\n\ndiff --git a/t/t9137-git-svn-dcommit-clobber-series.sh b/t/t9137-git-svn-dcommit-clobber-series.sh\nindex d60da63..5fa07a3 100755\n--- a/t/t9137-git-svn-dcommit-clobber-series.sh\n+++ b/t/t9137-git-svn-dcommit-clobber-series.sh\n@@ -16,15 +16,15 @@ test_expect_success 'initialize repo' '\n \t'\n \n test_expect_success '(supposedly) non-conflicting change from SVN' '\n-\ttest x\"`sed -n -e 58p < file`\" = x58 &&\n-\ttest x\"`sed -n -e 61p < file`\" = x61 &&\n+\ttest x\"$(sed -n -e 58p < file)\" = x58 &&\n+\ttest x\"$(sed -n -e 61p < file)\" = x61 &&\n \tsvn_cmd co \"$svnrepo\" tmp &&\n \t(cd tmp &&\n \t\tperl -i.bak -p -e \"s/^58$/5588/\" file &&\n \t\tperl -i.bak -p -e \"s/^61$/6611/\" file &&\n \t\tpoke file &&\n-\t\ttest x\"`sed -n -e 58p < file`\" = x5588 &&\n-\t\ttest x\"`sed -n -e 61p < file`\" = x6611 &&\n+\t\ttest x\"$(sed -n -e 58p < file)\" = x5588 &&\n+\t\ttest x\"$(sed -n -e 61p < file)\" = x6611 &&\n \t\tsvn_cmd commit -m \"58 => 5588, 61 => 6611\"\n \t)\n \t'\n@@ -38,20 +38,20 @@ test_expect_success 'some unrelated changes to git' \"\n \t\"\n \n test_expect_success 'change file but in unrelated area' \"\n-\ttest x\\\"\\`sed -n -e 4p < file\\`\\\" = x4 &&\n-\ttest x\\\"\\`sed -n -e 7p < file\\`\\\" = x7 &&\n+\ttest x\\\"\\$(sed -n -e 4p < file)\\\" = x4 &&\n+\ttest x\\\"\\$(sed -n -e 7p < file)\\\" = x7 &&\n \tperl -i.bak -p -e 's/^4\\$/4444/' file &&\n \tperl -i.bak -p -e 's/^7\\$/7777/' file &&\n-\ttest x\\\"\\`sed -n -e 4p < file\\`\\\" = x4444 &&\n-\ttest x\\\"\\`sed -n -e 7p < file\\`\\\" = x7777 &&\n+\ttest x\\\"\\$(sed -n -e 4p < file)\\\" = x4444 &&\n+\ttest x\\\"\\$(sed -n -e 7p < file)\\\" = x7777 &&\n \tgit commit -m '4 => 4444, 7 => 7777' file &&\n \tgit svn dcommit &&\n \tsvn_cmd up tmp &&\n \tcd tmp &&\n-\t\ttest x\\\"\\`sed -n -e 4p < file\\`\\\" = x4444 &&\n-\t\ttest x\\\"\\`sed -n -e 7p < file\\`\\\" = x7777 &&\n-\t\ttest x\\\"\\`sed -n -e 58p < file\\`\\\" = x5588 &&\n-\t\ttest x\\\"\\`sed -n -e 61p < file\\`\\\" = x6611\n+\t\ttest x\\\"\\$(sed -n -e 4p < file)\\\" = x4444 &&\n+\t\ttest x\\\"\\$(sed -n -e 7p < file)\\\" = x7777 &&\n+\t\ttest x\\\"\\$(sed -n -e 58p < file)\\\" = x5588 &&\n+\t\ttest x\\\"\\$(sed -n -e 61p < file)\\\" = x6611\n \t\"\n \n test_expect_success 'attempt to dcommit with a dirty index' '\n-- \n2.5.0\n"},{"id":"275791","messageId":"1452599378-47882-7-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/12] t9138-git-svn-authors-prog.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:32Z","receivedAt":"2016-01-12T11:49:32Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9138-git-svn-authors-prog.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9138-git-svn-authors-prog.sh b/t/t9138-git-svn-authors-prog.sh\nindex 2937f4c..7d7e9d4 100755\n--- a/t/t9138-git-svn-authors-prog.sh\n+++ b/t/t9138-git-svn-authors-prog.sh\n@@ -37,7 +37,7 @@ test_expect_success 'import authors with prog and file' '\n test_expect_success 'imported 6 revisions successfully' '\n \t(\n \t\tcd x\n-\t\ttest \"`git rev-list refs/remotes/git-svn | wc -l`\" -eq 6\n+\t\ttest \"$(git rev-list refs/remotes/git-svn | wc -l)\" -eq 6\n \t)\n '\n \n-- \n2.5.0\n"},{"id":"275794","messageId":"1452599378-47882-8-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/12] t9145-git-svn-master-branch.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:33Z","receivedAt":"2016-01-12T11:49:33Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9145-git-svn-master-branch.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t9145-git-svn-master-branch.sh b/t/t9145-git-svn-master-branch.sh\nindex 6559137..3bbf341 100755\n--- a/t/t9145-git-svn-master-branch.sh\n+++ b/t/t9145-git-svn-master-branch.sh\n@@ -17,8 +17,8 @@ test_expect_success 'git svn clone --stdlayout sets up trunk as master' '\n \tgit svn clone -s \"$svnrepo\" g &&\n \t(\n \t\tcd g &&\n-\t\ttest x`git rev-parse --verify refs/remotes/origin/trunk^0` = \\\n-\t\t     x`git rev-parse --verify refs/heads/master^0`\n+\t\ttest x$(git rev-parse --verify refs/remotes/origin/trunk^0) = \\\n+\t\t     x$(git rev-parse --verify refs/heads/master^0)\n \t)\n '\n \n-- \n2.5.0\n"},{"id":"275790","messageId":"1452599378-47882-9-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/12] t9150-svk-mergetickets.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:34Z","receivedAt":"2016-01-12T11:49:34Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9150-svk-mergetickets.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9150-svk-mergetickets.sh b/t/t9150-svk-mergetickets.sh\nindex 24c2421..1bb676b 100755\n--- a/t/t9150-svk-mergetickets.sh\n+++ b/t/t9150-svk-mergetickets.sh\n@@ -19,7 +19,7 @@ test_expect_success 'load svk depot' \"\n uuid=b48289b2-9c08-4d72-af37-0358a40b9c15\n \n test_expect_success 'svk merges were represented coming in' \"\n-\t[ `git cat-file commit HEAD | grep parent | wc -l` -eq 2 ]\n+\t[ $(git cat-file commit HEAD | grep parent | wc -l) -eq 2 ]\n \t\"\n \n test_done\n-- \n2.5.0\n"},{"id":"275798","messageId":"1452599378-47882-10-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/12] t9300-fast-import.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:35Z","receivedAt":"2016-01-12T11:49:35Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9300-fast-import.sh | 68 +++++++++++++++++++++++++-------------------------\n 1 file changed, 34 insertions(+), 34 deletions(-)\n\ndiff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh\nindex 14a9384..4c5f3c9 100755\n--- a/t/t9300-fast-import.sh\n+++ b/t/t9300-fast-import.sh\n@@ -171,10 +171,10 @@ test_expect_success 'A: verify tag/series-A-blob' '\n \n test_expect_success 'A: verify marks output' '\n \tcat >expect <<-EOF &&\n-\t:2 `git rev-parse --verify master:file2`\n-\t:3 `git rev-parse --verify master:file3`\n-\t:4 `git rev-parse --verify master:file4`\n-\t:5 `git rev-parse --verify master^0`\n+\t:2 $(git rev-parse --verify master:file2)\n+\t:3 $(git rev-parse --verify master:file3)\n+\t:4 $(git rev-parse --verify master:file4)\n+\t:5 $(git rev-parse --verify master^0)\n \tEOF\n \ttest_cmp expect marks.out\n '\n@@ -264,8 +264,8 @@ test_expect_success 'A: verify diff' '\n \tEOF\n \tgit diff-tree -M -r master verify--import-marks >actual &&\n \tcompare_diff_raw expect actual &&\n-\ttest `git rev-parse --verify master:file2` \\\n-\t    = `git rev-parse --verify verify--import-marks:copy-of-file2`\n+\ttest $(git rev-parse --verify master:file2) \\\n+\t    = $(git rev-parse --verify verify--import-marks:copy-of-file2)\n '\n \n test_expect_success 'A: export marks with large values' '\n@@ -364,7 +364,7 @@ test_expect_success 'B: accept branch name \"TEMP_TAG\"' '\n \t\tgit prune\" &&\n \tgit fast-import <input &&\n \ttest -f .git/TEMP_TAG &&\n-\ttest `git rev-parse master` = `git rev-parse TEMP_TAG^`\n+\ttest $(git rev-parse master) = $(git rev-parse TEMP_TAG^)\n '\n \n test_expect_success 'B: accept empty committer' '\n@@ -473,8 +473,8 @@ test_expect_success 'B: fail on invalid committer (5)' '\n ###\n \n test_expect_success 'C: incremental import create pack from stdin' '\n-\tnewf=`echo hi newf | git hash-object -w --stdin` &&\n-\toldf=`git rev-parse --verify master:file2` &&\n+\tnewf=$(echo hi newf | git hash-object -w --stdin) &&\n+\toldf=$(git rev-parse --verify master:file2) &&\n \ttest_tick &&\n \tcat >input <<-INPUT_END &&\n \tcommit refs/heads/branch\n@@ -499,13 +499,13 @@ test_expect_success 'C: verify pack' '\n '\n \n test_expect_success 'C: validate reuse existing blob' '\n-\ttest $newf = `git rev-parse --verify branch:file2/newf` &&\n-\ttest $oldf = `git rev-parse --verify branch:file2/oldf`\n+\ttest $newf = $(git rev-parse --verify branch:file2/newf) &&\n+\ttest $oldf = $(git rev-parse --verify branch:file2/oldf)\n '\n \n test_expect_success 'C: verify commit' '\n \tcat >expect <<-EOF &&\n-\tparent `git rev-parse --verify master^0`\n+\tparent $(git rev-parse --verify master^0)\n \tauthor $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \tcommitter $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \n@@ -624,7 +624,7 @@ test_expect_success 'E: verify commit' '\n ###\n \n test_expect_success 'F: non-fast-forward update skips' '\n-\told_branch=`git rev-parse --verify branch^0` &&\n+\told_branch=$(git rev-parse --verify branch^0) &&\n \ttest_tick &&\n \tcat >input <<-INPUT_END &&\n \tcommit refs/heads/branch\n@@ -642,7 +642,7 @@ test_expect_success 'F: non-fast-forward update skips' '\n \n \ttest_must_fail git fast-import <input &&\n \t# branch must remain unaffected\n-\ttest $old_branch = `git rev-parse --verify branch^0`\n+\ttest $old_branch = $(git rev-parse --verify branch^0)\n '\n \n test_expect_success 'F: verify pack' '\n@@ -651,8 +651,8 @@ test_expect_success 'F: verify pack' '\n \n test_expect_success 'F: verify other commit' '\n \tcat >expect <<-EOF &&\n-\ttree `git rev-parse branch~1^{tree}`\n-\tparent `git rev-parse branch~1`\n+\ttree $(git rev-parse branch~1^{tree})\n+\tparent $(git rev-parse branch~1)\n \tauthor $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \tcommitter $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \n@@ -667,7 +667,7 @@ test_expect_success 'F: verify other commit' '\n ###\n \n test_expect_success 'G: non-fast-forward update forced' '\n-\told_branch=`git rev-parse --verify branch^0` &&\n+\told_branch=$(git rev-parse --verify branch^0) &&\n \ttest_tick &&\n \tcat >input <<-INPUT_END &&\n \tcommit refs/heads/branch\n@@ -687,8 +687,8 @@ test_expect_success 'G: verify pack' '\n '\n \n test_expect_success 'G: branch changed, but logged' '\n-\ttest $old_branch != `git rev-parse --verify branch^0` &&\n-\ttest $old_branch = `git rev-parse --verify branch@{1}`\n+\ttest $old_branch != $(git rev-parse --verify branch^0) &&\n+\ttest $old_branch = $(git rev-parse --verify branch@{1})\n '\n \n ###\n@@ -763,7 +763,7 @@ test_expect_success 'I: export-pack-edges' '\n \n test_expect_success 'I: verify edge list' '\n \tcat >expect <<-EOF &&\n-\t.git/objects/pack/pack-.pack: `git rev-parse --verify export-boundary`\n+\t.git/objects/pack/pack-.pack: $(git rev-parse --verify export-boundary)\n \tEOF\n \tsed -e s/pack-.*pack/pack-.pack/ edges.list >actual &&\n \ttest_cmp expect actual\n@@ -795,8 +795,8 @@ test_expect_success 'J: reset existing branch creates empty commit' '\n \tgit fast-import <input\n '\n test_expect_success 'J: branch has 1 commit, empty tree' '\n-\ttest 1 = `git rev-list J | wc -l` &&\n-\ttest 0 = `git ls-tree J | wc -l`\n+\ttest 1 = $(git rev-list J | wc -l) &&\n+\ttest 0 = $(git ls-tree J | wc -l)\n '\n \n test_expect_success 'J: tag must fail on empty branch' '\n@@ -838,8 +838,8 @@ test_expect_success 'K: reinit branch with from' '\n \tgit fast-import <input\n '\n test_expect_success 'K: verify K^1 = branch^1' '\n-\ttest `git rev-parse --verify branch^1` \\\n-\t\t= `git rev-parse --verify K^1`\n+\ttest $(git rev-parse --verify branch^1) \\\n+\t\t= $(git rev-parse --verify K^1)\n '\n \n ###\n@@ -929,7 +929,7 @@ test_expect_success 'L: nested tree copy does not corrupt deltas' '\n \tgit ls-tree L2 g/b/ >tmp &&\n \tcat tmp | cut -f 2 >actual &&\n \ttest_cmp expect actual &&\n-\tgit fsck `git rev-parse L2`\n+\tgit fsck $(git rev-parse L2)\n '\n \n ###\n@@ -1106,7 +1106,7 @@ test_expect_success 'N: copy dirty subdirectory' '\n \tINPUT_END\n \n \tgit fast-import <input &&\n-\ttest `git rev-parse N2^{tree}` = `git rev-parse N3^{tree}`\n+\ttest $(git rev-parse N2^{tree}) = $(git rev-parse N3^{tree})\n '\n \n test_expect_success 'N: copy directory by id' '\n@@ -1503,7 +1503,7 @@ test_expect_success 'O: comments are all skipped' '\n \tINPUT_END\n \n \tgit fast-import <input &&\n-\ttest `git rev-parse N3` = `git rev-parse O1`\n+\ttest $(git rev-parse N3) = $(git rev-parse O1)\n '\n \n test_expect_success 'O: blank lines not necessary after data commands' '\n@@ -1524,7 +1524,7 @@ test_expect_success 'O: blank lines not necessary after data commands' '\n \tINPUT_END\n \n \tgit fast-import <input &&\n-\ttest `git rev-parse N3` = `git rev-parse O2`\n+\ttest $(git rev-parse N3) = $(git rev-parse O2)\n '\n \n test_expect_success 'O: repack before next test' '\n@@ -1570,8 +1570,8 @@ test_expect_success 'O: blank lines not necessary after other commands' '\n \tINPUT_END\n \n \tgit fast-import <input &&\n-\ttest 8 = `find .git/objects/pack -type f | wc -l` &&\n-\ttest `git rev-parse refs/tags/O3-2nd` = `git rev-parse O3^` &&\n+\ttest 8 = $(find .git/objects/pack -type f | wc -l) &&\n+\ttest $(git rev-parse refs/tags/O3-2nd) = $(git rev-parse O3^) &&\n \tgit log --reverse --pretty=oneline O3 | sed s/^.*z// >actual &&\n \ttest_cmp expect actual\n '\n@@ -1631,7 +1631,7 @@ test_expect_success 'P: superproject & submodule mix' '\n \tdata <<DATAEND\n \t[submodule \"sub\"]\n \t\tpath = sub\n-\t\turl = \"`pwd`/sub\"\n+\t\turl = \"$(pwd)/sub\"\n \tDATAEND\n \n \tcommit refs/heads/subuse1\n@@ -1691,7 +1691,7 @@ test_expect_success 'P: verbatim SHA gitlinks' '\n \tdata <<DATAEND\n \t[submodule \"sub\"]\n \t\tpath = sub\n-\t\turl = \"`pwd`/sub\"\n+\t\turl = \"$(pwd)/sub\"\n \tDATAEND\n \n \tcommit refs/heads/subuse2\n@@ -1978,7 +1978,7 @@ test_expect_success 'Q: verify first note for third commit' '\n \n test_expect_success 'Q: verify second notes commit' '\n \tcat >expect <<-EOF &&\n-\tparent `git rev-parse --verify refs/notes/foobar~2`\n+\tparent $(git rev-parse --verify refs/notes/foobar~2)\n \tauthor $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \tcommitter $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \n@@ -2045,7 +2045,7 @@ test_expect_success 'Q: verify third note for first commit' '\n \n test_expect_success 'Q: verify fourth notes commit' '\n \tcat >expect <<-EOF &&\n-\tparent `git rev-parse --verify refs/notes/foobar^`\n+\tparent $(git rev-parse --verify refs/notes/foobar^)\n \tauthor $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \tcommitter $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE\n \n-- \n2.5.0\n"},{"id":"275795","messageId":"1452599378-47882-11-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/12] t9350-fast-export.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:36Z","receivedAt":"2016-01-12T11:49:36Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9350-fast-export.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh\nindex 66c8b0a..b5149fd 100755\n--- a/t/t9350-fast-export.sh\n+++ b/t/t9350-fast-export.sh\n@@ -163,7 +163,7 @@ test_expect_success 'setup submodule' '\n \t\tgit add file &&\n \t\tgit commit -m sub_initial\n \t) &&\n-\tgit submodule add \"`pwd`/sub\" sub &&\n+\tgit submodule add \"$(pwd)/sub\" sub &&\n \tgit commit -m initial &&\n \ttest_tick &&\n \t(\n@@ -377,7 +377,7 @@ test_expect_success 'full-tree re-shows unmodified files'        '\n \n test_expect_success 'set-up a few more tags for tag export tests' '\n \tgit checkout -f master &&\n-\tHEAD_TREE=`git show -s --pretty=raw HEAD | grep tree | sed \"s/tree //\"` &&\n+\tHEAD_TREE=$(git show -s --pretty=raw HEAD | grep tree | sed \"s/tree //\") &&\n \tgit tag    tree_tag        -m \"tagging a tree\" $HEAD_TREE &&\n \tgit tag -a tree_tag-obj    -m \"tagging a tree\" $HEAD_TREE &&\n \tgit tag    tag-obj_tag     -m \"tagging a tag\" tree_tag-obj &&\n@@ -422,7 +422,7 @@ test_expect_success 'directory becomes symlink'        '\n test_expect_success 'fast-export quotes pathnames' '\n \tgit init crazy-paths &&\n \t(cd crazy-paths &&\n-\t blob=`echo foo | git hash-object -w --stdin` &&\n+\t blob=$(echo foo | git hash-object -w --stdin) &&\n \t git update-index --add \\\n \t\t--cacheinfo 100644 $blob \"$(printf \"path with\\\\nnewline\")\" \\\n \t\t--cacheinfo 100644 $blob \"path with \\\"quote\\\"\" \\\n-- \n2.5.0\n"},{"id":"275797","messageId":"1452599378-47882-12-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 11/12] t9501-gitweb-standalone-http-status.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:37Z","receivedAt":"2016-01-12T11:49:37Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9501-gitweb-standalone-http-status.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh\nindex d3a5bac..2a0ffed 100755\n--- a/t/t9501-gitweb-standalone-http-status.sh\n+++ b/t/t9501-gitweb-standalone-http-status.sh\n@@ -100,14 +100,14 @@ test_expect_success 'snapshots: bad tree-ish id (tagged object)' '\n \techo object > tag-object &&\n \tgit add tag-object &&\n \ttest_tick && git commit -m \"Object to be tagged\" &&\n-\tgit tag tagged-object `git hash-object tag-object` &&\n+\tgit tag tagged-object $(git hash-object tag-object) &&\n \tgitweb_run \"p=.git;a=snapshot;h=tagged-object;sf=tgz\" &&\n \tgrep \"400 - Object is not a tree-ish\" gitweb.output\n '\n test_debug 'cat gitweb.output'\n \n test_expect_success 'snapshots: good object id' '\n-\tID=`git rev-parse --verify HEAD` &&\n+\tID=$(git rev-parse --verify HEAD) &&\n \tgitweb_run \"p=.git;a=snapshot;h=$ID;sf=tgz\" &&\n \tgrep \"Status: 200 OK\" gitweb.output\n '\n@@ -173,7 +173,7 @@ test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (unmod\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: tree snapshot' '\n-\tID=`git rev-parse --verify HEAD^{tree}` &&\n+\tID=$(git rev-parse --verify HEAD^{tree}) &&\n \tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n \texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n-- \n2.5.0\n"},{"id":"275796","messageId":"1452599378-47882-13-git-send-email-gitter.spiros@gmail.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 12/12] t9901-git-web--browse.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-12T11:49:38Z","receivedAt":"2016-01-12T11:49:38Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t9901-git-web--browse.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9901-git-web--browse.sh b/t/t9901-git-web--browse.sh\nindex b0a6bad..de7152f 100755\n--- a/t/t9901-git-web--browse.sh\n+++ b/t/t9901-git-web--browse.sh\n@@ -43,7 +43,7 @@ test_expect_success \\\n \techo fake: \"$@\"\n \tEOF\n \tchmod +x \"fake browser\" &&\n-\tgit config browser.w3m.path \"`pwd`/fake browser\" &&\n+\tgit config browser.w3m.path \"$(pwd)/fake browser\" &&\n \ttest_web_browse w3m http://example.com/foo\n '\n \n-- \n2.5.0\n"},{"id":"275829","messageId":"xmqqh9iitw3p.fsf@gitster.mtv.corp.google.com","threadId":"41172","inReplyTo":"1452599378-47882-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 00/12] use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-01-12T19:51:22Z","receivedAt":"2016-01-12T19:51:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  It must have been quite an effort to proofread these\nwithout getting asleep.\n\nI didn't spot anything wrong in the last 22 patches, but now I am\ngetting sleepy ;-)\n"},{"id":"275831","messageId":"xmqq8u3utvpq.fsf@gitster.mtv.corp.google.com","threadId":"41172","inReplyTo":"1452599378-47882-9-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 08/12] t9150-svk-mergetickets.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-01-12T19:59:45Z","receivedAt":"2016-01-12T19:59:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto <gitter.spiros@gmail.com> writes:\n\n>  test_expect_success 'svk merges were represented coming in' \"\n> -\t[ `git cat-file commit HEAD | grep parent | wc -l` -eq 2 ]\n> +\t[ $(git cat-file commit HEAD | grep parent | wc -l) -eq 2 ]\n>  \t\"\n\nEntirely outside of the theme of this topic, but this should be\ncorrected to use \"test\".\n\nMore importantly, the outer quote should become single quote.  As it\ncurrently is written, \"git cat-file\" runs outside the protection of\ntest_expect_success when the command line of the test_expect_success\nis formulated, which defeats the whole purpose of test helper macros\nto run everything \"git\" inside them.\n"}]}