{"thread":{"id":"41132","subject":"[PATCH] Expand documentation describing --signoff","startedAt":"2016-01-05T19:20:26Z","lastAt":"2016-01-05T23:02:07Z","messageCount":2,"participants":["David A. Wheeler","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"275394","messageId":"E1aGX9e-0002m1-55@rmm6prod02.runbox.com","threadId":"41132","inReplyTo":null,"subject":"[PATCH] Expand documentation describing --signoff","fromName":"David A. Wheeler","fromEmail":"dwheeler@dwheeler.com","sentAt":"2016-01-05T19:20:26Z","receivedAt":"2016-01-05T19:20:26Z","isPatch":true,"sender":{"key":"dwheeler@dwheeler.com","avatar":"https://avatars.githubusercontent.com/u/813150?v=4"},"body":"Modify various document (man page) files to explain\nin more detail what --signoff means.\n\nThis was inspired by https://lwn.net/Articles/669976/ where\npaulj noted, \"adding [the] '-s' argument to [a] git commit\ndoesn't really mean you have even heard of the DCO...\".\nExtending git's documentation will make it easier to argue\nthat developers understood --signoff when they use it.\n\nSigned-off-by: David A. Wheeler <dwheeler@dwheeler.com>\n---\n Documentation/git-am.txt           | 1 +\n Documentation/git-cherry-pick.txt  | 1 +\n Documentation/git-commit.txt       | 6 +++++-\n Documentation/git-format-patch.txt | 1 +\n Documentation/git-revert.txt       | 1 +\n 5 files changed, 9 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-am.txt b/Documentation/git-am.txt\nindex 452c1fe..13cdd7f 100644\n--- a/Documentation/git-am.txt\n+++ b/Documentation/git-am.txt\n@@ -35,6 +35,7 @@ OPTIONS\n --signoff::\n \tAdd a `Signed-off-by:` line to the commit message, using\n \tthe committer identity of yourself.\n+\tSee the signoff option in linkgit:git-commit[1] for more information.\n \n -k::\n --keep::\ndiff --git a/Documentation/git-cherry-pick.txt b/Documentation/git-cherry-pick.txt\nindex 77da29a..6154e57 100644\n--- a/Documentation/git-cherry-pick.txt\n+++ b/Documentation/git-cherry-pick.txt\n@@ -100,6 +100,7 @@ effect to your index in a row.\n -s::\n --signoff::\n \tAdd Signed-off-by line at the end of the commit message.\n+\tSee the signoff option in linkgit:git-commit[1] for more information.\n \n -S[<keyid>]::\n --gpg-sign[=<keyid>]::\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex 7f34a5b..9ec6b3c 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -154,7 +154,11 @@ OPTIONS\n -s::\n --signoff::\n \tAdd Signed-off-by line by the committer at the end of the commit\n-\tlog message.\n+\tlog message.  The meaning of a signoff depends on the project,\n+\tbut it typically certifies that committer has\n+\tthe rights to submit this work under the same license and\n+\tagrees to a Developer Certificate of Origin\n+\t(see http://developercertificate.org/ for more information).\n \n -n::\n --no-verify::\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex e3cdaeb..b149e09 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -109,6 +109,7 @@ include::diff-options.txt[]\n --signoff::\n \tAdd `Signed-off-by:` line to the commit message, using\n \tthe committer identity of yourself.\n+\tSee the signoff option in linkgit:git-commit[1] for more information.\n \n --stdout::\n \tPrint all commits to the standard output in mbox format,\ndiff --git a/Documentation/git-revert.txt b/Documentation/git-revert.txt\nindex b15139f..573616a 100644\n--- a/Documentation/git-revert.txt\n+++ b/Documentation/git-revert.txt\n@@ -89,6 +89,7 @@ effect to your index in a row.\n -s::\n --signoff::\n \tAdd Signed-off-by line at the end of the commit message.\n+\tSee the signoff option in linkgit:git-commit[1] for more information.\n \n --strategy=<strategy>::\n \tUse the given merge strategy.  Should only be used once.\n-- \n2.5.3\n"},{"id":"275405","messageId":"xmqqa8ojiqa8.fsf@gitster.mtv.corp.google.com","threadId":"41132","inReplyTo":"E1aGX9e-0002m1-55@rmm6prod02.runbox.com","subject":"Re: [PATCH] Expand documentation describing --signoff","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-01-05T23:02:07Z","receivedAt":"2016-01-05T23:02:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"David A. Wheeler\" <dwheeler@dwheeler.com> writes:\n\n> Modify various document (man page) files to explain\n> in more detail what --signoff means.\n>\n> This was inspired by https://lwn.net/Articles/669976/ where\n> paulj noted, \"adding [the] '-s' argument to [a] git commit\n> doesn't really mean you have even heard of the DCO...\".\n> Extending git's documentation will make it easier to argue\n> that developers understood --signoff when they use it.\n>\n> Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>\n> ---\n\nLooks sensible, striking the balance between the need by the\nprojects that do adopt DCO to be specific, and the need by the\nothers to allow other uses of \"-s\".\n\nWill queue; thanks.\n\n\n>  Documentation/git-am.txt           | 1 +\n>  Documentation/git-cherry-pick.txt  | 1 +\n>  Documentation/git-commit.txt       | 6 +++++-\n>  Documentation/git-format-patch.txt | 1 +\n>  Documentation/git-revert.txt       | 1 +\n>  5 files changed, 9 insertions(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt\n> index 452c1fe..13cdd7f 100644\n> --- a/Documentation/git-am.txt\n> +++ b/Documentation/git-am.txt\n> @@ -35,6 +35,7 @@ OPTIONS\n>  --signoff::\n>  \tAdd a `Signed-off-by:` line to the commit message, using\n>  \tthe committer identity of yourself.\n> +\tSee the signoff option in linkgit:git-commit[1] for more information.\n>  \n>  -k::\n>  --keep::\n> diff --git a/Documentation/git-cherry-pick.txt b/Documentation/git-cherry-pick.txt\n> index 77da29a..6154e57 100644\n> --- a/Documentation/git-cherry-pick.txt\n> +++ b/Documentation/git-cherry-pick.txt\n> @@ -100,6 +100,7 @@ effect to your index in a row.\n>  -s::\n>  --signoff::\n>  \tAdd Signed-off-by line at the end of the commit message.\n> +\tSee the signoff option in linkgit:git-commit[1] for more information.\n>  \n>  -S[<keyid>]::\n>  --gpg-sign[=<keyid>]::\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index 7f34a5b..9ec6b3c 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -154,7 +154,11 @@ OPTIONS\n>  -s::\n>  --signoff::\n>  \tAdd Signed-off-by line by the committer at the end of the commit\n> -\tlog message.\n> +\tlog message.  The meaning of a signoff depends on the project,\n> +\tbut it typically certifies that committer has\n> +\tthe rights to submit this work under the same license and\n> +\tagrees to a Developer Certificate of Origin\n> +\t(see http://developercertificate.org/ for more information).\n>  \n>  -n::\n>  --no-verify::\n> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\n> index e3cdaeb..b149e09 100644\n> --- a/Documentation/git-format-patch.txt\n> +++ b/Documentation/git-format-patch.txt\n> @@ -109,6 +109,7 @@ include::diff-options.txt[]\n>  --signoff::\n>  \tAdd `Signed-off-by:` line to the commit message, using\n>  \tthe committer identity of yourself.\n> +\tSee the signoff option in linkgit:git-commit[1] for more information.\n>  \n>  --stdout::\n>  \tPrint all commits to the standard output in mbox format,\n> diff --git a/Documentation/git-revert.txt b/Documentation/git-revert.txt\n> index b15139f..573616a 100644\n> --- a/Documentation/git-revert.txt\n> +++ b/Documentation/git-revert.txt\n> @@ -89,6 +89,7 @@ effect to your index in a row.\n>  -s::\n>  --signoff::\n>  \tAdd Signed-off-by line at the end of the commit message.\n> +\tSee the signoff option in linkgit:git-commit[1] for more information.\n>  \n>  --strategy=<strategy>::\n>  \tUse the given merge strategy.  Should only be used once.\n"}]}