{"thread":{"id":"41113","subject":"[PATCH 01/10] t/t5522-pull-symlink.sh: use the $( ... ) construct for command substitution","startedAt":"2016-01-04T09:10:41Z","lastAt":"2016-01-04T21:58:39Z","messageCount":12,"participants":["Elia Pinto","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":10},"messages":[{"id":"275280","messageId":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":null,"subject":"[PATCH 00/10] use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:41Z","receivedAt":"2016-01-04T09:10:41Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"This patch series continues the changes introduced with the merge\n6753d8a85d543253d95184ec2faad6dc197f248:\n\n    Merge branch 'ep/shell-command-substitution'\n\n    Adjust shell scripts to use $(cmd) instead of `cmd`.\n\n\nThis is the fifth series, the other will be sent separately.\n\nElia Pinto (10):\n  t/t5522-pull-symlink.sh: use the $( ... ) construct for command\n    substitution\n  t/t5530-upload-pack-error.sh: use the $( ... ) construct for command\n    substitution\n  t/t5532-fetch-proxy.sh: use the $( ... ) construct for command\n    substitution\n  t/t5537-fetch-shallow.sh: use the $( ... ) construct for command\n    substitution\n  t/t5538-push-shallow.sh: use the $( ... ) construct for command\n    substitution\n  t/t5550-http-fetch-dumb.sh: use the $( ... ) construct for command\n    substitution\n  t/t5570-git-daemon.sh: use the $( ... ) construct for command\n    substitution\n  t/t5601-clone.sh: use the $( ... ) construct for command substitution\n  t/t5700-clone-reference.sh: use the $( ... ) construct for command\n    substitution\n  t/t5710-info-alternate.sh: use the $( ... ) construct for command\n    substitution\n\n t/t5522-pull-symlink.sh      | 2 +-\n t/t5530-upload-pack-error.sh | 2 +-\n t/t5532-fetch-proxy.sh       | 4 ++--\n t/t5537-fetch-shallow.sh     | 4 ++--\n t/t5538-push-shallow.sh      | 4 ++--\n t/t5550-http-fetch-dumb.sh   | 8 ++++----\n t/t5570-git-daemon.sh        | 8 ++++----\n t/t5601-clone.sh             | 2 +-\n t/t5700-clone-reference.sh   | 2 +-\n t/t5710-info-alternate.sh    | 2 +-\n 10 files changed, 19 insertions(+), 19 deletions(-)\n\n-- \n2.3.3.GIT\n"},{"id":"275279","messageId":"1451898651-16468-2-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 01/10] t/t5522-pull-symlink.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:42Z","receivedAt":"2016-01-04T09:10:42Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5522-pull-symlink.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5522-pull-symlink.sh b/t/t5522-pull-symlink.sh\nindex 8e9b204..bcff460 100755\n--- a/t/t5522-pull-symlink.sh\n+++ b/t/t5522-pull-symlink.sh\n@@ -54,7 +54,7 @@ test_expect_success SYMLINKS 'pulling from real subdir' '\n # git rev-parse --show-cdup printed a path relative to\n # clone-repo/subdir/, not subdir-link/.  Git rev-parse --show-cdup\n # used the correct .git, but when the git pull shell script did\n-# \"cd `git rev-parse --show-cdup`\", it ended up in the wrong\n+# \"cd $(git rev-parse --show-cdup)\", it ended up in the wrong\n # directory.  A POSIX shell's \"cd\" works a little differently\n # than chdir() in C; \"cd -P\" is much closer to chdir().\n #\n-- \n2.3.3.GIT\n"},{"id":"275287","messageId":"1451898651-16468-3-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/10] t/t5530-upload-pack-error.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:43Z","receivedAt":"2016-01-04T09:10:43Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5530-upload-pack-error.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5530-upload-pack-error.sh b/t/t5530-upload-pack-error.sh\nindex 3932e79..4f6e32b 100755\n--- a/t/t5530-upload-pack-error.sh\n+++ b/t/t5530-upload-pack-error.sh\n@@ -4,7 +4,7 @@ test_description='errors in upload-pack'\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n corrupt_repo () {\n \tobject_sha1=$(git rev-parse \"$1\") &&\n-- \n2.3.3.GIT\n"},{"id":"275285","messageId":"1451898651-16468-4-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/10] t/t5532-fetch-proxy.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:44Z","receivedAt":"2016-01-04T09:10:44Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5532-fetch-proxy.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5532-fetch-proxy.sh b/t/t5532-fetch-proxy.sh\nindex 5531bd1..d75ef0e 100755\n--- a/t/t5532-fetch-proxy.sh\n+++ b/t/t5532-fetch-proxy.sh\n@@ -15,7 +15,7 @@ test_expect_success 'setup remote repo' '\n cat >proxy <<'EOF'\n #!/bin/sh\n echo >&2 \"proxying for $*\"\n-cmd=`\"$PERL_PATH\" -e '\n+cmd=$(\"$PERL_PATH\" -e '\n \tread(STDIN, $buf, 4);\n \tmy $n = hex($buf) - 4;\n \tread(STDIN, $buf, $n);\n@@ -23,7 +23,7 @@ cmd=`\"$PERL_PATH\" -e '\n \t# drop absolute-path on repo name\n \t$cmd =~ s{ /}{ };\n \tprint $cmd;\n-'`\n+')\n echo >&2 \"Running '$cmd'\"\n exec $cmd\n EOF\n-- \n2.3.3.GIT\n"},{"id":"275286","messageId":"1451898651-16468-5-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/10] t/t5537-fetch-shallow.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:45Z","receivedAt":"2016-01-04T09:10:45Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5537-fetch-shallow.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh\nindex a980574..df8d2f0 100755\n--- a/t/t5537-fetch-shallow.sh\n+++ b/t/t5537-fetch-shallow.sh\n@@ -98,7 +98,7 @@ EOF\n test_expect_success 'fetch something upstream has but hidden by clients shallow boundaries' '\n \t# the blob \"1\" is available in .git but hidden by the\n \t# shallow2/.git/shallow and it should be resent\n-\t! git --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` >/dev/null &&\n+\t! git --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null &&\n \techo 1 >1.t &&\n \tgit add 1.t &&\n \tgit commit -m add-1-back &&\n@@ -114,7 +114,7 @@ add-1-back\n EOF\n \ttest_cmp expect actual\n \t) &&\n-\tgit --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` >/dev/null\n+\tgit --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null\n \n '\n \n-- \n2.3.3.GIT\n"},{"id":"275284","messageId":"1451898651-16468-6-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/10] t/t5538-push-shallow.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:46Z","receivedAt":"2016-01-04T09:10:46Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5538-push-shallow.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5538-push-shallow.sh b/t/t5538-push-shallow.sh\nindex ceee95b..ecbf84d 100755\n--- a/t/t5538-push-shallow.sh\n+++ b/t/t5538-push-shallow.sh\n@@ -104,7 +104,7 @@ EOF\n '\n \n test_expect_success 'push from full to shallow' '\n-\t! git --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` &&\n+\t! git --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) &&\n \tcommit 1 &&\n \tgit push shallow2/.git +master:refs/remotes/top/master &&\n \t(\n@@ -117,7 +117,7 @@ test_expect_success 'push from full to shallow' '\n 3\n EOF\n \ttest_cmp expect actual &&\n-\tgit cat-file blob `echo 1|git hash-object --stdin` >/dev/null\n+\tgit cat-file blob $(echo 1|git hash-object --stdin) >/dev/null\n \t)\n '\n test_done\n-- \n2.3.3.GIT\n"},{"id":"275282","messageId":"1451898651-16468-7-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/10] t/t5550-http-fetch-dumb.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:47Z","receivedAt":"2016-01-04T09:10:47Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5550-http-fetch-dumb.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh\nindex 87a7aa0..6414635 100755\n--- a/t/t5550-http-fetch-dumb.sh\n+++ b/t/t5550-http-fetch-dumb.sh\n@@ -132,7 +132,7 @@ test_expect_success 'fetch packed objects' '\n test_expect_success 'fetch notices corrupt pack' '\n \tcp -R \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n \t(cd \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n-\t p=`ls objects/pack/pack-*.pack` &&\n+\t p=$(ls objects/pack/pack-*.pack) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -140,14 +140,14 @@ test_expect_success 'fetch notices corrupt pack' '\n \t(cd repo_bad1.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad1.git &&\n-\t test 0 = `ls objects/pack/pack-*.pack | wc -l`\n+\t test 0 = $(ls objects/pack/pack-*.pack | wc -l)\n \t)\n '\n \n test_expect_success 'fetch notices corrupt idx' '\n \tcp -R \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n \t(cd \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n-\t p=`ls objects/pack/pack-*.idx` &&\n+\t p=$(ls objects/pack/pack-*.idx) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -155,7 +155,7 @@ test_expect_success 'fetch notices corrupt idx' '\n \t(cd repo_bad2.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad2.git &&\n-\t test 0 = `ls objects/pack | wc -l`\n+\t test 0 = $(ls objects/pack | wc -l)\n \t)\n '\n \n-- \n2.3.3.GIT\n"},{"id":"275281","messageId":"1451898651-16468-8-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/10] t/t5570-git-daemon.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:48Z","receivedAt":"2016-01-04T09:10:48Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5570-git-daemon.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh\nindex b7e2832..d76269a 100755\n--- a/t/t5570-git-daemon.sh\n+++ b/t/t5570-git-daemon.sh\n@@ -57,7 +57,7 @@ test_expect_success 'prepare pack objects' '\n test_expect_success 'fetch notices corrupt pack' '\n \tcp -R \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n \t(cd \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n-\t p=`ls objects/pack/pack-*.pack` &&\n+\t p=$(ls objects/pack/pack-*.pack) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -65,14 +65,14 @@ test_expect_success 'fetch notices corrupt pack' '\n \t(cd repo_bad1.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch \"$GIT_DAEMON_URL/repo_bad1.git\" &&\n-\t test 0 = `ls objects/pack/pack-*.pack | wc -l`\n+\t test 0 = $(ls objects/pack/pack-*.pack | wc -l)\n \t)\n '\n \n test_expect_success 'fetch notices corrupt idx' '\n \tcp -R \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n \t(cd \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n-\t p=`ls objects/pack/pack-*.idx` &&\n+\t p=$(ls objects/pack/pack-*.idx) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -80,7 +80,7 @@ test_expect_success 'fetch notices corrupt idx' '\n \t(cd repo_bad2.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch \"$GIT_DAEMON_URL/repo_bad2.git\" &&\n-\t test 0 = `ls objects/pack | wc -l`\n+\t test 0 = $(ls objects/pack | wc -l)\n \t)\n '\n \n-- \n2.3.3.GIT\n"},{"id":"275288","messageId":"1451898651-16468-9-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/10] t/t5601-clone.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:49Z","receivedAt":"2016-01-04T09:10:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5601-clone.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex 9b34f3c..61dc4ce 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -221,7 +221,7 @@ test_expect_success 'clone separate gitdir' '\n '\n \n test_expect_success 'clone separate gitdir: output' '\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected dst/.git\n '\n \n-- \n2.3.3.GIT\n"},{"id":"275289","messageId":"1451898651-16468-10-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/10] t/t5700-clone-reference.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:50Z","receivedAt":"2016-01-04T09:10:50Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5700-clone-reference.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh\nindex dfa1bf7..4320082 100755\n--- a/t/t5700-clone-reference.sh\n+++ b/t/t5700-clone-reference.sh\n@@ -6,7 +6,7 @@\n test_description='test clone --reference'\n . ./test-lib.sh\n \n-base_dir=`pwd`\n+base_dir=$(pwd)\n \n U=$base_dir/UPLOAD_LOG\n \n-- \n2.3.3.GIT\n"},{"id":"275283","messageId":"1451898651-16468-11-git-send-email-gitter.spiros@gmail.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/10] t/t5710-info-alternate.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-01-04T09:10:51Z","receivedAt":"2016-01-04T09:10:51Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5710-info-alternate.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh\nindex 5a6e49d..9cd2626 100755\n--- a/t/t5710-info-alternate.sh\n+++ b/t/t5710-info-alternate.sh\n@@ -21,7 +21,7 @@ test_valid_repo() {\n \ttest_line_count = 0 fsck.log\n }\n \n-base_dir=`pwd`\n+base_dir=$(pwd)\n \n test_expect_success 'preparing first repository' \\\n 'test_create_repo A && cd A &&\n-- \n2.3.3.GIT\n"},{"id":"275327","messageId":"xmqqpoxhm2gg.fsf@gitster.mtv.corp.google.com","threadId":"41113","inReplyTo":"1451898651-16468-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 00/10] use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-01-04T21:58:39Z","receivedAt":"2016-01-04T21:58:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"All looked sensible.  Thanks.\n"}]}