{"thread":{"id":"4111","subject":"Re: (patch) calloc->xaclloc in read-cache.c","startedAt":"2006-05-09T13:26:59Z","lastAt":"2006-05-09T16:14:00Z","messageCount":2,"participants":["iler.ml@gmail.com","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"19785","messageId":"7vpsin5nx8.fsf@assigned-by-dhcp.cox.net","threadId":"4111","inReplyTo":"0IZ000KI11YCKL10@mxout4.netvision.net.il","subject":"Re: (patch) calloc->xaclloc in read-cache.c","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-09T13:26:59Z","receivedAt":"2006-05-09T13:26:59Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"iler.ml@gmail.com writes:\n\n> How about this.\n\nLooks good, thanks.  If you needed some MUA trick that other\npeople might benefit from please feel free to send a patch to\nDocumentation/SubmittingPatches \"MUA specific hints\" section.\n\nExcept \"Subject: [PATCH] blah\", commit log message (in this case\nwhat you would have on the Subject line is to the point and you\nwould not need any extra log message), \"Signed-off-by: whom\",\nand perhaps \"---\\n\".  Material that you do not want to have in\nthe final commit message, like \"How about this\" and diffstat if\nyou have one, would come after the \"---\\n\" line.\n\nYour message formatted in the preferred way becomes like this:\n\n\tSubject: [PATCH] read-cache.c: use xcalloc() not calloc()\n\n\tElsewhere we use xcalloc(); we should consistently do so.\n\n        Signed-off-by: Yakov Lerner <iler.ml@gmail.com>\n\t---\n\n        * How about this?\n\n         read-cache.c |    2 +-\n         1 files changed, 1 insertions(+), 1 deletions(-)\n\n        --- read-cache.c.000\t2006-05-09 15:27:56.000000000 +0000\n        +++ read-cache.c\t2006-05-09 15:28:10.000000000 +0000\n        @@ -552,7 +552,7 @@\n\n                active_nr = ntohl(hdr->hdr_entries);\n\t...\n"},{"id":"19784","messageId":"0IZ000KI11YCKL10@mxout4.netvision.net.il","threadId":"4111","inReplyTo":null,"subject":"Re: (patch) calloc->xaclloc in read-cache.c","fromName":"","fromEmail":"iler.ml@gmail.com","sentAt":"2006-05-09T16:14:00Z","receivedAt":"2006-05-09T16:14:00Z","isPatch":false,"sender":{"key":"iler.ml@gmail.com","avatar":null},"body":"How about this.\n\n--- read-cache.c.000\t2006-05-09 15:27:56.000000000 +0000\n+++ read-cache.c\t2006-05-09 15:28:10.000000000 +0000\n@@ -552,7 +552,7 @@\n \n \tactive_nr = ntohl(hdr->hdr_entries);\n \tactive_alloc = alloc_nr(active_nr);\n-\tactive_cache = calloc(active_alloc, sizeof(struct cache_entry *));\n+\tactive_cache = xcalloc(active_alloc, sizeof(struct cache_entry *));\n \n \toffset = sizeof(*hdr);\n \tfor (i = 0; i < active_nr; i++) {\n"}]}