{"thread":{"id":"41105","subject":"[PATCH v1] Fix t3400 on a case insensitive file system","startedAt":"2016-01-01T15:08:57Z","lastAt":"2016-01-02T19:30:53Z","messageCount":2,"participants":["Torsten Bögershausen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"275256","messageId":"56869689.7030604@web.de","threadId":"41105","inReplyTo":null,"subject":"[PATCH v1] Fix t3400 on a case insensitive file system","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2016-01-01T15:08:57Z","receivedAt":"2016-01-01T15:08:57Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On a case insenstive file system x is the same as X.\nWhen a file named \"X\" exist, e.g. \">x && git add x\" does not work as expected,\nuse file name \"Y\" instead.\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t3400-rebase.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh\nindex 5ed4012..2eebd22 100755\n--- a/t/t3400-rebase.sh\n+++ b/t/t3400-rebase.sh\n@@ -259,11 +259,11 @@ test_expect_success 'rebase duplicated commit with\n--keep-empty' '\n \tgit reset --hard &&\n \tgit checkout master &&\n -\t>x && git add x && git commit x -mx &&\n-\techo x >x && git commit x -mx1 &&\n+\t>Y && git add Y && git commit Y -mY &&\n+\techo Y >Y && git commit Y -mY1 &&\n  \tgit checkout -b duplicated HEAD~ &&\n-\techo x >x && git commit x -mx2 &&\n+\techo Y >Y && git commit Y -mY2 &&\n \tgit rebase --keep-empty master\n '\n -- 2.6.2.403.g6abe3ff.dirty\n"},{"id":"275266","messageId":"xmqqziwnpymq.fsf@gitster.mtv.corp.google.com","threadId":"41105","inReplyTo":"56869689.7030604@web.de","subject":"Re: [PATCH v1] Fix t3400 on a case insensitive file system","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-01-02T19:30:53Z","receivedAt":"2016-01-02T19:30:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Torsten Bögershausen <tboegi@web.de> writes:\n\n> On a case insenstive file system x is the same as X.\n> When a file named \"X\" exist, e.g. \">x && git add x\" does not work as expected,\n> use file name \"Y\" instead.\n>\n> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n> ---\n\nIt is a right thing to fix this, but do you have to use capital 'Y'\nhere?\n\nI see both uppercase X and Y are used in the earlier tests in this\nscript, and it may be that that earlier Y, unlike earlier X, does\nnot interfere on your case insensitive system right now, but using a\nsingle letter 'Y' smells like a future breakage waiting to happen.\nWouldn't it make more sense to name this a lot more distinctively\nand uniquely?\n\nIn any case, I think this is only in the topic that has been listed\nas \"Will discard\", so I won't worry about it myself for now--if the\ntopic will be resurrected in the future, reviewers should keep an\neye to prevent it from adding this bug.\n\nThanks.\n\n\n>  t/t3400-rebase.sh | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh\n> index 5ed4012..2eebd22 100755\n> --- a/t/t3400-rebase.sh\n> +++ b/t/t3400-rebase.sh\n> @@ -259,11 +259,11 @@ test_expect_success 'rebase duplicated commit with\n> --keep-empty' '\n>  \tgit reset --hard &&\n>  \tgit checkout master &&\n>  -\t>x && git add x && git commit x -mx &&\n> -\techo x >x && git commit x -mx1 &&\n> +\t>Y && git add Y && git commit Y -mY &&\n> +\techo Y >Y && git commit Y -mY1 &&\n>   \tgit checkout -b duplicated HEAD~ &&\n> -\techo x >x && git commit x -mx2 &&\n> +\techo Y >Y && git commit Y -mY2 &&\n>  \tgit rebase --keep-empty master\n>  '\n>  -- 2.6.2.403.g6abe3ff.dirty\n"}]}