{"thread":{"id":"41100","subject":"[bug] Graph log and orphan branches","startedAt":"2015-12-30T19:46:08Z","lastAt":"2015-12-30T21:24:40Z","messageCount":6,"participants":["Carlos Pita","Junio C Hamano","Dennis Kaarsemaker"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"275192","messageId":"CAELgYhe4u2qU0-+mBKGwf8CpdZ=MuWMFZmeOhojtdMQZ3-nfhQ@mail.gmail.com","threadId":"41100","inReplyTo":null,"subject":"[bug] Graph log and orphan branches","fromName":"Carlos Pita","fromEmail":"carlosjosepita@gmail.com","sentAt":"2015-12-30T19:46:08Z","receivedAt":"2015-12-30T19:46:08Z","isPatch":false,"sender":{"key":"carlosjosepita@gmail.com","avatar":"https://gravatar.com/avatar/cf95d94f5258e3cbf21c26fb6fee0d7b16a1b26b6a19e33c805527c598197321?d=mp&s=160"},"body":"Hi all,\n\nthe graph output of log show orphan branches in a way that suggests\nthey have a parent. See for example:\n\nhttp://stackoverflow.com/questions/22541261/git-log-of-all-branchs-in-only-the-current-tree\n\nI think this is a bug in the UI.\n\nCheers\n--\nCarlos\n"},{"id":"275193","messageId":"CAELgYhe3Nosq3iPGsvqxJTnmZu5a_ayi4eKVdhPMfNaXVLZOXA@mail.gmail.com","threadId":"41100","inReplyTo":"CAELgYhe4u2qU0-+mBKGwf8CpdZ=MuWMFZmeOhojtdMQZ3-nfhQ@mail.gmail.com","subject":"Re: [bug] Graph log and orphan branches","fromName":"Carlos Pita","fromEmail":"carlosjosepita@gmail.com","sentAt":"2015-12-30T19:48:14Z","receivedAt":"2015-12-30T19:48:14Z","isPatch":false,"sender":{"key":"carlosjosepita@gmail.com","avatar":"https://gravatar.com/avatar/cf95d94f5258e3cbf21c26fb6fee0d7b16a1b26b6a19e33c805527c598197321?d=mp&s=160"},"body":"> http://stackoverflow.com/questions/22541261/git-log-of-all-branchs-in-only-the-current-tree\n>\n> I think this is a bug in the UI.\n\nPlease notice this happens only for the --oneline output.\n"},{"id":"275194","messageId":"xmqqziwremqh.fsf@gitster.mtv.corp.google.com","threadId":"41100","inReplyTo":"CAELgYhe4u2qU0-+mBKGwf8CpdZ=MuWMFZmeOhojtdMQZ3-nfhQ@mail.gmail.com","subject":"Re: [bug] Graph log and orphan branches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-30T19:54:14Z","receivedAt":"2015-12-30T19:54:14Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlos Pita writes:\n\n> the graph output of log show orphan branches in a way that suggests\n> they have a parent.\n\nReminds me of this ancient RFH topic\n\n http://thread.gmane.org/gmane.comp.version-control.git/236708/focus=239580\n\nwhich unfortunately got no help...\n"},{"id":"275197","messageId":"1451508209.9251.13.camel@kaarsemaker.net","threadId":"41100","inReplyTo":"xmqqziwremqh.fsf@gitster.mtv.corp.google.com","subject":"Re: [bug] Graph log and orphan branches","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2015-12-30T20:43:29Z","receivedAt":"2015-12-30T20:43:29Z","isPatch":false,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"On wo, 2015-12-30 at 11:54 -0800, Junio C Hamano wrote:\n> Carlos Pita writes:\n> \n> > the graph output of log show orphan branches in a way that suggests\n> > they have a parent.\n> \n> Reminds me of this ancient RFH topic\n> \n> http://thread.gmane.org/gmane.comp.version-control.git/236708/focus\n> =239580\n> \n> which unfortunately got no help...\n\nInstead of a blank line, why not something like this to make root\ncommits stand out a bit?\n\ndiff --git a/revision.c b/revision.c\nindex 0a282f5..e69a992 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -3346,7 +3346,7 @@ char *get_revision_mark(const struct rev_info *revs, const struct commit *commit\n else\n return \">\";\n } else if (revs->graph)\n- return \"*\";\n+ return commit->parents ? \"*\" : \"^\" ;\n else if (revs->cherry_mark)\n return \"+\";\n return \"\";\n\n-- \nDennis Kaarsemaker\nwww.kaarsemaker.net\n"},{"id":"275198","messageId":"CAELgYhf+EvcTHmZw3w4+WRg_wzJCo0b_Ft87J+1-rqJxeZ+r+g@mail.gmail.com","threadId":"41100","inReplyTo":"1451508209.9251.13.camel@kaarsemaker.net","subject":"Re: [bug] Graph log and orphan branches","fromName":"Carlos Pita","fromEmail":"carlosjosepita@gmail.com","sentAt":"2015-12-30T20:46:59Z","receivedAt":"2015-12-30T20:46:59Z","isPatch":false,"sender":{"key":"carlosjosepita@gmail.com","avatar":"https://gravatar.com/avatar/cf95d94f5258e3cbf21c26fb6fee0d7b16a1b26b6a19e33c805527c598197321?d=mp&s=160"},"body":"> - return \"*\";\n> + return commit->parents ? \"*\" : \"^\" ;\n\nI like this idea.\n"},{"id":"275200","messageId":"xmqqa8oreijr.fsf@gitster.mtv.corp.google.com","threadId":"41100","inReplyTo":"1451508209.9251.13.camel@kaarsemaker.net","subject":"Re: [bug] Graph log and orphan branches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-30T21:24:40Z","receivedAt":"2015-12-30T21:24:40Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dennis Kaarsemaker writes:\n\n> On wo, 2015-12-30 at 11:54 -0800, Junio C Hamano wrote:\n>> Carlos Pita writes:\n>> \n>> > the graph output of log show orphan branches in a way that suggests\n>> > they have a parent.\n>> \n>> Reminds me of this ancient RFH topic\n>> \n>> http://thread.gmane.org/gmane.comp.version-control.git/236708/focus\n>> =239580\n>> \n>> which unfortunately got no help...\n>\n> Instead of a blank line, why not something like this to make root\n> commits stand out a bit?\n>\n\nThat approach will lose information when a root commit is at the\nboundary, marked as uninteresting, or on the left/right side of\ntraversal (when --left-right is requested). As these pieces of\ninformation that will be lost with such an approach are a lot more\nrelevant than \"have we hit the root?\", especially in the majority of\nrepositories where there is only one root commit, I do not think it\nis acceptable.\n"}]}