{"thread":{"id":"41070","subject":"[PATCH 02/10] t/t5304-prune.sh: use the $( ... ) construct for command substitution","startedAt":"2015-12-23T13:45:48Z","lastAt":"2015-12-23T13:45:58Z","messageCount":11,"participants":["Elia Pinto"],"isPatch":true,"patchVersion":1,"patchTotal":10},"messages":[{"id":"274946","messageId":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":null,"subject":"[PATCH 00/10] use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:48Z","receivedAt":"2015-12-23T13:45:48Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"This patch series continues the changes introduced with the merge\n6753d8a85d543253d95184ec2faad6dc197f248:\n\n    Merge branch 'ep/shell-command-substitution'\n\n    Adjust shell scripts to use $(cmd) instead of `cmd`.\n\n\nThis is the fourth serie, the other will be sent separately.\n\n\nElia Pinto (10):\n  t/t5303-pack-corruption-resilience.sh: use the $( ... ) construct for\n    command substitution\n  t/t5304-prune.sh: use the $( ... ) construct for command substitution\n  t/t5305-include-tag.sh: use the $( ... ) construct for command\n    substitution\n  t/t5500-fetch-pack.sh: use the $( ... ) construct for command\n    substitution\n  t/t5505-remote.sh: use the $( ... ) construct for command substitution\n  t/t5506-remote-groups.sh: use the $( ... ) construct for command\n    substitution\n  t/t5510-fetch.sh: use the $( ... ) construct for command substitution\n  t/t5515-fetch-merge-logic.sh: use the $( ... ) construct for command\n    substitution\n  t/t5516-fetch-push.sh: use the $( ... ) construct for command\n    substitution\n  t/t5517-push-mirror.sh: use the $( ... ) construct for command\n    substitution\n\n t/t5303-pack-corruption-resilience.sh | 16 ++++++++--------\n t/t5304-prune.sh                      |  2 +-\n t/t5305-include-tag.sh                |  8 ++++----\n t/t5500-fetch-pack.sh                 | 20 ++++++++++----------\n t/t5505-remote.sh                     |  2 +-\n t/t5506-remote-groups.sh              |  2 +-\n t/t5510-fetch.sh                      | 10 +++++-----\n t/t5515-fetch-merge-logic.sh          |  4 ++--\n t/t5516-fetch-push.sh                 |  4 ++--\n t/t5517-push-mirror.sh                |  2 +-\n 10 files changed, 35 insertions(+), 35 deletions(-)\n\n-- \n2.3.3.GIT\n"},{"id":"274953","messageId":"1450878358-7422-2-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 01/10] t/t5303-pack-corruption-resilience.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:49Z","receivedAt":"2015-12-23T13:45:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5303-pack-corruption-resilience.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh\nindex 663b02b..5940ce2 100755\n--- a/t/t5303-pack-corruption-resilience.sh\n+++ b/t/t5303-pack-corruption-resilience.sh\n@@ -32,23 +32,23 @@ create_test_files() {\n create_new_pack() {\n     rm -rf .git &&\n     git init &&\n-    blob_1=`git hash-object -t blob -w file_1` &&\n-    blob_2=`git hash-object -t blob -w file_2` &&\n-    blob_3=`git hash-object -t blob -w file_3` &&\n-    pack=`printf \"$blob_1\\n$blob_2\\n$blob_3\\n\" |\n-          git pack-objects $@ .git/objects/pack/pack` &&\n+    blob_1=$(git hash-object -t blob -w file_1) &&\n+    blob_2=$(git hash-object -t blob -w file_2) &&\n+    blob_3=$(git hash-object -t blob -w file_3) &&\n+    pack=$(printf \"$blob_1\\n$blob_2\\n$blob_3\\n\" |\n+          git pack-objects $@ .git/objects/pack/pack) &&\n     pack=\".git/objects/pack/pack-${pack}\" &&\n     git verify-pack -v ${pack}.pack\n }\n \n do_repack() {\n-    pack=`printf \"$blob_1\\n$blob_2\\n$blob_3\\n\" |\n-          git pack-objects $@ .git/objects/pack/pack` &&\n+    pack=$(printf \"$blob_1\\n$blob_2\\n$blob_3\\n\" |\n+          git pack-objects $@ .git/objects/pack/pack) &&\n     pack=\".git/objects/pack/pack-${pack}\"\n }\n \n do_corrupt_object() {\n-    ofs=`git show-index < ${pack}.idx | grep $1 | cut -f1 -d\" \"` &&\n+    ofs=$(git show-index < ${pack}.idx | grep $1 | cut -f1 -d\" \") &&\n     ofs=$(($ofs + $2)) &&\n     chmod +w ${pack}.pack &&\n     dd of=${pack}.pack bs=1 conv=notrunc seek=$ofs &&\n-- \n2.3.3.GIT\n"},{"id":"274943","messageId":"1450878358-7422-3-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/10] t/t5304-prune.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:50Z","receivedAt":"2015-12-23T13:45:50Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5304-prune.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5304-prune.sh b/t/t5304-prune.sh\nindex def203c..133b584 100755\n--- a/t/t5304-prune.sh\n+++ b/t/t5304-prune.sh\n@@ -266,7 +266,7 @@ EOF\n '\n \n test_expect_success 'prune .git/shallow' '\n-\tSHA1=`echo hi|git commit-tree HEAD^{tree}` &&\n+\tSHA1=$(echo hi|git commit-tree HEAD^{tree}) &&\n \techo $SHA1 >.git/shallow &&\n \tgit prune --dry-run >out &&\n \tgrep $SHA1 .git/shallow &&\n-- \n2.3.3.GIT\n"},{"id":"274945","messageId":"1450878358-7422-4-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/10] t/t5305-include-tag.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:51Z","receivedAt":"2015-12-23T13:45:51Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5305-include-tag.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5305-include-tag.sh b/t/t5305-include-tag.sh\nindex 21517c7..f314ad5 100755\n--- a/t/t5305-include-tag.sh\n+++ b/t/t5305-include-tag.sh\n@@ -3,20 +3,20 @@\n test_description='git pack-object --include-tag'\n . ./test-lib.sh\n \n-TRASH=`pwd`\n+TRASH=$(pwd)\n \n test_expect_success setup '\n \techo c >d &&\n \tgit update-index --add d &&\n-\ttree=`git write-tree` &&\n-\tcommit=`git commit-tree $tree </dev/null` &&\n+\ttree=$(git write-tree) &&\n+\tcommit=$(git commit-tree $tree </dev/null) &&\n \techo \"object $commit\" >sig &&\n \techo \"type commit\" >>sig &&\n \techo \"tag mytag\" >>sig &&\n \techo \"tagger $(git var GIT_COMMITTER_IDENT)\" >>sig &&\n \techo >>sig &&\n \techo \"our test tag\" >>sig &&\n-\ttag=`git mktag <sig` &&\n+\ttag=$(git mktag <sig) &&\n \trm d sig &&\n \tgit update-ref refs/tags/mytag $tag && {\n \t\techo $tree &&\n-- \n2.3.3.GIT\n"},{"id":"274949","messageId":"1450878358-7422-5-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/10] t/t5500-fetch-pack.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:52Z","receivedAt":"2015-12-23T13:45:52Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5500-fetch-pack.sh | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh\nindex 3a9b775..e5f83bf 100755\n--- a/t/t5500-fetch-pack.sh\n+++ b/t/t5500-fetch-pack.sh\n@@ -14,7 +14,7 @@ test_description='Testing multi_ack pack fetching'\n add () {\n \tname=$1 &&\n \ttext=\"$@\" &&\n-\tbranch=`echo $name | sed -e 's/^\\(.\\).*$/\\1/'` &&\n+\tbranch=$(echo $name | sed -e 's/^\\(.\\).*$/\\1/') &&\n \tparents=\"\" &&\n \n \tshift &&\n@@ -50,18 +50,18 @@ pull_to_client () {\n \t\t\tcase \"$heads\" in *B*)\n \t\t\t    echo $BTIP > .git/refs/heads/B;;\n \t\t\tesac &&\n-\t\t\tgit symbolic-ref HEAD refs/heads/`echo $heads \\\n-\t\t\t\t| sed -e \"s/^\\(.\\).*$/\\1/\"` &&\n+\t\t\tgit symbolic-ref HEAD refs/heads/$(echo $heads \\\n+\t\t\t\t| sed -e \"s/^\\(.\\).*$/\\1/\") &&\n \n \t\t\tgit fsck --full &&\n \n \t\t\tmv .git/objects/pack/pack-* . &&\n-\t\t\tp=`ls -1 pack-*.pack` &&\n+\t\t\tp=$(ls -1 pack-*.pack) &&\n \t\t\tgit unpack-objects <$p &&\n \t\t\tgit fsck --full &&\n \n-\t\t\tidx=`echo pack-*.idx` &&\n-\t\t\tpack_count=`git show-index <$idx | wc -l` &&\n+\t\t\tidx=$(echo pack-*.idx) &&\n+\t\t\tpack_count=$(git show-index <$idx | wc -l) &&\n \t\t\ttest $pack_count = $count &&\n \t\t\trm -f pack-*\n \t\t)\n@@ -132,13 +132,13 @@ test_expect_success 'single given branch clone' '\n \n test_expect_success 'clone shallow depth 1' '\n \tgit clone --no-single-branch --depth 1 \"file://$(pwd)/.\" shallow0 &&\n-\ttest \"`git --git-dir=shallow0/.git rev-list --count HEAD`\" = 1\n+\ttest \"$(git --git-dir=shallow0/.git rev-list --count HEAD)\" = 1\n '\n \n test_expect_success 'clone shallow depth 1 with fsck' '\n \tgit config --global fetch.fsckobjects true &&\n \tgit clone --no-single-branch --depth 1 \"file://$(pwd)/.\" shallow0fsck &&\n-\ttest \"`git --git-dir=shallow0fsck/.git rev-list --count HEAD`\" = 1 &&\n+\ttest \"$(git --git-dir=shallow0fsck/.git rev-list --count HEAD)\" = 1 &&\n \tgit config --global --unset fetch.fsckobjects\n '\n \n@@ -147,7 +147,7 @@ test_expect_success 'clone shallow' '\n '\n \n test_expect_success 'clone shallow depth count' '\n-\ttest \"`git --git-dir=shallow/.git rev-list --count HEAD`\" = 2\n+\ttest \"$(git --git-dir=shallow/.git rev-list --count HEAD)\" = 2\n '\n \n test_expect_success 'clone shallow object count' '\n@@ -273,7 +273,7 @@ test_expect_success 'additional simple shallow deepenings' '\n '\n \n test_expect_success 'clone shallow depth count' '\n-\ttest \"`git --git-dir=shallow/.git rev-list --count HEAD`\" = 11\n+\ttest \"$(git --git-dir=shallow/.git rev-list --count HEAD)\" = 11\n '\n \n test_expect_success 'clone shallow object count' '\n-- \n2.3.3.GIT\n"},{"id":"274952","messageId":"1450878358-7422-6-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/10] t/t5505-remote.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:53Z","receivedAt":"2015-12-23T13:45:53Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5505-remote.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5505-remote.sh b/t/t5505-remote.sh\nindex dfaf9d9..1a8e3b8 100755\n--- a/t/t5505-remote.sh\n+++ b/t/t5505-remote.sh\n@@ -85,7 +85,7 @@ test_expect_success C_LOCALE_OUTPUT 'check remote-tracking' '\n test_expect_success 'remote forces tracking branches' '\n \t(\n \t\tcd test &&\n-\t\tcase `git config remote.second.fetch` in\n+\t\tcase $(git config remote.second.fetch) in\n \t\t+*) true ;;\n \t\t *) false ;;\n \t\tesac\n-- \n2.3.3.GIT\n"},{"id":"274947","messageId":"1450878358-7422-7-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/10] t/t5506-remote-groups.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:54Z","receivedAt":"2015-12-23T13:45:54Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5506-remote-groups.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5506-remote-groups.sh b/t/t5506-remote-groups.sh\nindex 530b016..83d5558 100755\n--- a/t/t5506-remote-groups.sh\n+++ b/t/t5506-remote-groups.sh\n@@ -20,7 +20,7 @@ update_repos() {\n }\n \n repo_fetched() {\n-\tif test \"`git log -1 --pretty=format:%s $1 --`\" = \"`cat mark`\"; then\n+\tif test \"$(git log -1 --pretty=format:%s $1 --)\" = \"$(cat mark)\"; then\n \t\techo >&2 \"repo was fetched: $1\"\n \t\treturn 0\n \tfi\n-- \n2.3.3.GIT\n"},{"id":"274951","messageId":"1450878358-7422-8-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/10] t/t5510-fetch.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:55Z","receivedAt":"2015-12-23T13:45:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5510-fetch.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh\nindex 0ba9db0..47e68a5 100755\n--- a/t/t5510-fetch.sh\n+++ b/t/t5510-fetch.sh\n@@ -7,7 +7,7 @@ test_description='Per branch config variables affects \"git fetch\".\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n test_bundle_object_count () {\n \tgit verify-pack -v \"$1\" >verify.out &&\n@@ -64,8 +64,8 @@ test_expect_success \"fetch test\" '\n \tcd two &&\n \tgit fetch &&\n \ttest -f .git/refs/heads/one &&\n-\tmine=`git rev-parse refs/heads/one` &&\n-\this=`cd ../one && git rev-parse refs/heads/master` &&\n+\tmine=$(git rev-parse refs/heads/one) &&\n+\this=$(cd ../one && git rev-parse refs/heads/master) &&\n \ttest \"z$mine\" = \"z$his\"\n '\n \n@@ -75,8 +75,8 @@ test_expect_success \"fetch test for-merge\" '\n \tgit fetch &&\n \ttest -f .git/refs/heads/two &&\n \ttest -f .git/refs/heads/one &&\n-\tmaster_in_two=`cd ../two && git rev-parse master` &&\n-\tone_in_two=`cd ../two && git rev-parse one` &&\n+\tmaster_in_two=$(cd ../two && git rev-parse master) &&\n+\tone_in_two=$(cd ../two && git rev-parse one) &&\n \t{\n \t\techo \"$one_in_two\t\"\n \t\techo \"$master_in_two\tnot-for-merge\"\n-- \n2.3.3.GIT\n"},{"id":"274944","messageId":"1450878358-7422-9-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/10] t/t5515-fetch-merge-logic.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:56Z","receivedAt":"2015-12-23T13:45:56Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5515-fetch-merge-logic.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5515-fetch-merge-logic.sh b/t/t5515-fetch-merge-logic.sh\nindex dbb927d..36b0dbc 100755\n--- a/t/t5515-fetch-merge-logic.sh\n+++ b/t/t5515-fetch-merge-logic.sh\n@@ -128,8 +128,8 @@ do\n \tcase \"$cmd\" in\n \t'' | '#'*) continue ;;\n \tesac\n-\ttest=`echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g'`\n-\tpfx=`printf \"%04d\" $test_count`\n+\ttest=$(echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g')\n+\tpfx=$(printf \"%04d\" $test_count)\n \texpect_f=\"$TEST_DIRECTORY/t5515/fetch.$test\"\n \tactual_f=\"$pfx-fetch.$test\"\n \texpect_r=\"$TEST_DIRECTORY/t5515/refs.$test\"\n-- \n2.3.3.GIT\n"},{"id":"274948","messageId":"1450878358-7422-10-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/10] t/t5516-fetch-push.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:57Z","receivedAt":"2015-12-23T13:45:57Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5516-fetch-push.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh\nindex 0a87e19..26b2caf 100755\n--- a/t/t5516-fetch-push.sh\n+++ b/t/t5516-fetch-push.sh\n@@ -16,7 +16,7 @@ This test checks the following functionality:\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n mk_empty () {\n \trepo_name=\"$1\"\n@@ -422,7 +422,7 @@ test_expect_success 'push tag with non-existent, incomplete dest' '\n test_expect_success 'push sha1 with non-existent, incomplete dest' '\n \n \tmk_test testrepo &&\n-\ttest_must_fail git push testrepo `git rev-parse master`:foo\n+\ttest_must_fail git push testrepo $(git rev-parse master):foo\n \n '\n \n-- \n2.3.3.GIT\n"},{"id":"274950","messageId":"1450878358-7422-11-git-send-email-gitter.spiros@gmail.com","threadId":"41070","inReplyTo":"1450878358-7422-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/10] t/t5517-push-mirror.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-23T13:45:58Z","receivedAt":"2015-12-23T13:45:58Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX.  However, all but the\nsimplest uses become complicated quickly.  In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg'  \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5517-push-mirror.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5517-push-mirror.sh b/t/t5517-push-mirror.sh\nindex 12a5dfb..02f160a 100755\n--- a/t/t5517-push-mirror.sh\n+++ b/t/t5517-push-mirror.sh\n@@ -4,7 +4,7 @@ test_description='pushing to a mirror repository'\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n invert () {\n \tif \"$@\"; then\n-- \n2.3.3.GIT\n"}]}