{"thread":{"id":"41063","subject":"[PATCH 02/10] t3210-pack-refs.sh: use the $( ... ) construct for command substitution","startedAt":"2015-12-22T15:27:43Z","lastAt":"2015-12-28T07:44:20Z","messageCount":16,"participants":["Elia Pinto","Johannes Sixt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":10},"messages":[{"id":"274877","messageId":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":null,"subject":"[PATCH 00/10] use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:43Z","receivedAt":"2015-12-22T15:27:43Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"This patch series continues the changes introduced with the merge\n6753d8a85d543253d95184ec2faad6dc197f248:\n\n Merge branch 'ep/shell-command-substitution'\n\n Adjust shell scripts to use $(cmd) instead of `cmd`.\n\n\nThis is the third serie, the other will be sent separately.\n\n\nElia Pinto (10):\n t3101-ls-tree-dirname.sh: use the $( ... ) construct for command\n substitution\n t3210-pack-refs.sh: use the $( ... ) construct for command\n substitution\n t3403-rebase-skip.sh: use the $( ... ) construct for command\n substitution\n t3511-cherry-pick-x.sh: use the $( ... ) construct for command\n substitution\n t3600-rm.sh: use the $( ... ) construct for command substitution\n t3700-add.sh: use the $( ... ) construct for command substitution\n t5100-mailinfo.sh: use the $( ... ) construct for command substitution\n t5300-pack-object.sh: use the $( ... ) construct for command\n substitution\n t5301-sliding-window.sh: use the $( ... ) construct for command\n substitution\n t5302-pack-index.sh: use the $( ... ) construct for command\n substitution\n\n t/t3101-ls-tree-dirname.sh | 2 +-\n t/t3210-pack-refs.sh | 2 +-\n t/t3403-rebase-skip.sh | 2 +-\n t/t3511-cherry-pick-x.sh | 14 +++++++-------\n t/t3600-rm.sh | 4 ++--\n t/t3700-add.sh | 16 ++++++++--------\n t/t5100-mailinfo.sh | 12 ++++++------\n t/t5300-pack-object.sh | 18 +++++++++---------\n t/t5301-sliding-window.sh | 14 +++++++-------\n t/t5302-pack-index.sh | 34 +++++++++++++++++-----------------\n 10 files changed, 59 insertions(+), 59 deletions(-)\n\n-- \n2.3.3.GIT\n"},{"id":"274884","messageId":"1450798073-22811-2-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 01/10] t3101-ls-tree-dirname.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:44Z","receivedAt":"2015-12-22T15:27:44Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3101-ls-tree-dirname.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3101-ls-tree-dirname.sh b/t/t3101-ls-tree-dirname.sh\nindex 026f9f8..425d858 100755\n--- a/t/t3101-ls-tree-dirname.sh\n+++ b/t/t3101-ls-tree-dirname.sh\n@@ -35,7 +35,7 @@ test_expect_success 'setup' '\n \techo 222 >path3/2.txt &&\n \tfind *.txt path* \\( -type f -o -type l \\) -print |\n \txargs git update-index --add &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \techo $tree\n '\n \n-- \n2.3.3.GIT\n"},{"id":"274876","messageId":"1450798073-22811-3-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/10] t3210-pack-refs.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:45Z","receivedAt":"2015-12-22T15:27:45Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3210-pack-refs.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3210-pack-refs.sh b/t/t3210-pack-refs.sh\nindex db244d2..9b182a0 100755\n--- a/t/t3210-pack-refs.sh\n+++ b/t/t3210-pack-refs.sh\n@@ -27,7 +27,7 @@ SHA1=\n test_expect_success \\\n 'see if git show-ref works as expected' \\\n 'git branch a &&\n- SHA1=`cat .git/refs/heads/a` &&\n+ SHA1=$(cat .git/refs/heads/a) &&\n echo \"$SHA1 refs/heads/a\" >expect &&\n git show-ref a >result &&\n test_cmp expect result'\n-- \n2.3.3.GIT\n"},{"id":"274885","messageId":"1450798073-22811-4-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/10] t3403-rebase-skip.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:46Z","receivedAt":"2015-12-22T15:27:46Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3403-rebase-skip.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3403-rebase-skip.sh b/t/t3403-rebase-skip.sh\nindex 3968020..1f5122b 100755\n--- a/t/t3403-rebase-skip.sh\n+++ b/t/t3403-rebase-skip.sh\n@@ -67,7 +67,7 @@ test_expect_success 'rebase --skip with --merge' '\n '\n \n test_expect_success 'merge and reference trees equal' '\n-\ttest -z \"`git diff-tree skip-merge skip-reference`\"\n+\ttest -z \"$(git diff-tree skip-merge skip-reference)\"\n '\n \n test_expect_success 'moved back to branch correctly' '\n-- \n2.3.3.GIT\n"},{"id":"274886","messageId":"1450798073-22811-5-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/10] t3511-cherry-pick-x.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:47Z","receivedAt":"2015-12-22T15:27:47Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3511-cherry-pick-x.sh | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t3511-cherry-pick-x.sh b/t/t3511-cherry-pick-x.sh\nindex b7dff09..9cce5ae 100755\n--- a/t/t3511-cherry-pick-x.sh\n+++ b/t/t3511-cherry-pick-x.sh\n@@ -77,7 +77,7 @@ test_expect_success setup '\n \n test_expect_success 'cherry-pick -x inserts blank line after one line subject' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-one-line^0` &&\n+\tsha1=$(git rev-parse mesg-one-line^0) &&\n \tgit cherry-pick -x mesg-one-line &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_one_line\n@@ -114,7 +114,7 @@ test_expect_success 'cherry-pick -s inserts blank line after non-conforming foot\n \n test_expect_success 'cherry-pick -x inserts blank line when conforming footer not found' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-no-footer^0` &&\n+\tsha1=$(git rev-parse mesg-no-footer^0) &&\n \tgit cherry-pick -x mesg-no-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_no_footer\n@@ -139,7 +139,7 @@ test_expect_success 'cherry-pick -s inserts blank line when conforming footer no\n \n test_expect_success 'cherry-pick -x -s inserts blank line when conforming footer not found' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-no-footer^0` &&\n+\tsha1=$(git rev-parse mesg-no-footer^0) &&\n \tgit cherry-pick -x -s mesg-no-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_no_footer\n@@ -164,7 +164,7 @@ test_expect_success 'cherry-pick -s adds sob when last sob doesnt match committe\n \n test_expect_success 'cherry-pick -x -s adds sob when last sob doesnt match committer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-footer^0` &&\n+\tsha1=$(git rev-parse mesg-with-footer^0) &&\n \tgit cherry-pick -x -s mesg-with-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_footer\n@@ -187,7 +187,7 @@ test_expect_success 'cherry-pick -s refrains from adding duplicate trailing sob'\n \n test_expect_success 'cherry-pick -x -s adds sob even when trailing sob exists for committer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-footer-sob^0` &&\n+\tsha1=$(git rev-parse mesg-with-footer-sob^0) &&\n \tgit cherry-pick -x -s mesg-with-footer-sob &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_footer_sob\n@@ -200,7 +200,7 @@ test_expect_success 'cherry-pick -x -s adds sob even when trailing sob exists fo\n \n test_expect_success 'cherry-pick -x treats \"(cherry picked from...\" line as part of footer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-cherry-footer^0` &&\n+\tsha1=$(git rev-parse mesg-with-cherry-footer^0) &&\n \tgit cherry-pick -x mesg-with-cherry-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_cherry_footer\n@@ -223,7 +223,7 @@ test_expect_success 'cherry-pick -s treats \"(cherry picked from...\" line as part\n \n test_expect_success 'cherry-pick -x -s treats \"(cherry picked from...\" line as part of footer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-cherry-footer^0` &&\n+\tsha1=$(git rev-parse mesg-with-cherry-footer^0) &&\n \tgit cherry-pick -x -s mesg-with-cherry-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_cherry_footer\n-- \n2.3.3.GIT\n"},{"id":"274881","messageId":"1450798073-22811-6-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/10] t3600-rm.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:48Z","receivedAt":"2015-12-22T15:27:48Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3600-rm.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3600-rm.sh b/t/t3600-rm.sh\nindex 9d90d2c..2e47a2b 100755\n--- a/t/t3600-rm.sh\n+++ b/t/t3600-rm.sh\n@@ -115,7 +115,7 @@ test_expect_success '\"rm\" command printed' '\n \tgit add test-file &&\n \tgit commit -m \"add file for rm test\" &&\n \tgit rm test-file > rm-output &&\n-\ttest `grep \"^rm \" rm-output | wc -l` = 1 &&\n+\ttest $(grep \"^rm \" rm-output | wc -l) = 1 &&\n \trm -f test-file rm-output &&\n \tgit commit -m \"remove file from rm test\"\n '\n@@ -125,7 +125,7 @@ test_expect_success '\"rm\" command suppressed with --quiet' '\n \tgit add test-file &&\n \tgit commit -m \"add file for rm --quiet test\" &&\n \tgit rm --quiet test-file > rm-output &&\n-\ttest `wc -l < rm-output` = 0 &&\n+\ttest $(wc -l < rm-output) = 0 &&\n \trm -f test-file rm-output &&\n \tgit commit -m \"remove file from rm --quiet test\"\n '\n-- \n2.3.3.GIT\n"},{"id":"274878","messageId":"1450798073-22811-7-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/10] t3700-add.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:49Z","receivedAt":"2015-12-22T15:27:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3700-add.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t3700-add.sh b/t/t3700-add.sh\nindex f7ff1f5..f14a665 100755\n--- a/t/t3700-add.sh\n+++ b/t/t3700-add.sh\n@@ -25,7 +25,7 @@ test_expect_success \\\n \t echo foo >xfoo1 &&\n \t chmod 755 xfoo1 &&\n \t git add xfoo1 &&\n-\t case \"`git ls-files --stage xfoo1`\" in\n+\t case \"$(git ls-files --stage xfoo1)\" in\n \t 100644\" \"*xfoo1) echo pass;;\n \t *) echo fail; git ls-files --stage xfoo1; (exit 1);;\n \t esac'\n@@ -33,7 +33,7 @@ test_expect_success \\\n test_expect_success 'git add: filemode=0 should not get confused by symlink' '\n \trm -f xfoo1 &&\n \ttest_ln_s_add foo xfoo1 &&\n-\tcase \"`git ls-files --stage xfoo1`\" in\n+\tcase \"$(git ls-files --stage xfoo1)\" in\n \t120000\" \"*xfoo1) echo pass;;\n \t*) echo fail; git ls-files --stage xfoo1; (exit 1);;\n \tesac\n@@ -45,7 +45,7 @@ test_expect_success \\\n \t echo foo >xfoo2 &&\n \t chmod 755 xfoo2 &&\n \t git update-index --add xfoo2 &&\n-\t case \"`git ls-files --stage xfoo2`\" in\n+\t case \"$(git ls-files --stage xfoo2)\" in\n \t 100644\" \"*xfoo2) echo pass;;\n \t *) echo fail; git ls-files --stage xfoo2; (exit 1);;\n \t esac'\n@@ -53,7 +53,7 @@ test_expect_success \\\n test_expect_success 'git add: filemode=0 should not get confused by symlink' '\n \trm -f xfoo2 &&\n \ttest_ln_s_add foo xfoo2 &&\n-\tcase \"`git ls-files --stage xfoo2`\" in\n+\tcase \"$(git ls-files --stage xfoo2)\" in\n \t120000\" \"*xfoo2) echo pass;;\n \t*) echo fail; git ls-files --stage xfoo2; (exit 1);;\n \tesac\n@@ -63,7 +63,7 @@ test_expect_success \\\n \t'git update-index --add: Test that executable bit is not used...' \\\n \t'git config core.filemode 0 &&\n \t test_ln_s_add xfoo2 xfoo3 &&\t# runs git update-index --add\n-\t case \"`git ls-files --stage xfoo3`\" in\n+\t case \"$(git ls-files --stage xfoo3)\" in\n \t 120000\" \"*xfoo3) echo pass;;\n \t *) echo fail; git ls-files --stage xfoo3; (exit 1);;\n \t esac'\n@@ -173,14 +173,14 @@ test_expect_success 'git add with filemode=0, symlinks=0 prefers stage 2 over st\n \n test_expect_success 'git add --refresh' '\n \t>foo && git add foo && git commit -a -m \"commit all\" &&\n-\ttest -z \"`git diff-index HEAD -- foo`\" &&\n+\ttest -z \"$(git diff-index HEAD -- foo)\" &&\n \tgit read-tree HEAD &&\n-\tcase \"`git diff-index HEAD -- foo`\" in\n+\tcase \"$(git diff-index HEAD -- foo)\" in\n \t:100644\" \"*\"M\tfoo\") echo pass;;\n \t*) echo fail; (exit 1);;\n \tesac &&\n \tgit add --refresh -- foo &&\n-\ttest -z \"`git diff-index HEAD -- foo`\"\n+\ttest -z \"$(git diff-index HEAD -- foo)\"\n '\n \n test_expect_success 'git add --refresh with pathspec' '\n-- \n2.3.3.GIT\n"},{"id":"274882","messageId":"1450798073-22811-8-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:50Z","receivedAt":"2015-12-22T15:27:50Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t5100-mailinfo.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh\nindex e97cfb2..4e52b3b 100755\n--- a/t/t5100-mailinfo.sh\n+++ b/t/t5100-mailinfo.sh\n@@ -9,9 +9,9 @@ test_description='git mailinfo and git mailsplit test'\n \n test_expect_success 'split sample box' \\\n \t'git mailsplit -o. \"$TEST_DIRECTORY\"/t5100/sample.mbox >last &&\n-\tlast=`cat last` &&\n+\tlast=$(cat last) &&\n \techo total is $last &&\n-\ttest `cat last` = 17'\n+\ttest $(cat last) = 17'\n \n check_mailinfo () {\n \tmail=$1 opt=$2\n@@ -23,7 +23,7 @@ check_mailinfo () {\n }\n \n \n-for mail in `echo 00*`\n+for mail in $(echo 00*)\n do\n \ttest_expect_success \"mailinfo $mail\" '\n \t\tcheck_mailinfo $mail \"\" &&\n@@ -47,11 +47,11 @@ test_expect_success 'split box with rfc2047 samples' \\\n \t'mkdir rfc2047 &&\n \tgit mailsplit -orfc2047 \"$TEST_DIRECTORY\"/t5100/rfc2047-samples.mbox \\\n \t >rfc2047/last &&\n-\tlast=`cat rfc2047/last` &&\n+\tlast=$(cat rfc2047/last) &&\n \techo total is $last &&\n-\ttest `cat rfc2047/last` = 11'\n+\ttest $(cat rfc2047/last) = 11'\n \n-for mail in `echo rfc2047/00*`\n+for mail in $(echo rfc2047/00*)\n do\n \ttest_expect_success \"mailinfo $mail\" '\n \t\tgit mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&\n-- \n2.3.3.GIT\n"},{"id":"274883","messageId":"1450798073-22811-9-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/10] t5300-pack-object.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:51Z","receivedAt":"2015-12-22T15:27:51Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t5300-pack-object.sh | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\nindex 20c1961..fc2be63 100755\n--- a/t/t5300-pack-object.sh\n+++ b/t/t5300-pack-object.sh\n@@ -8,7 +8,7 @@ test_description='git pack-object\n '\n . ./test-lib.sh\n \n-TRASH=`pwd`\n+TRASH=$(pwd)\n \n test_expect_success \\\n 'setup' \\\n@@ -20,8 +20,8 @@ test_expect_success \\\n test-genrandom \"seed b\" 2097152 > b_big &&\n git update-index --add a a_big b b_big c &&\n cat c >d && echo foo >>d && git update-index --add d &&\n- tree=`git write-tree` &&\n- commit=`git commit-tree $tree expect'\n@@ -147,7 +147,7 @@ test_expect_success \\\n \t git diff-tree --root -p $commit &&\n \t while read object\n \t do\n-\t t=`git cat-file -t $object` &&\n+\t t=$(git cat-file -t $object) &&\n \t git cat-file $t $object || return 1\n \t done current &&\n@@ -162,7 +162,7 @@ test_expect_success \\\n \t git diff-tree --root -p $commit &&\n \t while read object\n \t do\n-\t t=`git cat-file -t $object` &&\n+\t t=$(git cat-file -t $object) &&\n \t git cat-file $t $object || return 1\n \t done current &&\n@@ -177,7 +177,7 @@ test_expect_success \\\n \t git diff-tree --root -p $commit &&\n \t while read object\n \t do\n-\t t=`git cat-file -t $object` &&\n+\t t=$(git cat-file -t $object) &&\n \t git cat-file $t $object || return 1\n \t done current &&\n@@ -252,8 +252,8 @@ test_expect_success \\\n \n test_expect_success \\\n 'verify-pack catches a corrupted sum of the index file itself' \\\n- 'l=`wc -c test-3.pack &&\n printf \"%20s\" \"\" | dd of=test-3.idx count=20 bs=1 conv=notrunc seek=$l &&\n if git verify-pack test-3.pack\n-- \n2.3.3.GIT\n"},{"id":"274880","messageId":"1450798073-22811-10-git-send-email-gitter.spiros@gmail.com","threadId":"41063","inReplyTo":"1450798073-22811-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/10] t5301-sliding-window.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:27:52Z","receivedAt":"2015-12-22T15:27:52Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t5301-sliding-window.sh | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t5301-sliding-window.sh b/t/t5301-sliding-window.sh\nindex 2fc5af6..cae8c2e 100755\n--- a/t/t5301-sliding-window.sh\n+++ b/t/t5301-sliding-window.sh\n@@ -16,12 +16,12 @@ test_expect_success \\\n git update-index --add $i || return 1\n done &&\n echo d >d && cat c >>d && git update-index --add d &&\n- tree=`git write-tree` &&\n- commit1=`git commit-tree $tree \n---\n t/t5302-pack-index.sh | 34 +++++++++++++++++-----------------\n 1 file changed, 17 insertions(+), 17 deletions(-)\n\ndiff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh\nindex 3dc5ec4..c2fc584 100755\n--- a/t/t5302-pack-index.sh\n+++ b/t/t5302-pack-index.sh\n@@ -14,21 +14,21 @@ test_expect_success \\\n i=1 &&\n while test $i -le 100\n do\n- iii=`printf '%03i' $i`\n+ iii=$(printf '%03i' $i)\n test-genrandom \"bar\" 200 > wide_delta_$iii &&\n test-genrandom \"baz $iii\" 50 >> wide_delta_$iii &&\n test-genrandom \"foo\"$i 100 > deep_delta_$iii &&\n- test-genrandom \"foo\"`expr $i + 1` 100 >> deep_delta_$iii &&\n- test-genrandom \"foo\"`expr $i + 2` 100 >> deep_delta_$iii &&\n+ test-genrandom \"foo\"$(expr $i + 1) 100 >> deep_delta_$iii &&\n+ test-genrandom \"foo\"$(expr $i + 2) 100 >> deep_delta_$iii &&\n echo $iii >file_$iii &&\n test-genrandom \"$iii\" 8192 >>file_$iii &&\n git update-index --add file_$iii deep_delta_$iii wide_delta_$iii &&\n- i=`expr $i + 1` || return 1\n+ i=$(expr $i + 1) || return 1\n done &&\n { echo 101 && test-genrandom 100 8192; } >file_101 &&\n git update-index --add file_101 &&\n- tree=`git write-tree` &&\n- commit=`git commit-tree $tree obj-list &&\n@@ -152,10 +152,10 @@ test_expect_success \\\n '[index v1] 2) create a stealth corruption in a delta base reference' \\\n '# This test assumes file_101 is a delta smaller than 16 bytes.\n # It should be against file_100 but we substitute its base for file_099\n- sha1_101=`git hash-object file_101` &&\n- sha1_099=`git hash-object file_099` &&\n- offs_101=`index_obj_offset 1.idx $sha1_101` &&\n- nr_099=`index_obj_nr 1.idx $sha1_099` &&\n+ sha1_101=$(git hash-object file_101) &&\n+ sha1_099=$(git hash-object file_099) &&\n+ offs_101=$(index_obj_offset 1.idx $sha1_101) &&\n+ nr_099=$(index_obj_nr 1.idx $sha1_099) &&\n chmod +w \".git/objects/pack/pack-${pack1}.pack\" &&\n dd of=\".git/objects/pack/pack-${pack1}.pack\" seek=$(($offs_101 + 1)) \\\n if=\".git/objects/pack/pack-${pack1}.idx\" \\\n@@ -193,10 +193,10 @@ test_expect_success \\\n '[index v2] 2) create a stealth corruption in a delta base reference' \\\n '# This test assumes file_101 is a delta smaller than 16 bytes.\n # It should be against file_100 but we substitute its base for file_099\n- sha1_101=`git hash-object file_101` &&\n- sha1_099=`git hash-object file_099` &&\n- offs_101=`index_obj_offset 1.idx $sha1_101` &&\n- nr_099=`index_obj_nr 1.idx $sha1_099` &&\n+ sha1_101=$(git hash-object file_101) &&\n+ sha1_099=$(git hash-object file_099) &&\n+ offs_101=$(index_obj_offset 1.idx $sha1_101) &&\n+ nr_099=$(index_obj_nr 1.idx $sha1_099) &&\n chmod +w \".git/objects/pack/pack-${pack1}.pack\" &&\n dd of=\".git/objects/pack/pack-${pack1}.pack\" seek=$(($offs_101 + 1)) \\\n if=\".git/objects/pack/pack-${pack1}.idx\" \\\n@@ -222,11 +222,11 @@ test_expect_success \\\n 'rm -f .git/objects/pack/* &&\n git index-pack --index-version=2 --stdin < \"test-1-${pack1}.pack\" &&\n git verify-pack \".git/objects/pack/pack-${pack1}.pack\" &&\n- obj=`git hash-object file_001` &&\n- nr=`index_obj_nr \".git/objects/pack/pack-${pack1}.idx\" $obj` &&\n+ obj=$(git hash-object file_001) &&\n+ nr=$(index_obj_nr \".git/objects/pack/pack-${pack1}.idx\" $obj) &&\n chmod +w \".git/objects/pack/pack-${pack1}.idx\" &&\n printf xxxx | dd of=\".git/objects/pack/pack-${pack1}.idx\" conv=notrunc \\\n- bs=1 count=4 seek=$((8 + 256 * 4 + `wc -l /dev/null || exit 1\n done -for mail in `echo 00*`\n> +for mail in $(echo 00*)\n\n> -for mail in `echo rfc2047/00*`\n> +for mail in $(echo rfc2047/00*)\n\nTrue, these are equvalence transformations. But a better way to get rid \nof the back-quotes is to write these lines as\n\nfor mail in echo 00*\nfor mail in echo rfc2047/00*\n\nNo?\n\n-- Hannes\n"},{"id":"274913","messageId":"5679B3E2.7090406@kdbg.org","threadId":"41063","inReplyTo":"567997E4.1000700@kdbg.org","subject":"Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2015-12-22T20:34:42Z","receivedAt":"2015-12-22T20:34:42Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 22.12.2015 um 19:35 schrieb Johannes Sixt:\n> Am 22.12.2015 um 16:27 schrieb Elia Pinto:\n>> -for mail in `echo 00*`\n>> +for mail in $(echo 00*)\n>\n>> -for mail in `echo rfc2047/00*`\n>> +for mail in $(echo rfc2047/00*)\n>\n> True, these are equvalence transformations. But a better way to get rid\n> of the back-quotes is to write these lines as\n>\n> for mail in echo 00*\n> for mail in echo rfc2047/00*\n\nAhem... both of these lines without the 'echo', of course!\n\n>\n> No?\n>\n> -- Hannes\n>\n"},{"id":"275030","messageId":"xmqq7fjzbgkr.fsf@gitster.mtv.corp.google.com","threadId":"41063","inReplyTo":"5679B3E2.7090406@kdbg.org","subject":"Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-27T23:46:28Z","receivedAt":"2015-12-27T23:46:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt writes:\n\n> Am 22.12.2015 um 19:35 schrieb Johannes Sixt:\n>> Am 22.12.2015 um 16:27 schrieb Elia Pinto:\n>>> -for mail in `echo 00*`\n>>> +for mail in $(echo 00*)\n>>\n>>> -for mail in `echo rfc2047/00*`\n>>> +for mail in $(echo rfc2047/00*)\n>>\n>> True, these are equvalence transformations. But a better way to get rid\n>> of the back-quotes is to write these lines as\n>>\n>> for mail in echo 00*\n>> for mail in echo rfc2047/00*\n>\n> Ahem... both of these lines without the 'echo', of course!\n\nVery true. Let's leave that kind of things as separate clean-ups\nafter these patches settle, as mixing manual and mechanical changes\nin a single patch makes it harder to review.\n\nThanks.\n"},{"id":"275031","messageId":"xmqq37unbaff.fsf@gitster.mtv.corp.google.com","threadId":"41063","inReplyTo":"xmqq7fjzbgkr.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-28T01:59:16Z","receivedAt":"2015-12-28T01:59:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Very true. Let's leave that kind of things as separate clean-ups\n> after these patches settle, as mixing manual and mechanical changes\n> in a single patch makes it harder to review.\n>\n> Thanks.\n\nSo that I won't forget (I'll need to amend with your sign-off even\nif this one is satisfactory to you).\n\n-- >8 --\nFrom: Johannes Sixt \nDate: Tue, 22 Dec 2015 19:35:16 +0100\nSubject: [PATCH] t5100: no need to use 'echo' command substitutions for globbing\n\nInstead of making the shell expand 00* and invoke 'echo' with it,\nand then capturing its output as command substitution, just use\nthe result of expanding 00* directly.\n\nSigned-off-by: Junio C Hamano \n---\n t/t5100-mailinfo.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh\nindex 4e52b3b..85b3df5 100755\n--- a/t/t5100-mailinfo.sh\n+++ b/t/t5100-mailinfo.sh\n@@ -23,7 +23,7 @@ check_mailinfo () {\n }\n \n \n-for mail in $(echo 00*)\n+for mail in 00*\n do\n \ttest_expect_success \"mailinfo $mail\" '\n \t\tcheck_mailinfo $mail \"\" &&\n@@ -51,7 +51,7 @@ test_expect_success 'split box with rfc2047 samples' \\\n \techo total is $last &&\n \ttest $(cat rfc2047/last) = 11'\n \n-for mail in $(echo rfc2047/00*)\n+for mail in rfc2047/00*\n do\n \ttest_expect_success \"mailinfo $mail\" '\n \t\tgit mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&\n-- \n2.7.0-rc2-145-g5695473\n"},{"id":"275037","messageId":"5680E854.7050001@kdbg.org","threadId":"41063","inReplyTo":"xmqq37unbaff.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2015-12-28T07:44:20Z","receivedAt":"2015-12-28T07:44:20Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 28.12.2015 um 02:59 schrieb Junio C Hamano:\n> Junio C Hamano writes:\n>\n>> Very true. Let's leave that kind of things as separate clean-ups\n>> after these patches settle, as mixing manual and mechanical changes\n>> in a single patch makes it harder to review.\n>>\n>> Thanks.\n>\n> So that I won't forget (I'll need to amend with your sign-off even\n> if this one is satisfactory to you).\n>\n> -- >8 --\n> From: Johannes Sixt \n> Date: Tue, 22 Dec 2015 19:35:16 +0100\n> Subject: [PATCH] t5100: no need to use 'echo' command substitutions for globbing\n>\n> Instead of making the shell expand 00* and invoke 'echo' with it,\n> and then capturing its output as command substitution, just use\n> the result of expanding 00* directly.\n>\n> Signed-off-by: Junio C Hamano \n> ---\n> t/t5100-mailinfo.sh | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh\n> index 4e52b3b..85b3df5 100755\n> --- a/t/t5100-mailinfo.sh\n> +++ b/t/t5100-mailinfo.sh\n> @@ -23,7 +23,7 @@ check_mailinfo () {\n> }\n>\n>\n> -for mail in $(echo 00*)\n> +for mail in 00*\n> do\n> \ttest_expect_success \"mailinfo $mail\" '\n> \t\tcheck_mailinfo $mail \"\" &&\n> @@ -51,7 +51,7 @@ test_expect_success 'split box with rfc2047 samples' \\\n> \techo total is $last &&\n> \ttest $(cat rfc2047/last) = 11'\n>\n> -for mail in $(echo rfc2047/00*)\n> +for mail in rfc2047/00*\n> do\n> \ttest_expect_success \"mailinfo $mail\" '\n> \t\tgit mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&\n>\n\nSigned-off-by: Johannes Sixt \n\nThank you for making a proper patch!\n\n-- Hannes\n"}]}