{"thread":{"id":"41061","subject":"[PATCH 02/10] t/t1401-symbolic-ref.sh: use the $( ... ) construct for command substitution","startedAt":"2015-12-22T15:05:45Z","lastAt":"2015-12-22T21:33:07Z","messageCount":12,"participants":["Elia Pinto","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":10},"messages":[{"id":"274866","messageId":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":null,"subject":"[PATCH 00/10] use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:45Z","receivedAt":"2015-12-22T15:05:45Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"This patch series continues the changes introduced with the merge\n6753d8a85d543253d95184ec2faad6dc197f248:\n\n Merge branch 'ep/shell-command-substitution'\n\n Adjust shell scripts to use $(cmd) instead of `cmd`.\n\n\nThis is the second series, the other will be sent separately.\n\n\nElia Pinto (10):\n t/t1100-commit-tree-options.sh: use the $( ... ) construct for command\n substitution\n t/t1401-symbolic-ref.sh: use the $( ... ) construct for command\n substitution\n t/t1410-reflog.sh: use the $( ... ) construct for command substitution\n t/t1511-rev-parse-caret.sh: use the $( ... ) construct for command\n substitution\n t/t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for\n command substitution\n t/t1700-split-index.sh: use the $( ... ) construct for command\n substitution\n t/t2025-worktree-add.sh: use the $( ... ) construct for command\n substitution\n t/t2102-update-index-symlinks.sh: use the $( ... ) construct for\n command substitution\n t/t3030-merge-recursive.sh: use the $( ... ) construct for command\n substitution\n t/t3100-ls-tree-restrict.sh: use the $( ... ) construct for command\n substitution\n\n t/t1100-commit-tree-options.sh | 4 ++--\n t/t1401-symbolic-ref.sh | 2 +-\n t/t1410-reflog.sh | 24 ++++++++++++------------\n t/t1511-rev-parse-caret.sh | 4 ++--\n t/t1512-rev-parse-disambiguation.sh | 8 ++++----\n t/t1700-split-index.sh | 2 +-\n t/t2025-worktree-add.sh | 4 ++--\n t/t2102-update-index-symlinks.sh | 2 +-\n t/t3030-merge-recursive.sh | 2 +-\n t/t3100-ls-tree-restrict.sh | 2 +-\n 10 files changed, 27 insertions(+), 27 deletions(-)\n\n-- \n2.3.3.GIT\n"},{"id":"274870","messageId":"1450796755-15848-2-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 01/10] t/t1100-commit-tree-options.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:46Z","receivedAt":"2015-12-22T15:05:46Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1100-commit-tree-options.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh\nindex f8457f9..b7e9b4fc 100755\n--- a/t/t1100-commit-tree-options.sh\n+++ b/t/t1100-commit-tree-options.sh\n@@ -35,11 +35,11 @@ test_expect_success \\\n GIT_COMMITTER_NAME=\"Committer Name\" \\\n GIT_COMMITTER_EMAIL=\"committer@email\" \\\n GIT_COMMITTER_DATE=\"2005-05-26 23:30\" \\\n- TZ=GMT git commit-tree `cat treeid` >commitid 2>/dev/null'\n+ TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null'\n \n test_expect_success \\\n 'read commit' \\\n- 'git cat-file commit `cat commitid` >commit'\n+ 'git cat-file commit $(cat commitid) >commit'\n \n test_expect_success \\\n 'compare commit' \\\n-- \n2.3.3.GIT\n"},{"id":"274864","messageId":"1450796755-15848-3-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/10] t/t1401-symbolic-ref.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:47Z","receivedAt":"2015-12-22T15:05:47Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1401-symbolic-ref.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh\nindex 20b022a..e6c5830 100755\n--- a/t/t1401-symbolic-ref.sh\n+++ b/t/t1401-symbolic-ref.sh\n@@ -29,7 +29,7 @@ reset_to_sane\n \n test_expect_success 'symbolic-ref refuses bare sha1' '\n \techo content >file && git add file && git commit -m one &&\n-\ttest_must_fail git symbolic-ref HEAD `git rev-parse HEAD`\n+\ttest_must_fail git symbolic-ref HEAD $(git rev-parse HEAD)\n '\n reset_to_sane\n \n-- \n2.3.3.GIT\n"},{"id":"274874","messageId":"1450796755-15848-4-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/10] t/t1410-reflog.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:48Z","receivedAt":"2015-12-22T15:05:48Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1410-reflog.sh | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)\n\ndiff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh\nindex b79049f..fbed8d7 100755\n--- a/t/t1410-reflog.sh\n+++ b/t/t1410-reflog.sh\n@@ -62,18 +62,18 @@ test_expect_success setup '\n \tgit add . &&\n \n \ttest_tick && git commit -m rabbit &&\n-\tH=`git rev-parse --verify HEAD` &&\n-\tA=`git rev-parse --verify HEAD:A` &&\n-\tB=`git rev-parse --verify HEAD:A/B` &&\n-\tC=`git rev-parse --verify HEAD:C` &&\n-\tD=`git rev-parse --verify HEAD:A/D` &&\n-\tE=`git rev-parse --verify HEAD:A/B/E` &&\n+\tH=$(git rev-parse --verify HEAD) &&\n+\tA=$(git rev-parse --verify HEAD:A) &&\n+\tB=$(git rev-parse --verify HEAD:A/B) &&\n+\tC=$(git rev-parse --verify HEAD:C) &&\n+\tD=$(git rev-parse --verify HEAD:A/D) &&\n+\tE=$(git rev-parse --verify HEAD:A/B/E) &&\n \tcheck_fsck &&\n \n \ttest_chmod +x C &&\n \tgit add C &&\n \ttest_tick && git commit -m dragon &&\n-\tL=`git rev-parse --verify HEAD` &&\n+\tL=$(git rev-parse --verify HEAD) &&\n \tcheck_fsck &&\n \n \trm -f C A/B/E &&\n@@ -81,15 +81,15 @@ test_expect_success setup '\n \techo horse >A/G &&\n \tgit add F A/G &&\n \ttest_tick && git commit -a -m sheep &&\n-\tF=`git rev-parse --verify HEAD:F` &&\n-\tG=`git rev-parse --verify HEAD:A/G` &&\n-\tI=`git rev-parse --verify HEAD:A` &&\n-\tJ=`git rev-parse --verify HEAD` &&\n+\tF=$(git rev-parse --verify HEAD:F) &&\n+\tG=$(git rev-parse --verify HEAD:A/G) &&\n+\tI=$(git rev-parse --verify HEAD:A) &&\n+\tJ=$(git rev-parse --verify HEAD) &&\n \tcheck_fsck &&\n \n \trm -f A/G &&\n \ttest_tick && git commit -a -m monkey &&\n-\tK=`git rev-parse --verify HEAD` &&\n+\tK=$(git rev-parse --verify HEAD) &&\n \tcheck_fsck &&\n \n \tcheck_have A B C D E F G H I J K L &&\n-- \n2.3.3.GIT\n"},{"id":"274871","messageId":"1450796755-15848-5-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/10] t/t1511-rev-parse-caret.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:49Z","receivedAt":"2015-12-22T15:05:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1511-rev-parse-caret.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1511-rev-parse-caret.sh b/t/t1511-rev-parse-caret.sh\nindex 15973f2..7043ba7 100755\n--- a/t/t1511-rev-parse-caret.sh\n+++ b/t/t1511-rev-parse-caret.sh\n@@ -6,11 +6,11 @@ test_description='tests for ref^{stuff}'\n \n test_expect_success 'setup' '\n \techo blob >a-blob &&\n-\tgit tag -a -m blob blob-tag `git hash-object -w a-blob` &&\n+\tgit tag -a -m blob blob-tag $(git hash-object -w a-blob) &&\n \tmkdir a-tree &&\n \techo moreblobs >a-tree/another-blob &&\n \tgit add . &&\n-\tTREE_SHA1=`git write-tree` &&\n+\tTREE_SHA1=$(git write-tree) &&\n \tgit tag -a -m tree tree-tag \"$TREE_SHA1\" &&\n \tgit commit -m Initial &&\n \tgit tag -a -m commit commit-tag &&\n-- \n2.3.3.GIT\n"},{"id":"274872","messageId":"1450796755-15848-6-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/10] t/t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:50Z","receivedAt":"2015-12-22T15:05:50Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1512-rev-parse-disambiguation.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-disambiguation.sh\nindex 4a155c8..e221167 100755\n--- a/t/t1512-rev-parse-disambiguation.sh\n+++ b/t/t1512-rev-parse-disambiguation.sh\n@@ -275,19 +275,19 @@ test_expect_success 'rev-parse --disambiguate' '\n \n test_expect_success 'ambiguous 40-hex ref' '\n \tTREE=$(git mktree err` = $REF &&\n+\ttest $(git rev-parse $REF 2>err) = $REF &&\n \tgrep \"refname.*${REF}.*ambiguous\" err\n '\n \n test_expect_success 'ambiguous short sha1 ref' '\n \tTREE=$(git mktree err` = $VAL &&\n+\ttest $(git rev-parse $REF 2>err) = $VAL &&\n \tgrep \"refname.*${REF}.*ambiguous\" err\n '\n \n-- \n2.3.3.GIT\n"},{"id":"274868","messageId":"1450796755-15848-7-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/10] t/t1700-split-index.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:51Z","receivedAt":"2015-12-22T15:05:51Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1700-split-index.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh\nindex 193d55c..8aef49f 100755\n--- a/t/t1700-split-index.sh\n+++ b/t/t1700-split-index.sh\n@@ -55,7 +55,7 @@ test_expect_success 'disable split index' '\n EOF\n \ttest_cmp ls-files.expect ls-files.actual &&\n \n-\tBASE=`test-dump-split-index .git/index | grep \"^own\" | sed \"s/own/base/\"` &&\n+\tBASE=$(test-dump-split-index .git/index | grep \"^own\" | sed \"s/own/base/\") &&\n \ttest-dump-split-index .git/index | sed \"/^own/d\" >actual &&\n \tcat >expect <\n---\n t/t2025-worktree-add.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh\nindex 3694174..0a804da 100755\n--- a/t/t2025-worktree-add.sh\n+++ b/t/t2025-worktree-add.sh\n@@ -123,10 +123,10 @@ test_expect_success 'checkout from a bare repo without \"add\"' '\n test_expect_success 'checkout with grafts' '\n \ttest_when_finished rm .git/info/grafts &&\n \ttest_commit abc &&\n-\tSHA1=`git rev-parse HEAD` &&\n+\tSHA1=$(git rev-parse HEAD) &&\n \ttest_commit def &&\n \ttest_commit xyz &&\n-\techo \"`git rev-parse HEAD` $SHA1\" >.git/info/grafts &&\n+\techo \"$(git rev-parse HEAD) $SHA1\" >.git/info/grafts &&\n \tcat >expected <<-\\EOF &&\n \txyz\n \tabc\n-- \n2.3.3.GIT\n"},{"id":"274865","messageId":"1450796755-15848-9-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/10] t/t2102-update-index-symlinks.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:53Z","receivedAt":"2015-12-22T15:05:53Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t2102-update-index-symlinks.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t2102-update-index-symlinks.sh b/t/t2102-update-index-symlinks.sh\nindex 4d0d0a3..22f2c73 100755\n--- a/t/t2102-update-index-symlinks.sh\n+++ b/t/t2102-update-index-symlinks.sh\n@@ -23,7 +23,7 @@ git update-index symlink'\n \n test_expect_success \\\n 'the index entry must still be a symbolic link' '\n-case \"`git ls-files --stage --cached symlink`\" in\n+case \"$(git ls-files --stage --cached symlink)\" in\n 120000\" \"*symlink) echo pass;;\n *) echo fail; git ls-files --stage --cached symlink; (exit 1);;\n esac'\n-- \n2.3.3.GIT\n"},{"id":"274869","messageId":"1450796755-15848-10-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/10] t/t3030-merge-recursive.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:54Z","receivedAt":"2015-12-22T15:05:54Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3030-merge-recursive.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3030-merge-recursive.sh b/t/t3030-merge-recursive.sh\nindex 6224187..f7b0e59 100755\n--- a/t/t3030-merge-recursive.sh\n+++ b/t/t3030-merge-recursive.sh\n@@ -263,7 +263,7 @@ test_expect_success 'setup 8' '\n \ttest_ln_s_add e a &&\n \ttest_tick &&\n \tgit commit -m \"rename a->e, symlink a->e\" &&\n-\toln=`printf e | git hash-object --stdin`\n+\toln=$(printf e | git hash-object --stdin)\n '\n \n test_expect_success 'setup 9' '\n-- \n2.3.3.GIT\n"},{"id":"274873","messageId":"1450796755-15848-11-git-send-email-gitter.spiros@gmail.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/10] t/t3100-ls-tree-restrict.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-22T15:05:55Z","receivedAt":"2015-12-22T15:05:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n\tperl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\\$(\\1)/smg' \"${_f}\"\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3100-ls-tree-restrict.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3100-ls-tree-restrict.sh b/t/t3100-ls-tree-restrict.sh\nindex eb73c06..325114f 100755\n--- a/t/t3100-ls-tree-restrict.sh\n+++ b/t/t3100-ls-tree-restrict.sh\n@@ -28,7 +28,7 @@ test_expect_success \\\n echo Mi >path2/baz/b &&\n find path? \\( -type f -o -type l \\) -print |\n xargs git update-index --add &&\n- tree=`git write-tree` &&\n+ tree=$(git write-tree) &&\n echo $tree'\n \n test_output () {\n-- \n2.3.3.GIT\n"},{"id":"274918","messageId":"20151222213307.GB5243@google.com","threadId":"41061","inReplyTo":"1450796755-15848-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 00/10] use the $( ... ) construct for command substitution","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2015-12-22T21:33:07Z","receivedAt":"2015-12-22T21:33:07Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Elia Pinto wrote:\n\n> This is the second series, the other will be sent separately.\n\nReviewed-by: Jonathan Nieder \n"}]}