{"thread":{"id":"41004","subject":"[PATCHv3] Makefile: add missing phony target","startedAt":"2015-12-15T15:21:00Z","lastAt":"2015-12-16T08:25:01Z","messageCount":2,"participants":["Elia Pinto","Matthieu Moy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"274492","messageId":"1450192860-60337-1-git-send-email-gitter.spiros@gmail.com","threadId":"41004","inReplyTo":null,"subject":"[PATCHv3] Makefile: add missing phony target","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-12-15T15:21:00Z","receivedAt":"2015-12-15T15:21:00Z","isPatch":false,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Add some missing phony target to Makefile.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\nHelped-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>\n---\nThis is the third version of this patch.\n\nCompared to the previous I have added only the missing phony \ntarget as suggested by Matthieu Moy\n\n Makefile | 9 +++++++++\n 1 file changed, 9 insertions(+)\n\ndiff --git a/Makefile b/Makefile\nindex fd19b54..fc2f1ab 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2025,6 +2025,7 @@ $(VCSSVN_LIB): $(VCSSVN_OBJS)\n \n export DEFAULT_EDITOR DEFAULT_PAGER\n \n+.PHONY: doc man html info pdf\n doc:\n \t$(MAKE) -C Documentation all\n \n@@ -2068,6 +2069,7 @@ po/git.pot: $(GENERATED_H) FORCE\n \t\t$(LOCALIZED_PERL)\n \tmv $@+ $@\n \n+.PHONY: pot\n pot: po/git.pot\n \n POFILES := $(wildcard po/*.po)\n@@ -2277,6 +2279,7 @@ mergetools_instdir_SQ = $(subst ','\\'',$(mergetools_instdir))\n \n install_bindir_programs := $(patsubst %,%$X,$(BINDIR_PROGRAMS_NEED_X)) $(BINDIR_PROGRAMS_NO_X)\n \n+.PHONY: profile-install profile-fast-install\n profile-install: profile\n \t$(MAKE) install\n \n@@ -2343,6 +2346,8 @@ endif\n \tdone && \\\n \t./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n \n+.PHONY: install-gitweb install-doc install-man install-html install-info install-pdf\n+.PHONY: quick-install-doc quick-install-man quick-install-html\n install-gitweb:\n \t$(MAKE) -C gitweb install\n \n@@ -2402,6 +2407,7 @@ rpm: dist\n \n htmldocs = git-htmldocs-$(GIT_VERSION)\n manpages = git-manpages-$(GIT_VERSION)\n+.PHONY: dist-doc distclean\n dist-doc:\n \t$(RM) -r .doc-tmp-dir\n \tmkdir .doc-tmp-dir\n@@ -2470,6 +2476,8 @@ ALL_COMMANDS += git\n ALL_COMMANDS += gitk\n ALL_COMMANDS += gitweb\n ALL_COMMANDS += git-gui git-citool\n+\n+.PHONY: check-docs\n check-docs::\n \t@(for v in $(ALL_COMMANDS); \\\n \tdo \\\n@@ -2514,6 +2522,7 @@ check-builtins::\n ### Test suite coverage testing\n #\n .PHONY: coverage coverage-clean coverage-compile coverage-test coverage-report\n+.PHONY: coverage-untested-functions cover_db cover_db_html\n .PHONY: coverage-clean-results\n \n coverage:\n-- \n2.5.0\n"},{"id":"274560","messageId":"vpq1tamls0y.fsf@anie.imag.fr","threadId":"41004","inReplyTo":"1450192860-60337-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCHv3] Makefile: add missing phony target","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-12-16T08:25:01Z","receivedAt":"2015-12-16T08:25:01Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Elia Pinto <gitter.spiros@gmail.com> writes:\n\n> Add some missing phony target to Makefile.\n>\n> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>\n> Helped-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>\n> ---\n> This is the third version of this patch.\n\nThanks. I double-checked with\n\ngrep .PHONY Makefile | sed 's/.PHONY: //; s/#.*//' | tr ' ' '\\n' | sort | uniq -c | sort -n\n\nthere are no duplicate .PHONY, and all .PHONY targets are indeed .PHONY\nones, so the patch is now\n\nReviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>\n\n> Compared to the previous I have added only the missing phony \n> target as suggested by Matthieu Moy\n\nNote: my comments were not meant to be an objection to the additional\nrefactoring. At least some of the hunks definitely made sense to me, but\nthey are better done in a separate patch.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}