{"thread":{"id":"40929","subject":"[PATCH] document submodule sync --recursive","startedAt":"2015-12-03T19:33:27Z","lastAt":"2015-12-04T21:08:13Z","messageCount":5,"participants":["Stefan Beller","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273984","messageId":"1449171207-27201-1-git-send-email-sbeller@google.com","threadId":"40929","inReplyTo":null,"subject":"[PATCH] document submodule sync --recursive","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-12-03T19:33:27Z","receivedAt":"2015-12-03T19:33:27Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The git-submodule(1) is inconsistent. In the synopsis, it says:\n\n       git submodule [--quiet] sync [--recursive] [--] [<path>...]\n\nThe description of the sync does not mention --recursive, and the\ndescription of --recursive says that it is only available for foreach,\nupdate and status.\n\nThe option appears to work, so the documentation should be\nupdated.\n\nTested-by: Per Cederqvist <cederp@opera.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n\n This applies on origin/master.\n \n Thanks Per for reporting,\n Stefan\n\n Documentation/git-submodule.txt | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\nindex f17687e..cd8d126 100644\n--- a/Documentation/git-submodule.txt\n+++ b/Documentation/git-submodule.txt\n@@ -237,6 +237,9 @@ sync::\n +\n \"git submodule sync\" synchronizes all submodules while\n \"git submodule sync \\-- A\" synchronizes submodule \"A\" only.\n++\n+If `--recursive` is specified, this command will recurse into the\n+registered submodules, and update any nested submodules within.\n \n OPTIONS\n -------\n@@ -364,7 +367,7 @@ the submodule itself.\n for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.\n \n --recursive::\n-\tThis option is only valid for foreach, update and status commands.\n+\tThis option is only valid for foreach, update, status and sync commands.\n \tTraverse submodules recursively. The operation is performed not\n \tonly in the submodules of the current repo, but also\n \tin any nested submodules inside those submodules (and so on).\n-- \n2.6.1.255.gcc3df29.dirty\n"},{"id":"273988","messageId":"xmqqh9jzthh3.fsf@gitster.mtv.corp.google.com","threadId":"40929","inReplyTo":"1449171207-27201-1-git-send-email-sbeller@google.com","subject":"Re: [PATCH] document submodule sync --recursive","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-03T20:17:12Z","receivedAt":"2015-12-03T20:17:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller <sbeller@google.com> writes:\n\n> The git-submodule(1) is inconsistent. In the synopsis, it says:\n>\n>        git submodule [--quiet] sync [--recursive] [--] [<path>...]\n>\n> The description of the sync does not mention --recursive, and the\n> description of --recursive says that it is only available for foreach,\n> update and status.\n>\n> The option appears to work, so the documentation should be\n> updated.\n>\n> Tested-by: Per Cederqvist <cederp@opera.com>\n\nIsn't this Reported-by? (genuine question; I haven't caught up with\nmy inbox backlog and do not claim having seen everything Per wrote\nto this list).\n\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n>\n>  This applies on origin/master.\n\nThanks.  Should it go to maintenance track (iow, was the feature\nthat wasn't documented already in maint)?\n\n>  \n>  Thanks Per for reporting,\n>  Stefan\n>\n>  Documentation/git-submodule.txt | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\n> index f17687e..cd8d126 100644\n> --- a/Documentation/git-submodule.txt\n> +++ b/Documentation/git-submodule.txt\n> @@ -237,6 +237,9 @@ sync::\n>  +\n>  \"git submodule sync\" synchronizes all submodules while\n>  \"git submodule sync \\-- A\" synchronizes submodule \"A\" only.\n> ++\n> +If `--recursive` is specified, this command will recurse into the\n> +registered submodules, and update any nested submodules within.\n>  \n>  OPTIONS\n>  -------\n> @@ -364,7 +367,7 @@ the submodule itself.\n>  for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.\n>  \n>  --recursive::\n> -\tThis option is only valid for foreach, update and status commands.\n> +\tThis option is only valid for foreach, update, status and sync commands.\n>  \tTraverse submodules recursively. The operation is performed not\n>  \tonly in the submodules of the current repo, but also\n>  \tin any nested submodules inside those submodules (and so on).\n"},{"id":"273989","messageId":"CAGZ79kaX4ZM++jhPcpU0T8eYDobME=iNtbH3KceWbQOOavpHnA@mail.gmail.com","threadId":"40929","inReplyTo":"xmqqh9jzthh3.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] document submodule sync --recursive","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-12-03T20:22:04Z","receivedAt":"2015-12-03T20:22:04Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Dec 3, 2015 at 12:17 PM, Junio C Hamano <gitster@pobox.com> wrote:\n>>\n>> Tested-by: Per Cederqvist <cederp@opera.com>\n>\n> Isn't this Reported-by? (genuine question; I haven't caught up with\n> my inbox backlog and do not claim having seen everything Per wrote\n> to this list).\n\nPer wrote he tested `git submodule sync --recursive` with 2.6.3,\nso yeah the tested refers to the underlying command, not this patch.\nSo Reported-by is better here.\n\n>\n>> Signed-off-by: Stefan Beller <sbeller@google.com>\n>> ---\n>>\n>>  This applies on origin/master.\n>\n> Thanks.  Should it go to maintenance track (iow, was the feature\n> that wasn't documented already in maint)?\n\nIt was introduced via\n(82f49f294c,  Teach --recursive to submodule sync, 2012-10-26)\nso I guess maint is fine, too\n\n>> @@ -237,6 +237,9 @@ sync::\n>>  +\n>>  \"git submodule sync\" synchronizes all submodules while\n>>  \"git submodule sync \\-- A\" synchronizes submodule \"A\" only.\n>> ++\n>> +If `--recursive` is specified, this command will recurse into the\n>> +registered submodules, and update any nested submodules within.\n\nI should have paid more attention here and s/update/sync/.\n\nI'll prepare a resend.\n"},{"id":"273990","messageId":"1449175262-3724-1-git-send-email-sbeller@google.com","threadId":"40929","inReplyTo":"CAGZ79kaX4ZM++jhPcpU0T8eYDobME=iNtbH3KceWbQOOavpHnA@mail.gmail.com","subject":"[PATCHv2] document submodule sync --recursive","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-12-03T20:41:02Z","receivedAt":"2015-12-03T20:41:02Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The git-submodule(1) is inconsistent. In the synopsis, it says:\n\n       git submodule [--quiet] sync [--recursive] [--] [<path>...]\n\nThe description of the sync does not mention --recursive, and the\ndescription of --recursive says that it is only available for foreach,\nupdate and status.\n\nThe option was introduced (82f49f294c, Teach --recursive to submodule\nsync, 2012-10-26) a while ago, so let's document it, too.\n\nReported-by: Per Cederqvist <cederp@opera.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n\n This applies on either origin/master or origin/maint.\n \n Thanks,\n Stefan\n \n Documentation/git-submodule.txt | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\nindex f17687e..1572f05 100644\n--- a/Documentation/git-submodule.txt\n+++ b/Documentation/git-submodule.txt\n@@ -237,6 +237,9 @@ sync::\n +\n \"git submodule sync\" synchronizes all submodules while\n \"git submodule sync \\-- A\" synchronizes submodule \"A\" only.\n++\n+If `--recursive` is specified, this command will recurse into the\n+registered submodules, and sync any nested submodules within.\n \n OPTIONS\n -------\n@@ -364,7 +367,7 @@ the submodule itself.\n for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.\n \n --recursive::\n-\tThis option is only valid for foreach, update and status commands.\n+\tThis option is only valid for foreach, update, status and sync commands.\n \tTraverse submodules recursively. The operation is performed not\n \tonly in the submodules of the current repo, but also\n \tin any nested submodules inside those submodules (and so on).\n-- \n2.6.1.255.gcc3df29.dirty\n"},{"id":"274024","messageId":"xmqqvb8drkg2.fsf@gitster.mtv.corp.google.com","threadId":"40929","inReplyTo":"1449175262-3724-1-git-send-email-sbeller@google.com","subject":"Re: [PATCHv2] document submodule sync --recursive","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-04T21:08:13Z","receivedAt":"2015-12-04T21:08:13Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, will queue.\n"}]}