{"thread":{"id":"40925","subject":"[PATCH] Fix quoting of redirect in test script","startedAt":"2015-12-02T20:50:07Z","lastAt":"2015-12-04T21:39:44Z","messageCount":3,"participants":["Charles Bailey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273936","messageId":"1449089407-14921-1-git-send-email-charles@hashpling.org","threadId":"40925","inReplyTo":null,"subject":"[PATCH] Fix quoting of redirect in test script","fromName":"Charles Bailey","fromEmail":"charles@hashpling.org","sentAt":"2015-12-02T20:50:07Z","receivedAt":"2015-12-02T20:50:07Z","isPatch":true,"sender":{"key":"charles@hashpling.org","avatar":"https://avatars.githubusercontent.com/u/1668475?v=4"},"body":"From: Charles Bailey <cbailey32@bloomberg.net>\n\n---\n t/t3404-rebase-interactive.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\nIf you are using bash (at least 4.3.30 or 4.3.42) this actually causes\nan error due to an \"ambiguous redirect\" because there is a space in\n\"trash directory\".\n\ndiff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh\nindex 98eb49a..9067e02 100755\n--- a/t/t3404-rebase-interactive.sh\n+++ b/t/t3404-rebase-interactive.sh\n@@ -1234,7 +1234,7 @@ test_expect_success 'tabs and spaces are accepted in the todolist' '\n \t\t# Turn single spaces into space/tab mix\n \t\tsed \"1s/ /\t/g; 2s/ /  /g; 3s/ / \t/g\" \"$1\"\n \t\tprintf \"\\n\\t# comment\\n #more\\n\\t # comment\\n\"\n-\t) >$1.new\n+\t) >\"$1.new\"\n \tmv \"$1.new\" \"$1\"\n \tEOF\n \ttest_set_editor \"$(pwd)/add-indent.sh\" &&\n-- \n2.4.0.53.g8440f74\n"},{"id":"274023","messageId":"xmqqzixprkkv.fsf@gitster.mtv.corp.google.com","threadId":"40925","inReplyTo":"1449089407-14921-1-git-send-email-charles@hashpling.org","subject":"Re: [PATCH] Fix quoting of redirect in test script","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-04T21:05:20Z","receivedAt":"2015-12-04T21:05:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Do you want to sign-off this patch?\n\nThanks.\n"},{"id":"274029","messageId":"20151204213944.GA14137@hashpling.org","threadId":"40925","inReplyTo":"xmqqzixprkkv.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Fix quoting of redirect in test script","fromName":"Charles Bailey","fromEmail":"charles@hashpling.org","sentAt":"2015-12-04T21:39:44Z","receivedAt":"2015-12-04T21:39:44Z","isPatch":true,"sender":{"key":"charles@hashpling.org","avatar":"https://avatars.githubusercontent.com/u/1668475?v=4"},"body":"On Fri, Dec 04, 2015 at 01:05:20PM -0800, Junio C Hamano wrote:\n> Do you want to sign-off this patch?\n> \n> Thanks.\n\nOops, yes please.\n\nSigned-off-by: Charles Bailey <cbailey32@bloomberg.net>\n"}]}