{"thread":{"id":"40921","subject":"[PATCH] show signature of commit in gitk","startedAt":"2015-12-02T19:19:25Z","lastAt":"2015-12-13T18:10:10Z","messageCount":3,"participants":["Daniel Fahlke","Mike Rappazzo"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273931","messageId":"565F443D.7050205@cotya.com","threadId":"40921","inReplyTo":null,"subject":"[PATCH] show signature of commit in gitk","fromName":"Daniel Fahlke","fromEmail":"flyingmana@cotya.com","sentAt":"2015-12-02T19:19:25Z","receivedAt":"2015-12-02T19:19:25Z","isPatch":true,"sender":{"key":"flyingmana@cotya.com","avatar":"https://gravatar.com/avatar/8fc1377184bbaea5f179d4819d1bf79a23a17aeed52280c6220979286a0fcef9?d=mp&s=160"},"body":"but still depending on the added --show-signature as argument\n\nlonger explanation:\ngit supports for some time now signed commits, and also show the\nsignature and its trust level inside the `git log` command.\nNow, it can also get shown in gitk.\n\nSigned-off-by: Flyingmana <flyingmana@googlemail.com>\n---\n gitk-git/gitk | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex fcc606e..54c167f 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -1674,6 +1674,7 @@ proc parsecommit {id contents listed} {\n     set audate {}\n     set comname {}\n     set comdate {}\n+    set comgpg {}\n     set hdrend [string first \"\\n\\n\" $contents]\n     if {$hdrend < 0} {\n \t# should never happen...\n@@ -1690,6 +1691,9 @@ proc parsecommit {id contents listed} {\n \t} elseif {$tag == \"committer\"} {\n \t    set comdate [lrange $line end-1 end]\n \t    set comname [join [lrange $line 1 end-2] \" \"]\n+\t} elseif {$tag == \"gpg:\"} {\n+\t    append comgpg [join [lrange $line 1 end] \" \"]\n+\t    append comgpg \"\\n\"\n \t}\n     }\n     set headline {}\n@@ -1726,7 +1730,7 @@ proc parsecommit {id contents listed} {\n \tset comment [string range $comment 0 $i-1]\n     }\n     set commitinfo($id) [list $headline $auname $audate \\\n-\t\t\t     $comname $comdate $comment $hasnote $diff]\n+\t\t\t     $comname $comdate $comment $hasnote $diff $comgpg]\n }\n  proc getcommit {id} {\n@@ -7325,6 +7329,7 @@ proc selectline {l isnew {desired_loc {}}\n{switch_to_patch 0}} {\n     $ctext insert end \"[mc \"Author\"]: [lindex $info 1]  $date\\n\"\n     set date [formatdate [lindex $info 4]]\n     $ctext insert end \"[mc \"Committer\"]: [lindex $info 3]  $date\\n\"\n+    $ctext insert end [lindex $info 8]\n     if {[info exists idtags($id)]} {\n \t$ctext insert end [mc \"Tags:\"]\n \tforeach tag $idtags($id) {\n-- \n2.6.3\n"},{"id":"274346","messageId":"566D7D82.90107@cotya.com","threadId":"40921","inReplyTo":"565F443D.7050205@cotya.com","subject":"Re: [PATCH] show signature of commit in gitk","fromName":"Daniel Fahlke","fromEmail":"flyingmana@cotya.com","sentAt":"2015-12-13T14:15:30Z","receivedAt":"2015-12-13T14:15:30Z","isPatch":true,"sender":{"key":"flyingmana@cotya.com","avatar":"https://gravatar.com/avatar/8fc1377184bbaea5f179d4819d1bf79a23a17aeed52280c6220979286a0fcef9?d=mp&s=160"},"body":"It seems my Patch got no attention yet, is there anything wrong? \nDo I need to ping someone in particular?\n\nOn 12/02/2015 08:19 PM, Daniel Fahlke wrote:\n> but still depending on the added --show-signature as argument\n> \n> longer explanation:\n> git supports for some time now signed commits, and also show the\n> signature and its trust level inside the `git log` command.\n> Now, it can also get shown in gitk.\n> \n> Signed-off-by: Flyingmana <flyingmana@googlemail.com>\n> ---\n>  gitk-git/gitk | 7 ++++++-\n>  1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index fcc606e..54c167f 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -1674,6 +1674,7 @@ proc parsecommit {id contents listed} {\n>      set audate {}\n>      set comname {}\n>      set comdate {}\n> +    set comgpg {}\n>      set hdrend [string first \"\\n\\n\" $contents]\n>      if {$hdrend < 0} {\n>  \t# should never happen...\n> @@ -1690,6 +1691,9 @@ proc parsecommit {id contents listed} {\n>  \t} elseif {$tag == \"committer\"} {\n>  \t    set comdate [lrange $line end-1 end]\n>  \t    set comname [join [lrange $line 1 end-2] \" \"]\n> +\t} elseif {$tag == \"gpg:\"} {\n> +\t    append comgpg [join [lrange $line 1 end] \" \"]\n> +\t    append comgpg \"\\n\"\n>  \t}\n>      }\n>      set headline {}\n> @@ -1726,7 +1730,7 @@ proc parsecommit {id contents listed} {\n>  \tset comment [string range $comment 0 $i-1]\n>      }\n>      set commitinfo($id) [list $headline $auname $audate \\\n> -\t\t\t     $comname $comdate $comment $hasnote $diff]\n> +\t\t\t     $comname $comdate $comment $hasnote $diff $comgpg]\n>  }\n>   proc getcommit {id} {\n> @@ -7325,6 +7329,7 @@ proc selectline {l isnew {desired_loc {}}\n> {switch_to_patch 0}} {\n>      $ctext insert end \"[mc \"Author\"]: [lindex $info 1]  $date\\n\"\n>      set date [formatdate [lindex $info 4]]\n>      $ctext insert end \"[mc \"Committer\"]: [lindex $info 3]  $date\\n\"\n> +    $ctext insert end [lindex $info 8]\n>      if {[info exists idtags($id)]} {\n>  \t$ctext insert end [mc \"Tags:\"]\n>  \tforeach tag $idtags($id) {\n> \n"},{"id":"274353","messageId":"CANoM8SVhRe5HqJXjizZBp7Qdg-9ig7HQGyEDEZOxYKzZqaX5MQ@mail.gmail.com","threadId":"40921","inReplyTo":"566D7D82.90107@cotya.com","subject":"Re: [PATCH] show signature of commit in gitk","fromName":"Mike Rappazzo","fromEmail":"rappazzo@gmail.com","sentAt":"2015-12-13T18:10:10Z","receivedAt":"2015-12-13T18:10:10Z","isPatch":true,"sender":{"key":"rappazzo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/525287?v=4"},"body":"On Sun, Dec 13, 2015 at 9:15 AM, Daniel Fahlke <flyingmana@cotya.com> wrote:\n> It seems my Patch got no attention yet, is there anything wrong?\n> Do I need to ping someone in particular?\n>\n\ngitk patches should cc +Paul Mackerras <paulus@samba.org> who maintains gitk\n"}]}