{"thread":{"id":"4088","subject":"[PATCH] Sparse fix for builtin-diff","startedAt":"2006-05-07T14:50:47Z","lastAt":"2006-05-07T20:43:26Z","messageCount":2,"participants":["Peter Hagervall","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"19649","messageId":"20060507145046.GA24882@peppar.cs.umu.se","threadId":"4088","inReplyTo":null,"subject":"[PATCH] Sparse fix for builtin-diff","fromName":"Peter Hagervall","fromEmail":"hager@cs.umu.se","sentAt":"2006-05-07T14:50:47Z","receivedAt":"2006-05-07T14:50:47Z","isPatch":true,"sender":{"key":"hager@cs.umu.se","avatar":null},"body":"You gotta love sparse:\n\nbuiltin-diff.c:88:4: error: Just how const do you want this type to be?\n\nSigned-off-by: Peter Hagervall <hager@cs.umu.se>\n---\n\n builtin-diff.c |    3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-diff.c b/builtin-diff.c\nindex 636edbf..d3ac581 100644\n--- a/builtin-diff.c\n+++ b/builtin-diff.c\n@@ -84,8 +84,7 @@ static void stuff_change(struct diff_opt\n \n \tif (opt->reverse_diff) {\n \t\tunsigned tmp;\n-\t\tconst\n-\t\t\tconst unsigned char *tmp_u;\n+\t\tconst unsigned char *tmp_u;\n \t\tconst char *tmp_c;\n \t\ttmp = old_mode; old_mode = new_mode; new_mode = tmp;\n \t\ttmp_u = old_sha1; old_sha1 = new_sha1; new_sha1 = tmp_u;\n"},{"id":"19663","messageId":"7vpsiplg5t.fsf@assigned-by-dhcp.cox.net","threadId":"4088","inReplyTo":"20060507145046.GA24882@peppar.cs.umu.se","subject":"Re: [PATCH] Sparse fix for builtin-diff","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-07T20:43:26Z","receivedAt":"2006-05-07T20:43:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter Hagervall <hager@cs.umu.se> writes:\n\n> You gotta love sparse:\n>\n> builtin-diff.c:88:4: error: Just how const do you want this type to be?\n\nLOL.\n\n> -\t\tconst\n> -\t\t\tconst unsigned char *tmp_u;\n> +\t\tconst unsigned char *tmp_u;\n\nI wondered how this bit snuck in, but it was like that\nfrom the beginning, my bad.\n\nThanks.\n"}]}