{"thread":{"id":"40859","subject":"[PATCH] http: treat config options sslCAPath and sslCAInfo as paths","startedAt":"2015-11-23T12:02:40Z","lastAt":"2015-11-24T23:53:17Z","messageCount":2,"participants":["charles@hashpling.org","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273604","messageId":"1448280160-113572-1-git-send-email-charles@hashpling.org","threadId":"40859","inReplyTo":null,"subject":"[PATCH] http: treat config options sslCAPath and sslCAInfo as paths","fromName":"","fromEmail":"charles@hashpling.org","sentAt":"2015-11-23T12:02:40Z","receivedAt":"2015-11-23T12:02:40Z","isPatch":true,"sender":{"key":"charles@hashpling.org","avatar":"https://avatars.githubusercontent.com/u/1668475?v=4"},"body":"From: Charles Bailey <cbailey32@bloomberg.net>\n\nThis enables ~ and ~user expansion for these config options.\n\nSigned-off-by: Charles Bailey <cbailey32@bloomberg.net>\n---\n\nIn the only place that we (optionally) test https specifically, we also\nturn off SSL verification so I couldn't see a sensible way to add an\nautomated test.\n\nThe change is fairly simple and I've tested manually and the effects are\nas I expected - I can point to a certificate bundle or directory in my\nhome directory using a ~/ prefix in my .gitconfig.\n\n http.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/http.c b/http.c\nindex 42f29ce..5e37252 100644\n--- a/http.c\n+++ b/http.c\n@@ -214,10 +214,10 @@ static int http_options(const char *var, const char *value, void *cb)\n #endif\n #if LIBCURL_VERSION_NUM >= 0x070908\n \tif (!strcmp(\"http.sslcapath\", var))\n-\t\treturn git_config_string(&ssl_capath, var, value);\n+\t\treturn git_config_pathname(&ssl_capath, var, value);\n #endif\n \tif (!strcmp(\"http.sslcainfo\", var))\n-\t\treturn git_config_string(&ssl_cainfo, var, value);\n+\t\treturn git_config_pathname(&ssl_cainfo, var, value);\n \tif (!strcmp(\"http.sslcertpasswordprotected\", var)) {\n \t\tssl_cert_password_required = git_config_bool(var, value);\n \t\treturn 0;\n-- \n2.6.0\n"},{"id":"273677","messageId":"20151124235316.GD13872@sigill.intra.peff.net","threadId":"40859","inReplyTo":"1448280160-113572-1-git-send-email-charles@hashpling.org","subject":"Re: [PATCH] http: treat config options sslCAPath and sslCAInfo as paths","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-11-24T23:53:17Z","receivedAt":"2015-11-24T23:53:17Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Nov 23, 2015 at 12:02:40PM +0000, charles@hashpling.org wrote:\n\n> From: Charles Bailey <cbailey32@bloomberg.net>\n> \n> This enables ~ and ~user expansion for these config options.\n\nThanks, this seems like the obviously correct thing to do.\n\n> In the only place that we (optionally) test https specifically, we also\n> turn off SSL verification so I couldn't see a sensible way to add an\n> automated test.\n> \n> The change is fairly simple and I've tested manually and the effects are\n> as I expected - I can point to a certificate bundle or directory in my\n> home directory using a ~/ prefix in my .gitconfig.\n\nYeah, I agree that testing such a trivial feature is not worth the\ninfrastructure it would require adding to the test suite.\n\n-Peff\n"}]}