{"thread":{"id":"40831","subject":"[BUG] gitk --all and git bisect visualize crash in non-english locale","startedAt":"2015-11-18T18:31:15Z","lastAt":"2015-11-20T14:49:08Z","messageCount":3,"participants":["Matthieu Moy","Dennis Kaarsemaker"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"273480","messageId":"vpqa8qbrwgc.fsf@anie.imag.fr","threadId":"40831","inReplyTo":null,"subject":"[BUG] gitk --all and git bisect visualize crash in non-english locale","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-11-18T18:31:15Z","receivedAt":"2015-11-18T18:31:15Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Hi,\n\nI'm getting the following crash on recent gitk:\n\n  $ LANG=fr_FR gitk --all\n  Error in startup script: bad menu entry index \"Éditer la vue...\"\n      while executing\n  \".bar.view entryconf [mca \"Edit view...\"] -state normal\"\n      invoked from within\n  \"if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {\n      # create a view for the files/dirs specified on the command line\n      se...\"\n      (file \"/home/moy/local/usr-jessie/bin/gitk\" line 12442)\n\nIt's linked to the locale:\n\n  $ LANG=C gitk --all\n  # Just works\n\nbut does not seem to be related to French in particular nor to the\naccent:\n\n  $ LANG=es_ES gitk --all\n  Error in startup script: bad menu entry index \"Modificar vista...\"\n      while executing\n  \".bar.view entryconf [mca \"Edit view...\"] -state normal\"\n      invoked from within\n  \"if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {\n      # create a view for the files/dirs specified on the command line\n      se...\"\n      (file \"/home/moy/local/usr-jessie/bin/gitk\" line 12442)\n\nIt also works fine without --all.\n\nIt bisects down to:\n\ncommit d99b4b0de27a2bd654a40353b65883e368da6d06\nAuthor: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\nDate:   Wed Sep 9 15:20:53 2015 +0200\n\n    gitk: Accelerators for the main menu\n    \n    This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N to open a\n    new view).\n    \n    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n    Signed-off-by: Paul Mackerras <paulus@samba.org>\n\nI'm not fluent enough in Tcl to fix this myself, sorry ;-).\n\nThanks,\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"273486","messageId":"1447883599.28206.1.camel@kaarsemaker.net","threadId":"40831","inReplyTo":"vpqa8qbrwgc.fsf@anie.imag.fr","subject":"Re: [BUG] gitk --all and git bisect visualize crash in non-english locale","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2015-11-18T21:53:19Z","receivedAt":"2015-11-18T21:53:19Z","isPatch":false,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"Hi Matthieu,\n\nThis has been reported quite a few times before. A fix is in master,\nsee 482456a^2 and children.\n\nOn wo, 2015-11-18 at 19:31 +0100, Matthieu Moy wrote:\n> Hi,\n> \n> I'm getting the following crash on recent gitk:\n> \n>   $ LANG=fr_FR gitk --all\n>   Error in startup script: bad menu entry index \"Éditer la vue...\"\n>       while executing\n>   \".bar.view entryconf [mca \"Edit view...\"] -state normal\"\n>       invoked from within\n>   \"if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd\n> ne {}} {\n>       # create a view for the files/dirs specified on the command\n> line\n>       se...\"\n>       (file \"/home/moy/local/usr-jessie/bin/gitk\" line 12442)\n> \n> It's linked to the locale:\n> \n>   $ LANG=C gitk --all\n>   # Just works\n> \n> but does not seem to be related to French in particular nor to the\n> accent:\n> \n>   $ LANG=es_ES gitk --all\n>   Error in startup script: bad menu entry index \"Modificar vista...\"\n>       while executing\n>   \".bar.view entryconf [mca \"Edit view...\"] -state normal\"\n>       invoked from within\n>   \"if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd\n> ne {}} {\n>       # create a view for the files/dirs specified on the command\n> line\n>       se...\"\n>       (file \"/home/moy/local/usr-jessie/bin/gitk\" line 12442)\n> \n> It also works fine without --all.\n> \n> It bisects down to:\n> \n> commit d99b4b0de27a2bd654a40353b65883e368da6d06\n> Author: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n> Date:   Wed Sep 9 15:20:53 2015 +0200\n> \n>     gitk: Accelerators for the main menu\n>     \n>     This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N\n> to open a\n>     new view).\n>     \n>     Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n>     Signed-off-by: Paul Mackerras <paulus@samba.org>\n> \n> I'm not fluent enough in Tcl to fix this myself, sorry ;-).\n> \n> Thanks,\n> \n\n-- \nDennis Kaarsemaker\nwww.kaarsemaker.net\n"},{"id":"273546","messageId":"vpqk2pchgkb.fsf@anie.imag.fr","threadId":"40831","inReplyTo":"1447883599.28206.1.camel@kaarsemaker.net","subject":"Re: [BUG] gitk --all and git bisect visualize crash in non-english locale","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-11-20T14:49:08Z","receivedAt":"2015-11-20T14:49:08Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Indeed. I should obviously have started by updating my master branch,\nsorry for the noise.\n\nThanks,\n\nDennis Kaarsemaker <dennis@kaarsemaker.net> writes:\n\n> Hi Matthieu,\n>\n> This has been reported quite a few times before. A fix is in master,\n> see 482456a^2 and children.\n>\n> On wo, 2015-11-18 at 19:31 +0100, Matthieu Moy wrote:\n>> Hi,\n>> \n>> I'm getting the following crash on recent gitk:\n>> \n>>   $ LANG=fr_FR gitk --all\n>>   Error in startup script: bad menu entry index \"Éditer la vue...\"\n>>       while executing\n>>   \".bar.view entryconf [mca \"Edit view...\"] -state normal\"\n>>       invoked from within\n>>   \"if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd\n>> ne {}} {\n>>       # create a view for the files/dirs specified on the command\n>> line\n>>       se...\"\n>>       (file \"/home/moy/local/usr-jessie/bin/gitk\" line 12442)\n>> \n>> It's linked to the locale:\n>> \n>>   $ LANG=C gitk --all\n>>   # Just works\n>> \n>> but does not seem to be related to French in particular nor to the\n>> accent:\n>> \n>>   $ LANG=es_ES gitk --all\n>>   Error in startup script: bad menu entry index \"Modificar vista...\"\n>>       while executing\n>>   \".bar.view entryconf [mca \"Edit view...\"] -state normal\"\n>>       invoked from within\n>>   \"if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd\n>> ne {}} {\n>>       # create a view for the files/dirs specified on the command\n>> line\n>>       se...\"\n>>       (file \"/home/moy/local/usr-jessie/bin/gitk\" line 12442)\n>> \n>> It also works fine without --all.\n>> \n>> It bisects down to:\n>> \n>> commit d99b4b0de27a2bd654a40353b65883e368da6d06\n>> Author: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n>> Date:   Wed Sep 9 15:20:53 2015 +0200\n>> \n>>     gitk: Accelerators for the main menu\n>>     \n>>     This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N\n>> to open a\n>>     new view).\n>>     \n>>     Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n>>     Signed-off-by: Paul Mackerras <paulus@samba.org>\n>> \n>> I'm not fluent enough in Tcl to fix this myself, sorry ;-).\n>> \n>> Thanks,\n>> \n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}